From fa5f643000ebffda464fef611a0bf788900c369d Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Mon, 1 Aug 2022 13:55:35 -0300 Subject: [PATCH] Bug 23919: (QA follow-up) Tidy query build code This is really opinionated, but I found this to be much cleaner to read and thought it was worth pusing as well. Signed-off-by: Tomas Cohen Arazi --- C4/Search.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/Search.pm b/C4/Search.pm index 6c7bdab426..0ff4d2361e 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -1416,14 +1416,14 @@ sub buildQuery { if ( $index eq 'nb' ) { if ( C4::Context->preference("SearchWithISBNVariations") ) { my @isbns = C4::Koha::GetVariationsOfISBN( $operand ); - $operands[$i] = $operand = '(nb=' . join(' OR nb=', @isbns) . ')'; + $operands[$i] = $operand = '(' . join( ' OR ', map { 'nb=' . $_ } @isbns ) . ')'; $indexes[$i] = $index = 'kw'; } } if ( $index eq 'ns' ) { if ( C4::Context->preference("SearchWithISSNVariations") ) { my @issns = C4::Koha::GetVariationsOfISSN( $operand ); - $operands[$i] = $operand = '(ns=' . join(' OR ns=', @issns) . ')'; + $operands[$i] = $operand = '(' . join( ' OR ', map { 'ns=' . $_ } @issns ) . ')'; $indexes[$i] = $index = 'kw'; } } -- 2.39.5