From 5c2398c005548ebe3dbbc0b1f54863b9ff30e8b4 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 25 Oct 2011 10:16:02 -0400 Subject: [PATCH] Fix for Bug 7085 - Problems with searching for orders in acquisitions Changing "if ( defined $input )" to "if ( $input )" in the section of the script which builds the order search query seems to give successful searches where they didn't exist before. Searches from the advanced order search screen work with title, author, vendor, basket number, date, etc. Signed-off-by: Katrin Fischer Searches for date ranges, title and author keywords give me the correct results now. (cherry picked from commit 0c0ddf92113b4a5df6833f75ba5b7ad7527c5f48) Signed-off-by: Chris Nighswonger --- C4/Acquisition.pm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm index 19c4f087c2..a0dda4284b 100644 --- a/C4/Acquisition.pm +++ b/C4/Acquisition.pm @@ -1581,33 +1581,33 @@ sub GetHistory { my @query_params = (); - if ( defined $title ) { + if ( $title ) { $query .= " AND biblio.title LIKE ? "; $title =~ s/\s+/%/g; push @query_params, "%$title%"; } - if ( defined $author ) { + if ( $author ) { $query .= " AND biblio.author LIKE ? "; push @query_params, "%$author%"; } - if ( defined $isbn ) { + if ( $isbn ) { $query .= " AND biblioitems.isbn LIKE ? "; push @query_params, "%$isbn%"; } - if ( defined $name ) { + if ( $name ) { $query .= " AND aqbooksellers.name LIKE ? "; push @query_params, "%$name%"; } - if ( defined $from_placed_on ) { + if ( $from_placed_on ) { $query .= " AND creationdate >= ? "; push @query_params, $from_placed_on; } - if ( defined $to_placed_on ) { + if ( $to_placed_on ) { $query .= " AND creationdate <= ? "; push @query_params, $to_placed_on; } -- 2.39.5