From a42512dbf3c45b9b4502dd81829a196c8ebd2889 Mon Sep 17 00:00:00 2001 From: Janusz Kaczmarek Date: Sun, 1 May 2022 23:59:09 +0200 Subject: [PATCH] Bug 30658: (bug 29496 follow-up) CheckMandatorySubfields don't work properly with select field in serials-edit.tt for Supplemental issue CheckMandatorySubfields use the class "input_marceditor" but in file serials-edit.tt this class is not set for select input in Supplemental issue form. In consequence if a select field is set as mandatory, it is detected as missing even if it is filed and so you can't submit the form and receive the new supplemantal issue. Test plan: 1- Create (or find) a subscription for a biblio record and select the option "Create an item record when receiving this serial" 2- Be sure to have at least one mandatory subfield that is filed with a select input in the framework used by the biblio record. (ex: 952$a, 952$b or 952$c). 3- From the subscription-detail page click on "Receive" 4- In the lower part--Supplemental issue--fill the suppelemant details, change the status to "Arrived" and fill the item form that appears. 5- Click on "Save" 6- Check that an error box appear with the message " Form not submitted because of the following problem(s) 1 mandatory fields empty (highlighted)" (the number can be different according to the number of concerned subfields) 7- Apply the patch 8- Repeat step 3 to 5 9- Check that no error appear and that your item has been created Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 4f6164d1940f4d666d2efb0e3e8d76bea3108125) Signed-off-by: Lucas Gass (cherry picked from commit e40a76bd78e34af1a73fba1417613ca25e44e59b) Signed-off-by: Arthur Suzuki --- koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt index 642dd2cc5e..a809af361f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt @@ -398,7 +398,7 @@ $(document).ready(function() { [% END %] [% IF ( iteminformatio.marc_value.type == 'select' ) %] - [% FOREACH value IN iteminformatio.marc_value.values %] [% IF ( value == iteminformatio.marc_value.default ) %] -- 2.39.5