From e8e87ca9b66273afc8896dfa5b1f918536db3b6a Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Tue, 22 Sep 2020 14:14:55 +0000 Subject: [PATCH] Bug 26507: [20.05.x] Elasticsearch - Index records after storing new item Currently Item->store indexes the record before the DB update - that is wrong To test: 1 - Find/create a bib with no items 2 - add an item with barcode "abc123" 3 - do a general keyword search for "abc123," see your bib is not in the results 4 - perform a search that includes your bib in the results, confirm it shows as having no items 5 - click through to bib details, confirm it shows your item here 6 - edit and save your item 7 - confirm barcode is now searchable 8 - apply patches 9 - Add a new item "cde456" 10 - Confirm it returns in searches 11 - Edit 'cde456' and change barcode to 'fgh789' 12 - Confirm the new abrcode is searchable Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Lucas Gass --- Koha/Item.pm | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/Koha/Item.pm b/Koha/Item.pm index 9560a567cb..d02817b1f2 100644 --- a/Koha/Item.pm +++ b/Koha/Item.pm @@ -110,9 +110,6 @@ sub store { $self->cn_sort($cn_sort); } - C4::Biblio::ModZebra( $self->biblionumber, "specialUpdate", "biblioserver" ) - unless $params->{skip_modzebra_update}; - logaction( "CATALOGUING", "ADD", $self->itemnumber, "item" ) if $log_action && C4::Context->preference("CataloguingLog"); @@ -168,9 +165,6 @@ sub store { $self->permanent_location( $self->location ); } - C4::Biblio::ModZebra( $self->biblionumber, "specialUpdate", "biblioserver" ) - unless $params->{skip_modzebra_update}; - $self->_after_item_action_hooks({ action => 'modify' }); logaction( "CATALOGUING", "MODIFY", $self->itemnumber, "item " . Dumper($self->unblessed) ) @@ -181,7 +175,11 @@ sub store { $self->dateaccessioned($today); } - return $self->SUPER::store; + my $result = $self->SUPER::store; + C4::Biblio::ModZebra( $self->biblionumber, "specialUpdate", "biblioserver" ) + unless $params->{skip_modzebra_update}; + + return $result; } =head3 delete -- 2.39.5