]> git.koha-community.org Git - koha.git/commit
Bug 21819: (QA follow-up) Replace onchange() in touched code
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tue, 20 Nov 2018 15:32:46 +0000 (16:32 +0100)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 19 Dec 2018 09:48:12 +0000 (10:48 +0100)
commit14a71ef32de9c1cd0a846048359db35e1df15f00
tree47b61b6076584d5c9b1ce74b8c5d49982df55876
parentea47f283988cb70d41829bba311c9d1f2088d8be
Bug 21819: (QA follow-up) Replace onchange() in touched code

AFAIK we should not call document...onchange() and assume that it works.
Apparently, it does at least in some browsers. But we are not sure.
We could easily replace them here by the documented jQuery counterpart.

Note: If you try git grep -l -E "onchange\(" you will find some
occurrences in two libraries and only in one js file (this one).
We should replace all occurrences here; will open a new report for that.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Verified that the change event was triggered: span should expand/collapse.

Signed-off-by: Andreas Roussos <arouss1980@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit aeaf74b7cc6608d7b81aaba10defdca6decdaa1d)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>
(cherry picked from commit 45b7f1703858a93d563934215326ff97e234abf6)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js