]> git.koha-community.org Git - koha.git/commit
Bug 19088: plugins-upload causes error log noise
authorLee Jamison <ldjamison@marywood.edu>
Fri, 11 Aug 2017 18:58:53 +0000 (18:58 +0000)
committerMason James <mtj@kohaaloha.com>
Tue, 24 Oct 2017 03:42:08 +0000 (16:42 +1300)
commit930d54f3cc9fdb9a05b2e0c707bda1dece00360a
tree5768f51e72b9cc3b5a40d1e1f19f90860f719105
parenteabbc7f9de5d2aeba4b1c44baeafb9e2ecd9603e
Bug 19088: plugins-upload causes error log noise

After uploading a plugin the error log indicates
use of uninitialized value in $op. This patch
silences the noise.

To test:
1) Set <enable_plugins> to 1 (one) in koha-conf.xml.
2) Set the UseKohaPlugins system preference to 'Enable'.
3) Navigate to Administration -> Manage plugins.
4) Install the test plugin KPZ file attached to this bug.
5) Notice the uninitialized value noise in the error log.
6) Uninstall the plugin (plack restart may be required if plack is
    enabled).
7) Apply patch.
8) Install the plugin again.
9) Notice no noise in the error log.
10) Run qa tools.
11) Run prove t/db_dependent/Plugins.t

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 1076a0edf32b621da54c53ea71595885f7e14c38)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit cdcc0458b796aff59a50e0f5d4c7b7140682eacf)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
plugins/plugins-upload.pl