]> git.koha-community.org Git - koha.git/commit
Bug 11686: make "please note your reason here..." translatable
authorOwen Leonard <oleonard@myacpl.org>
Wed, 5 Feb 2014 15:35:47 +0000 (10:35 -0500)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 4 Jun 2014 09:31:25 +0000 (11:31 +0200)
commita83c51fe93fd3c74e3f4b5fd4577248968d57148
treec565db395fbfc911c3630ebb71b244abfb26c8b2
parent19ba90d340260d7c241e5077df719802e79f0788
Bug 11686: make "please note your reason here..." translatable

Through some quirk of the translation script a predefined value on a
text input is not properly translated even though the string appears in
the po file. On the suggestions form the problem can be solved by using
the HTML5 placeholder attribute.

To test you must have existing suggestions to manage. Apply the patch
and:

- Update a translation by running tranlsate update [language code]
- Install/reinstall the translation by running translate install
  [language code]

- In the English templates:

  - Navigate to Acquisitions -> Suggestions and find the "Mark selected
    as:" section below the table of existing suggestions.
  - Select "Other" from the "choose a reason" field. A text input field
    should appear with the placeholder text "please note your reason
    here."

- In the templates you updated and installed, follow the same procedure
  above. The placeholder text should now appear with the correct
  translation.
- In both English and translated templates using this bulk-status option
  should save your chosen status correctly with the correct reason,
  whether that reason be predefined or manually entered.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and QA script.
Tested successfully with German - nice to see this fixed!

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 6c264b24d12bafb8d0bc6eecdc7e188a622d7389)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt