]> git.koha-community.org Git - koha.git/commit
Bug 11912: (refactoring followup) make GetMarcISBN implement its advertised API
authorTomas Cohen Arazi <tomascohen@gmail.com>
Mon, 10 Mar 2014 14:52:19 +0000 (11:52 -0300)
committerKyle M Hall <kyle@bywatersolutions.com>
Wed, 13 Aug 2014 18:25:20 +0000 (14:25 -0400)
commitdc196fd01bbe9e5aed68ccdde36295ced3da7791
treee652f65fc0271fc443d9705d0beaaaac52fdf873
parenteef3a2b36c31d3e3ed5cfb71fd40ccb6325cfda8
Bug 11912: (refactoring followup) make GetMarcISBN implement its advertised API

The current implementation of GetMarcISBN contradicts the documented API.
It currently returns an array of hashes with only one key (marcisbn)
which doesn't add any value to it.

I chose to fix GetMarcISBN to honour the API instead of changing thex
 docs, because it seems a really silly change.

To test:
- Run:
  prove t/db_dependent/Biblio.t
=> SUCCESS
- catalogue/detail.pl should correctly show ISBNs.
- opac/opac-detail.pl should correctly show ISBNs in both prog and bootstrap.
- opac-opac-sendshelf.pl should correctly show ISBNs in the email.

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 774483772b2a7ff8ebdb8a9aeac82881e7c858cf)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/Biblio.pm
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
koha-tmpl/opac-tmpl/prog/en/modules/opac-sendshelf.tt
t/db_dependent/Biblio.t