Brooke caught my april fools trick, its not 20004 yet!

Ok it wasn't an april fools trick, but just a typo, april fools trick
sounds better though right?

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0fa9ade9ffb48c10db40c0789fa5f5509ec63082)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 4866 follow-up - minor code formatting cleanup

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 20be558069cec2a620c60dce913709b6e3e4dc29)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 4866 for master (Enable Change event for item plugins)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit baee3e5c9bd93ac028e7142b0a52e3912ce5098e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 4913 - Budget pages should show currency name instead of symbol

This patch adds a new include file to handle the display of the active
currency name and a warning if no currency is active.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4b69538f9bf6809126cc404a7bc09b02c3830328)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 4912 - After editing private list redirect to private lists

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 38360b766c32ab89c6e5ee87d2459692b47f2b29)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5175, XSL view doesn't link publisher name to search

Fixes the doubled up display of the publisher.

This patch fixes the bug in both the OPAC and staff client

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c0272a6b66e053a86010c7eb8fce1bf080bf428b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5210, back button on batch modification result page useless

I can't see any good use for a back button here, so I'm taking it out.

An improvement might be to build in a method to resubmit the same batch
of barcodes/item numbers again so that you could make additional
changes to the same set.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit fa43573b5871f04c15f354def4954d6e70ba36b8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5381 - Fines in notices prints always 0.00

This was due to passing off the biblionumber to GetFines rather than the itemnumber.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c1463e72554639e2f913d335d6008b2fa912dbb9)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Additional fix for Bug 4423 - Staff Client XSLT is just a copy of the OPAC one

- Adding "Lists that include this title" links
 - Also correcting minor XHTML error in the same section of opac-detail.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0a2698237875b8481e14e6890388fe618081b4d1)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5400: new test case to find files with merge conflict markers

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4cef5ec9611cc2fbbd245472b60e1580f6f8b4b5)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 4498 - Acq always shows '1 suggestions waiting'

- Removing 'suggestions waiting' link from left-hand menu. A plain
  'suggestions' link is still shown if suggestions are enabled.
- Putting back the 'pending suggestions' box that used to appear
  on the Acquisitions home page. This will show, with a count
  of pending suggestions, only if suggestions are turned on and
  there are pending suggestions.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d9de6ebab3ecca5e967c658541c0ec62db0ae2e7)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Updating Version Number to 3.02.00.007

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5396: New system preference UseTablesortForCirc

This system preference allows the librarian to toggle on or off whether the JQuery tablesort is used on the
circ/circulation.pl page.  For patrons with many checkouts, this sort may cause very slow page loading (and
therefore slow circulation transaction time), depending on the browser and local machine used.  Staff can
still see a sortable list of current checkouts on the members/moremember.pl page.

My revision prevents the template from including *any* tablesorter code if the
preference is feature is turned off: both the circulation list and
the holds list will have no jQuery tablesorter.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d9db65a17e83f64c5858c6fd7ad8dc0d1e7660ab)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 4359: make other pages in the OPAC respect noItemTypeImages

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 7a945dbc284a9fc98fda06a49bbac0712bce4fea)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 4359 follow-up: noItemTypeImages should just control image display

Tweaked so that the item type column is always displayed in the
checkout history in the OPAC; noItemTypeImages now just controls
whether the icon displays.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 3357d811ee95c8de8beacd0fb93a979109051b44)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 4359, noItemTypeImages not active in OPAC

- Auth.pm put the noItemTypeImages preference under "intranet only."
  Moved it to "OPAC or intranet."
- Added check for the preference on the OPAC advanced search page.
- Improved logic for displaying images on the reading history page.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d4f02c469bdb9626f456aadf160c9ffc9ad23863)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 3271, Missing message when adding to a list with no items selected

There is no visible Lists button to "attach" our warning to
as there is in the OPAC, so warning message is displayed via
a javascript alert.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit fcb3668512341d70d3e222426ea6317130793744)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Partial fix for Bug 4924, Public/Internal notes missing in staff normal view

This fix adds only public notes. A div is added as a hook for styling

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit be547448368cad2b599e52eb71fc8c6ce39f77c1)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 4933, Link to subfield's edit tab from subfield structure admin

- Also corrects framework display in the case of the default

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 1586306866e84a47d29ba1cf2194d0ccb7cf04c5)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5392 Initialize vars used in building url strings

If no failures are to be added to the to the strings for redirect
the corresponding variables are undefined causing warnings
to be logged. Initialize them so that the error log is not
being filled with trivia.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit bd93bfdbc4087166369ac0e7dbc146cb199ecceb)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

BUG 5058: small layout correction of vendor form

Rebased to HEAD, should also apply to 3.2

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d39dd6d857af999430df0fbe571a5bffde7a287d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 4979: Acq: input fields for new record are too short

Patch rebased to HEAD, should also apply to 3.2

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit ed0ccd9f574b1f4895fa51dfe6850215be39d8db)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5393 [SIGNED-OFF]: add test case to check well-formedness of XML/XSLT files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 35d2008ef001f19c16f29a25626a7190c75218a8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 4305: Add test case for ISBN-13 to ISBN-10 conversion

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 51eb4fa12ec316fb8bf249ec0ae9c96a56f4639e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5389: mark Business::ISBN as a required dependency

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 11d54188f8302aea7cade2d4a9afdaa2f5eb0c7a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5075 - Terms not highlighted w/ xslt on

- XSLT didn't contain the class markup which acts as a hook
  for the JavaScript highlighting system.
- Standard results page also contained a typo which
  prevented data other than title and author from
  being highlighted

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit b558c0db5ad9125a947454b5ba8892f996553ab4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5254 - no need to scroll left to right on acq z search

- Adding inline preview/import menu to match cataloging z39.50 search
- Improving behavior of inline menu on both pages
- Adding white space to ISBN/ISSN output on both pages to allow
  line breaks, improving table width and horizontal scrolling.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit f987d35a2241a6178406a3d92ccbf9277087f2d1)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5235 : circ receipt should include name

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit ace0ce3f8da9e353f1e06eac0c26ead67b765eed)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5315: Remove references to obsolete variable nbstatements

Trying to see the wood from the trees

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit 9e5366734b744de2035f0668e7db94e399daacad)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5309: tweak so that background progress doesn't exit immediately

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit 48ab366b57a1ba59c1bf706308944b388666769d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

fix use of outdated boilerplate

* New code *must* have an accurate copyright statement;
  it isn't 2000-2002 any more.
* Enable warnings in new code, don't do

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit 0187e38ad7826172859467991d6766ca37e31d2c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5309: Adjust progres bar

Also added some test facilities
wr73785

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit e2e1dfd86e2f4a6ef63829551c58c728633fa893)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug5027: skip unticked checkboxes when submitting in the background.

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit 3a4f36b002a5651716efe68242f6711fad936448)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5385 - Fixing an error that crept in with the POD cleanup
(cherry picked from commit 9c6db56a3f807c819be5e724f423a212fa4b362c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 4305: add a couple test cases for _isbn_cleanup

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit bcedff69bcef3a887575c34f53e2c26153da61c1)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 4305 Improve code flow

Use the ISBN Object's method to format the string
rather than add extra code to do it
Clean up the code flow for clarity
Benchmarking shows its a bit faster too
Don't add to the number of Test::Perl::Critic warnings
 for no benefit

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c95b5153e0ed5585c8331273a42fc29d75f9f10f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5385: POD Cleanups (part 2)

More podchecker cleanups to eliminate warnings / errors

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit efa66f1f556dcff71779c9b89148f2bb99149e51)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5385: POD Cleanups (part 1)

working through the master branch to eliminate all
podchecker warnings/errors

Actual improvement to the quality of the POD will
come later (hopefully with assistance of others)

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9fa574f6097b8fc1eb9efc5321141ec0d23d3268)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5112: Organisation does not show links to professionals

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 63fdd8768acc42cf1b02a655506d6ea97c11fe14)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Merge remote branch 'kc/new/bug_5386' into kcmaster
(cherry picked from commit af1d8290317d7602616d7269fd40109ccf8a3f8d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Test modules compile

Script to test modules compile, when used with a pre-commit hook this
can test before a commit

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 7ecf2c2dc42d443d819ed04e3a11065f2802d51a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Merge remote branch 'kc/new/bug_5105' into kcmaster
(cherry picked from commit 235cf872a5c40a0baae554bdb28ec98c4520c528)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Merge remote branch 'kc/master' into new/bug_5105

Conflict fixed

Conflicts:
opac/opac-detail.pl
(cherry picked from commit dcb86689f73089ceaa789a92c34e78200d05af61)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix bug on opac-detail.pl with switch statement

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 5e1b8167c24e0322d94bfc919556d927d875cf97)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5003: Can not search for organisation by name

Rebased to current HEAD, small error fixed.
Should also apply to 3.2

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 863830f3f91110bdbd930755139f844870234ccc)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5380: remove copy-and-paste from authorities/detail.pl

MARC editor code not needed here.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 2c794d1af77879134ab0e84198d3827625384e70)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5372: identify empty field in authority record correctly

This is the sibling to the fix for this bug for the bib
editor.  However, note that this change won't have a
direct effect yet, as currently you can't specify a
default value for a field or subfield in the authority
MARC frameworks.  See bug 4887.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit daabd936d6cb13bd680652da5a32fd1ce354684a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Ukranian and Russian syspref language updates
(cherry picked from commit 1aef81c354eb17c2cf2d557cac78d4e37c30a046)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Russian and Ukranian opac language updates
(cherry picked from commit a3226d5ce618bfe5ced3723e8c87013b5ba7b26e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Staff interface .po file updates
(cherry picked from commit 6d22b87543272f6f0c1d02cfa42a031e0dc520ba)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5370: Fix all references to koha.org

Thx to Brooke for helping with the wiki.

This is the last patch.
We will have to change some more links, after translate.koha.org was moved.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d829dc1c6ab8fb20426c0cd377456d02fdac6598)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Merge branch 'trivial_bugs' of git://git.koha-community.org/wip/koha-fbc into kcmaster
(cherry picked from commit ce54fe0323a8ab523ae8992ff269bf82fea2dd10)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 4515 (Few very small errors in opac-search.pl) RESENT fixing whitespace warning

Loop on results should stop before $i==@servers.  Adding fix for warnings on undefined values in comparison for lines 485, 488 and 510.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit a3ceef434ed17a1a1ad57c70cfbbc8f1fdf5d736)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 4472 Apply it to MARC21

For French installation of Koha using MARC21, the same issues as UNIMARC
affects handling of &nbsp; by translation scripts.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c616cb5081b4e96a586fae1e5601d5d495c8794d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5214 - undefined itype images cause broken image icon in request.pl

Also fixes the same bug on the Itemtypes administration page.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit fbbab73492a5448884d3f258a0e9401a55021da6)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5236: remove hidemytags from CSS as well

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c49600aaa79844aff8a845e915cfd784484147e1)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5219: tidy cleanup_database.pl

Includes a bit of cleanup of the enhancement patch
for bug 5074 - adding comments about old and new
behavior isn't necessary for such small changes.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 072896d66be675f6ec32b46267fb57b649b4eb03)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5372 (v2) Existing value can be replace by default value

The way an existing value was tested was wrong. 0 is a valid value but a
false value for Perl.

=> replace privious proposal.

[3.2] Should also apply.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 07cfc5d69c83795a8ab1ad6168251f9aab9f87df)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5370: Fix all the references to koha.org

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 6df634855cc62a5f31b419ecd1946500bf576065)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5370: Fix all references to koha.org

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9f688ad92b04377bcb37b04448292e43509df80b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5370: Fix references to koha.org and other old websites

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 35cf30ef15943240e823b7cdfc0d233727a4011d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Adding 3.2 Release Maintainer to Release Team List

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 8dded0c2692e67473cad71384dd26971d27c6f22)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5368 Browse Shelf link appears when no itemcallnumber

Suppress Browse Shelf link on OPAC detail page when there is no item
call number.

[3.2] Should also apply on 3.2

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit e40b180d1de686d90caf7fd25d514b445280acdc)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

(MT 2985) simplify CanBookBeReserved

The function was too complex for so simple stuff, not we check if one of all items of the record can be issued.

[Note by Galen Charlton: not only does this patch simplify the routine,
 it also makes it behave correctly.]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 363c1ca9f9392403b98f3a3604c1345320f4a8c4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Updating Version Number to 3.02.00.006

bug 5149: follow-up - remove extraneous character in link

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b96617dea8fcd35d4f4f2f19860a2b7f14489e97)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5149 fix broken link to noItemTypeImages preference

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 36df1f6cdf231c72527d79bb08efeca01dd0e902)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5110 move NewItemsDefaultLocation to cataloging tab

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 140fde57def7d146a633769ffdbb405222044432)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 4963, sys prefs need date hints and/or picker

This patch adds the standard date format hint used elsewhere
in the interface.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 51405bcce471dd38b59425d1b3b6609e1d595572)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 4254 - adding new patron advanced notice doesn't save

This was due to poorly constructed SQL which returned duplicate values for
certain fields. This patch corrects that SQL.

NOTE: There is also a formatting problem with the message prefs display table
when it is displayed in moremember.pl. This is due to there being no logic to
tell the table in that context to display checkboxes as appropriate. This patch
does not fix that. Bug 5328 has been opened for this problem.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 321eed98334bac3564b0b11abf3fb6fe34074f0d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5082 - Not translatable name of default framework 'Default' in MARCdetail.tmpl

This patch also fixes an unreported bug where switching from any
other framework to 'Default' would bring up no MARC data.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b0e29e5595f5d92cbd9a66ab306652a01d6382ed)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 4980 - Acq: pull down 'Restrict access to:' for funds not translatable

Applied Owen's patch to current head, updated de-DE translation. The pull down values are now  translated.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit bd28366523c0778f496a310395f4481348e30ccf)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5142, Untranslatable strings in tag review template

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c4de64629d7f0853f3919cb5d09f98b2c0c60c03)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5056, Untranslatable strings in members.js

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 100099d429c3b092d9c3a9a7c65427499092d4b6)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5136, Replace SQL with call to GetAuthorisedValues

An embedded query in circulation.pl for BOR_NOTES authorized
values can be replaced with a call to GetAuthorisedValues

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 82d2cf464be0439b9d52de1d951baa856a4e60a4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5135 - Authorized value input maxlength should match table column

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 81b3ca97eab7235dbff94d30e09e6d4325f21604)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5171 change 'edit items' to read 'edit item' when next to 1 item

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 3d66c2153b8be4192da055782f23ad08f2f9845f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5168 change link text from holdings to items

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c3aa3d96819c32439ffa6f727367b679a1a24813)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix bug 3811; Index language as word

An incorrect definition in record.abs was resulting in searches on languages returning incorrect results.  By changing the indexing mode from numeric to word, this patch fixes that problem.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 68dc783c7e3b4f2721ef5efccc98934e8700f8d2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5311: correction to database update

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0d84902eca94fca399040e3c0088ee74f69cf68c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Update language mappings to fix Bug 5311

This patch updates the language_rfc4646_to_iso639 mapping table with the
correct mappings for several languages that were not mapped correctly to
the codes used in MARC, including Finnish (which was not mapped at all),
and Armenian (which was mapped to an obsolete code). This patch also
changes English and French to use the proper three-letter codes, which
will eliminate false positives when, for example, limiting by French
brings up results in Afrikaans.

This patch adds the changes to the updatedatabase.pl script, and removes
the incorrectly specified DBversion in the previous patch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

bug 5190: improve linking to MARC field documentation

* zero-pad tag numbers as needed
* handle special case for linking to UNIMARC 0XX vs. 1-8XX
* add a wrapper function
* add comment about the poor linkability of IFLA's UNIMARC documentation

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 141ec0b9bcfa0bcf34d82cbb7ddc722a078e216e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5190: link to MARC21/UNIMARC online doc in the bib editor

Patch from  Tomás Cohen Arazi <tomascohen@gmail.com>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 29432ee42cf25d79f28054eaea85f46edc688d1b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5326 fix link to old prefs editor on patron attributes

on the patron attributes page if you have ExtendedPatronAttributes
turned off the error points you to the old sys prefs editor - this
patch fixes that

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 45a6cca1a17093291dc6ab0883578b79bff0b6e7)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5326 fix extended patron attribute error

the error message if you have ExtendedPatronAttributes turned
off linked to the old sys prefs editor, link has been updated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 83f03fb9d3bbbf5101a7209f934e91b7876fc2dc)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5137, Remove obsolete code counting issues by item type in circ

The removed section of code contained a "my $dbh = C4::Context->dbh"
which was required for the query of BOR_NOTES. That line has been
moved accordingly.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b2bda465d770c078b14eef8493c0554143d90cc4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5008 - "Remove" link missing when Cart in expanded view

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0d41ba7300a228217ac32a1169bf24b0e79aff98)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 4986 move serials prefs from cataloging tab to serials tab

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d1593acec727c6aa06fc0d3159c62b454d225518)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5114 - Can't edit basket in Internet Explorer

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0bb33cd7ceee5cdb8bf2a5bcde552257f2279cfb)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5019 remove link to funds

This patch renames the link to budgets to say 'budgets & funds'
and removes the links to funds (which went no where).

This patch also adds the acq menu to the budget pages.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d5eb56dd528d29aace607f2994ff7fc2c132db57)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5177 Selecting default sort result by syspref

Syspref .pref file was defining a code for descending order which wasn't
expected by .tmpl files... 'desc' instead of 'dsc'.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit aa7df17f7c63ae51f8d2088b795af6d92b85e6a0)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5363 - Removing unused module (C4::Cache::FastMemcached)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Correcting Version Number for 3.2.x branch

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 4141: fix upgrade of OPAC XSLT parameters from 3.0.x

Note that OPACXSLTResultsDisplay and OPACXSLTDetailsDisplay
are boolean parameters in 3.2.x, not string parameters.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Updating version number and fixing the xxx in updatedatabase ... my bad

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5308: add foreign key constraints as well

Follows up on previous patch to require that routing
list entries be linked to subscriptions and patrons.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5308: subscriptionroutinglist more strict

borrowernumber and subscriptionid NOT NULL, UNIQUE(subscriptionid, borrowernumber)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 2567: let 008/15-17 and 008/24-27 be set

Fixes bug where the MARC21 008 plugin was falsely
claiming that it set the illustration and nature of
contents positions by deriving it from other fields
in the bib records.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5318: fix value of r4 rank weight

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 4991: follow-up tweaks

* make some strings translatable
* display library name instead of code in add/edit
  holiday panel
* minor textual fixes to hints

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>