]> git.koha-community.org Git - koha.git/commit
Bug 21560: create Koha::Util::OpenDocument with subroutine for ODS generation
authorFridolin Somers <fridolin.somers@biblibre.com>
Mon, 18 Feb 2019 16:33:37 +0000 (17:33 +0100)
committerLucas Gass <lucas@bywatersolutions.com>
Tue, 19 Mar 2019 23:12:48 +0000 (23:12 +0000)
commit3f68db17b9e2b5e6ece289a312f1a53f8d9a3d53
tree6138dc04cc6f8180f826e808e903b19e9fa81e50
parentef6d4aef4b34fa22a8850146615adf70411065ea
Bug 21560: create Koha::Util::OpenDocument with subroutine for ODS generation

There is nearly the same code in misc/cronjobs/gather_print_notices.pl and reports/guided_reports.pl.
This patch creates a new module with subroutine called by both scripts.

If file path or content is undefined, subroutine will just return undef.
If content is an empty arrayref, empty ods file is still generated.

Unicode encoding is kept outisde because it may not be necessary.

Note that for print notices the first line of message is always the column names so it is extracted only from first message.

Test plan :
Run previous patches test plans and check ODS files are the same.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit ffb40290f88380418635a951dbb0788bf7b7e3ce)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit c2531f6fef7f741f6557add3f8981148c55c15ce)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Koha/Util/OpenDocument.pm [new file with mode: 0644]
misc/cronjobs/gather_print_notices.pl
reports/guided_reports.pl