From c2b86366e342fef07f2e2b3212800888803f5378 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 9 Jul 2013 12:02:00 +0200 Subject: [PATCH] Bug 10557: remove unused branch parameter from GetBooksellersWithLateOrders C4::Booksellers::GetBooksellersWithLateOrders has an unused parameter. The $branch variable is never used in the routine. Test plan: Check that no behavior changes on the late orders page. Signed-off-by: Srdjan Signed-off-by: Katrin Fischer I couldn't find any use of the branch parameter apart from the one corrected by this patch. Also tested late orders, couldn't find any problems. Signed-off-by: Galen Charlton (cherry picked from commit 7f075448b8e00596ece780cca654471eebf949a3) Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 1ad01972ca995bc938ffe55fd43e7a69e03aca5c) Signed-off-by: Bernardo Gonzalez Kriegel (cherry picked from commit 1ad01972ca995bc938ffe55fd43e7a69e03aca5c) --- C4/Bookseller.pm | 4 ++-- acqui/lateorders.pl | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/C4/Bookseller.pm b/C4/Bookseller.pm index f708cd92fc..4f353097e7 100644 --- a/C4/Bookseller.pm +++ b/C4/Bookseller.pm @@ -98,14 +98,14 @@ sub GetBookSellerFromId { =head2 GetBooksellersWithLateOrders -%results = GetBooksellersWithLateOrders($delay); +%results = GetBooksellersWithLateOrders( $delay, $estimateddeliverydatefrom, $estimateddeliverydateto ); Searches for suppliers with late orders. =cut sub GetBooksellersWithLateOrders { - my ( $delay, $branch, $estimateddeliverydatefrom, $estimateddeliverydateto ) = @_; # FIXME: Branch argument unused. + my ( $delay, $estimateddeliverydatefrom, $estimateddeliverydateto ) = @_; my $dbh = C4::Context->dbh; # FIXME NOT quite sure that this operation is valid for DBMs different from Mysql, HOPING so diff --git a/acqui/lateorders.pl b/acqui/lateorders.pl index 544370d0b8..aa82df4a91 100755 --- a/acqui/lateorders.pl +++ b/acqui/lateorders.pl @@ -118,7 +118,7 @@ if ($op and $op eq "send_alert"){ } } -my @parameters = ( $delay, $branch ); +my @parameters = ( $delay ); push @parameters, $estimateddeliverydatefrom_dt ? $estimateddeliverydatefrom_dt->ymd() : undef; -- 2.39.5