From 618d8a690ee73327bd11ca30680be3f93132d74d Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Mon, 21 Oct 2019 14:32:25 -0300 Subject: [PATCH] Bug 23858: (follow-up) Return code fix MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Tomas Cohen Arazi Signed-off-by: Joonas Kylmälä Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize --- Koha/REST/V1/Acquisitions/Vendors.pm | 2 +- api/v1/swagger/paths/acquisitions_vendors.json | 2 +- t/db_dependent/api/v1/acquisitions_vendors.t | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Koha/REST/V1/Acquisitions/Vendors.pm b/Koha/REST/V1/Acquisitions/Vendors.pm index a051c2e7ee..986b1ab8f6 100644 --- a/Koha/REST/V1/Acquisitions/Vendors.pm +++ b/Koha/REST/V1/Acquisitions/Vendors.pm @@ -103,7 +103,7 @@ sub add_vendor { $vendor->store; $c->res->headers->location($c->req->url->to_string . '/' . $vendor->id ); return $c->render( - status => 200, + status => 201, openapi => $vendor->to_api ); } diff --git a/api/v1/swagger/paths/acquisitions_vendors.json b/api/v1/swagger/paths/acquisitions_vendors.json index 4c86a8de87..f8da32f16a 100644 --- a/api/v1/swagger/paths/acquisitions_vendors.json +++ b/api/v1/swagger/paths/acquisitions_vendors.json @@ -84,7 +84,7 @@ "application/json" ], "responses": { - "200": { + "201": { "description": "Vendor added", "schema": { "$ref": "../definitions.json#/vendor" diff --git a/t/db_dependent/api/v1/acquisitions_vendors.t b/t/db_dependent/api/v1/acquisitions_vendors.t index 61fd1289f4..5ae7367de3 100644 --- a/t/db_dependent/api/v1/acquisitions_vendors.t +++ b/t/db_dependent/api/v1/acquisitions_vendors.t @@ -222,7 +222,7 @@ subtest 'add() tests' => sub { $tx->req->cookies( { name => 'CGISESSID', value => $authorized_session_id } ); $tx->req->env( { REMOTE_ADDR => $remote_address } ); my $vendor_id = $t->request_ok($tx) - ->status_is(200) + ->status_is( 201, 'SWAGGER3 .2.1' ) ->header_like( Location => qr|^\/api\/v1\/acquisitions\/vendors/\d*|, 'SWAGGER3.4.1') ->json_is( '/name' => $vendor->{name} ) ->json_is( '/address1' => $vendor->{address1} )->tx->res->json('/id') -- 2.39.5