Bug 24840: [19.11.x] Replace DateTime->now with dt_from_string
authorNick Clemens <nick@bywatersolutions.com>
Thu, 26 Mar 2020 11:05:32 +0000 (11:05 +0000)
committerJoy Nelson <joy@bywatersolutions.com>
Thu, 7 May 2020 17:17:12 +0000 (17:17 +0000)
commit017d03b7414dd794046a883745e4e696ba4c8076
tree4ce1c0d7b5a09c4c0eeb1a4c2b5019fff62589db
parent88526da244ce7ce3ec69bd5c167e016f021b3f08
Bug 24840: [19.11.x] Replace DateTime->now with dt_from_string

We should use Koha::DateUtils instead of Date::Time directly

This patch simplay replaces calls to now() with a call to dt_from_string()
which does effectively the same thing.

Probably reading the code and verifying changes is sufficient but...

To test:
1 - confirm the files all compile
2 - confirm all tests pass
3 - confirm Koha still works

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Bug 24840: Catch some further cases of DateTime->now

This patch corrects a few additional cases where DateTime->now is called
directly instead of via Koha::DateUtils.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
28 files changed:
C4/Circulation.pm
C4/Letters.pm
C4/MarcModificationTemplates.pm
Koha/Calendar.pm
Koha/Checkout.pm
Koha/Checkouts.pm
Koha/EDI.pm
Koha/Edifact/Order.pm
Koha/Edifact/Transport.pm
Koha/Illrequest.pm
Koha/Patron/Password/Recovery.pm
Koha/Sitemapper/Writer.pm
Koha/StockRotationItem.pm
circ/overdue.pl
circ/returns.pl
installer/data/mysql/fix_unclosed_nonaccruing_fines_bug17135.pl
installer/data/mysql/updatedatabase.pl
members/summary-print.pl
misc/cronjobs/fines.pl
misc/cronjobs/overdue_notices.pl
misc/cronjobs/update_totalissues.pl
opac/opac-ics.pl
t/Circulation/AgeRestrictionMarkers.t
t/db_dependent/DecreaseLoanHighHolds.t
t/db_dependent/Letters/TemplateToolkit.t
t/db_dependent/OAI/Server.t
t/db_dependent/Passwordrecovery.t
t/db_dependent/Sitemapper.t