Bug 28217: Prevent several non-repeatable attributes to be merged
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 23 Apr 2021 13:37:46 +0000 (15:37 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Tue, 11 May 2021 10:11:16 +0000 (12:11 +0200)
commit0216a66aca3eb2a9a47a4c5b4a6ea0c2cb98c322
treeef6c9d2b02f96cf81129c4d1cffc5787f2bb14f9
parent3435d22040709509e4e88532881416b0acf13f76
Bug 28217: Prevent several non-repeatable attributes to be merged

When using the patron merge feature it's possible to generate a patron
with several non-repeatable attributes.

This patch prevents that.

Test plan:
Create 2 patron attribute types, one repeatable and one non-repeatable
Create 2 patrons and add them repeatable attributes
Add a non-repeatable attribute to one of them
Merge the 2 patrons
=> It succeeds, the resulting patron has all the repeatable attribute
and the non-repeatable one.

Do it again but this time add non-repeatable to both patrons
Merge them
=> It fails, you should see an error on the UI
  Merge failed! The following error was reported: Tried to add more than one non-repeatable attributes. type=TYPE value=VALUE.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 92db5e22474bec148cf4346300bc246bedbc6a7c)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/Patron.pm
t/db_dependent/Koha/Patrons.t