Bug 25622: Use special chars in DB password (koha-create)
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 29 May 2020 14:10:58 +0000 (16:10 +0200)
committerLucas Gass <lucas@bywatersolutions.com>
Tue, 9 Aug 2022 22:05:25 +0000 (22:05 +0000)
commit026c7588d93719217cea68a309f481f9c6604c30
treed615c17cfb2ff1275b73b465c28691650354c7dd
parentd6a3a10fc7cd7e15ffcdd03e089d565764f5e1b3
Bug 25622: Use special chars in DB password (koha-create)

On bug 23250 we decided to generate a password without special chars
then add a '@' at the end to comply with MySQL policy.
That is wrong, we should handle correctly the special chars we don't
want to be part of the password.

Test plan:
1.
mysqlpwd=$(pwgen -s -y -r ":'&\\<>/" 16 1)
echo $mysqlpwd

Confirm that you don't see one of the following chars : ' & \ < > /

2.
Copy from src and edit /usr/sbin/koha-create to add an echo $mysqlpwd
Create several instances, like:
koha-create --create-db x
koha-create --create-db xx
koha-create --create-db xxx
...

When you see a password with a special chars, do:
koha-shell xxx
grep '<pass>' $KOHA_CONF
And make sure the password does not contain "__DB_PASS__"

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit ffd3b4b7e391d40c476772bd16530572431d2896)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
debian/scripts/koha-create