Bug 16009: fix GetMember() search on NULL/undef values
authorGalen Charlton <gmcharlt@gmail.com>
Wed, 9 Mar 2016 01:41:33 +0000 (01:41 +0000)
committerBrendan A Gallagher <brendan@bywatersolutions.com>
Fri, 11 Mar 2016 15:23:37 +0000 (15:23 +0000)
commit0391709c285235b7d928a3eaeebb8a981524b329
treed0ba080d111ba555b040824150959cceb179fa0b
parent4e9143e214b31dfb52c784029ad98c40af7584b4
 Bug 16009: fix GetMember() search on NULL/undef values

This patch fixes a bug whereby GetMember(searchfield => undef)
(i.e., searching for patron records where 'searchfield' is NULL)
would crash.

This fixes a regression introduced by bug 15344 that in turn
exposed a long-standing bug in GetMember().

To test:

[1] Import some offline circulation transactions that include at
    least one return.
[2] Attempt to view the list of pending transactions; a crash
    will occur.
[3] Apply the patch and view the list of pending transactions again;
    this time, it should work.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
C4/Members.pm
t/db_dependent/Members.t