Bug 29540: Raise flagsrequired in modrequest
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 22 Nov 2021 07:55:47 +0000 (07:55 +0000)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 14 Jan 2022 19:29:11 +0000 (14:29 -0500)
commit15285ae209f5a98ab2e77c730b0b70ff0b29c283
tree4f88983ba056303013dc08d09c44e6a2b6652cbb
parent6d022889a2fac79c9148dd5f20c36f926d66065c
Bug 29540: Raise flagsrequired in modrequest

Test plan:
Try modrequest with a user having only 'catalogue' perms and the following URLs:
[1] /cgi-bin/koha/reserve/modrequest.pl?reserve_id=XX&CancelBorrowerNumber=XX&CancelItemnumber=XX&biblionumber=XX
    Fill the XXs with correct identifiers for some item level hold.
[2] /cgi-bin/koha/reserve/modrequest_suspendall.pl?suspend=1&suspend_until=2021-12-01&borrowernumber=XX
    Fill the XX with borrowernumber for borrower that has pending holds.
You should see: Error: You do not have permission to access this page.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[AMENDED] More consensus for using reserveforothers than circulate_remaining.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
reserve/modrequest.pl
reserve/modrequest_suspendall.pl