Bug 24370: (QA follow-up) Make new suggestions default to the library you re viewing
authorNick Clemens <nick@bywatersolutions.com>
Tue, 20 Oct 2020 18:19:46 +0000 (18:19 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 2 Nov 2021 13:57:04 +0000 (14:57 +0100)
commit153ff795abd75e8117b7dc2001f8c6d552ab5eae
tree8116219a44a0b96384f5e1dc298aa1cae7331880
parent02adde9a43972c042f61c9ff17fe4684f0d9965d
Bug 24370: (QA follow-up) Make new suggestions default to the library you re viewing

It looks like this problem was caused by code from bug 25033, we were attempting to have the
dropdown either be the current branch filter, or the suggestion's branch code, but the variables here are confusing and it didn't work

This explicitly sets the branchcode when creating a new suggestion to allow fixing current behaviour and
show the correct value when creating new

To test:
1 - Be signed in as branch A
2 - Browse to suggestions and limit to branch "Any"
3 - Click 'New suggestion"
4 - Defaults to Any
5 - Cancel and limit to branch B
6 - New suggestion defaults to branch B

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt