Bug 33482: Propagate errors from EBSCO's ws to the UI
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 11 Apr 2023 11:46:51 +0000 (13:46 +0200)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 11 May 2023 11:12:23 +0000 (12:12 +0100)
commit1abdbf944aab9f1a1c289273a6d403dd779ec3ca
tree04189feadcd0bf74d2d8ced5eadef4e8cee8dd52
parent6104db1e6f0fcea066b89d86892ced1453377ef4
Bug 33482: Propagate errors from EBSCO's ws to the UI

When adding or removing eholdings from EBSCO, if an error happens it is
lost and not propagated to the UI.

We were missing a return in the logic, and always returning 200

Test plan:
Do not apply (or revert) bug 33481
Configure EBSCO for ERM and add a package to your holdings
With this patch applied you will get a 500 that is propagated to the UI
Without this patch nothing happens and the user is not aware that
something bad happened

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit af34d97928215c10b97c7c86d72da2b9ebde085f)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Koha/REST/V1/ERM/EHoldings/Packages/EBSCO.pm