Bug 29115: Fix syntax errors in club hold functionality
authorJoonas Kylmälä <joonas.kylmala@iki.fi>
Sun, 26 Sep 2021 15:36:45 +0000 (15:36 +0000)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Fri, 17 Dec 2021 20:13:26 +0000 (20:13 +0000)
commit1bd7d3f2e67a0f349cf9541ae40bf4d725ff5bb3
treecc96147852895c48fa0e80962970d6022db8559e
parent4a1ff2a4141efe21eb92f053bf756c12965be5f0
Bug 29115: Fix syntax errors in club hold functionality

The code didn't previously correctly do the checks for patron
debarment status and whether the patron has fees, this caused the
intended warnings messages to not appear when they should have.

To test:
 1) Create a new club and add a patron to it who has manual debarment
    and a manual charge of over $5 (more than the maxoutstanding syspref).
 2) Try to create a new club hold for the previously created club and
    notice no warnings are listed for the patron.
 3) Apply patch
 4) Try to create now the club hold again and notice the warnings
    being shown in the hold page.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit d8c5c195c9d6a489c7e63a618b078275ede8c62c)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
reserve/request.pl