Bug 29352: Runtime parameter labels should not be said to be optional
authorOwen <oleonard@myacpl.org>
Thu, 28 Oct 2021 14:46:00 +0000 (14:46 +0000)
committerKyle Hall <kyle@bywatersolutions.com>
Fri, 5 Nov 2021 14:52:30 +0000 (10:52 -0400)
commit1be99b933eaec27425706342e02d2a5c32d7c55a
tree6c058ef0762404190d2218546a2a7537bdff7d60
parent57403b87cdb1b68b30afe784e5c1e52cd12ec27d
Bug 29352: Runtime parameter labels should not be said to be optional

This patch alters the form shown when using the "Insert runtime
parameter" button in SQL reports. It makes the label field required and
removes "optional" from the field hint.

To test, apply the patch and go to Reports -> Create from SQL.

 - Click the "Insert runtime parameter" button and select "Authorized
   value."
 - Clear the "parameter label" field and click "Insert parameter."
 - The form should display an error asking you to fill in the label
   field.
 - Test that the category field is also required.
 - Close the modal and select a different runtime parameter.
 - Test again that the label field is required.
 - Test that the form submits correctly when the label field is
   populated.

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt