Bug 29957: Adjust push @$cookie statements in Auth
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 16 Mar 2022 12:43:07 +0000 (12:43 +0000)
committerKyle Hall <kyle@bywatersolutions.com>
Fri, 15 Apr 2022 11:15:20 +0000 (07:15 -0400)
commit2e6d87e84024db268c183b4d53ebf8c52fc39dbd
treec230ef46cec855f9fde0f7dd3ce9d8ffc4947c46
parentca971152de9ca35a6d7c6e781062c222a55a12b3
Bug 29957: Adjust push @$cookie statements in Auth

We can now use $cookie_mgr->replace_in_list instead. This
effectively removes duplicates and keeps the newest cookie.

Note: In the test plan below we are just verifying if
this patch did not change behavior. The replace_in_list
routine has been tested already in a unit test.

Test plan:
Run t/db_dependent/Auth.t
Login at OPAC.
Hit some opac and staff pages.
Perform an Advanced search on OPAC.
Check cookies in browser.
Logout.
Check cookies again. Verify with your do_not_remove_cookie lines
in koha-conf.xml.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Auth.pm