Bug 27064: (QA follow-up) Add error message only if we have one defined
authorJoonas Kylmälä <joonas.kylmala@helsinki.fi>
Mon, 7 Jun 2021 14:07:04 +0000 (17:07 +0300)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 18 Jun 2021 11:11:56 +0000 (07:11 -0400)
commit30fac5c75a2f901f6b93266bf8836489c1fcbc84
treea794951aa4073184abefd78c944a7fe10a64b437
parent6c1b7df3f62b9b9e07f0a65d3ca99817086b4c01
Bug 27064: (QA follow-up) Add error message only if we have one defined

This moves the DestinationEqualsHolding error message addition to if
clause so the value is added to %err hash only when there is actually
an error. Then we only append to the @errmsgloop array the error
message if one was defined.

To test:
 1) Create a hold request to a pickup library where the item currently
 is not
 2) Add transfer to the pickup library using branchtransfers.pl and
 notice without this patch we get and empty message box but with this
 patch we don't get it.

Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
circ/branchtransfers.pl