Bug 27071: (follow-up) Get rid of loop
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 22 Feb 2021 12:27:12 +0000 (09:27 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Tue, 2 Mar 2021 07:01:05 +0000 (08:01 +0100)
commit3525fc03c6d6bb7dbb3e0d49ac8e68444839e82b
tree5d5e1db19a6b268f256ef490b940d64976801c92
parent17bcc1aeea0ad2a60f24a68fa4ba31bf64c15c59
Bug 27071: (follow-up) Get rid of loop

This patch gets rid of a loop on the librarary's groups siblings, and
acknowledges ->get_hold_libraries returns a proper Koha::Libraries
iterator that can be chained with a new query on the passed branchcode.
This way we only fetch  a count from the DB and no loop needs to take
place on the code.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Libraries.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 3495a7e9af70706e3ebba60e3fac7aa3845d1d78)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/Library.pm