Bug 27669: Fix 'importing' and 'reverting' statuses when importing/reverting a batch
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 10 Feb 2021 10:30:45 +0000 (11:30 +0100)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 19 Feb 2021 15:08:19 +0000 (16:08 +0100)
commit465f33b09b1193b7bb8fab3a8b5076c0943f7d20
treee0b86e11ab36d60e7bef3108bfb2c1adffc82eca
parent8f342517462de1a9718000dcb8cc2e10d9b16abf
Bug 27669: Fix 'importing' and 'reverting' statuses when importing/reverting a batch

SetImportBatchStatus is not called with $batch_id

It has been caught by bug 25026, and www/search_utf8.t fails with
t/db_dependent/www/search_utf8.t .. 14/87 Error POSTing http://koha:8081/cgi-bin/koha/tools/manage-marc-import.pl: Internal Server Error at t/db_dependent/www/search_utf8.t line 240.

And, from logs:

manage-marc-import.pl: C4::ImportBatch::SetImportBatchStatus(): DBI Exception: DBD::mysql::st execute failed: Truncated incorrect DOUBLE value: 'importing' [for Statement "UPDATE import_batches SET import_status = ? WHERE import_batch_id = ?" with ParamValues: 0=undef, 1='importing'] at /kohadevbox/koh
a/C4/ImportBatch.pm line 579: /kohadevbox/koha/tools/manage-marc-import.pl, referer: http://koha:8081/cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=2

Test plan:
Read the changes and confirm it does make sense.
Import and revert a batch

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit a86242c2ea6ecdc2e9cf26dd7343c09926f68287)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/ImportBatch.pm