Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off
authorOwen Leonard <oleonard@myacpl.org>
Wed, 23 Apr 2014 16:59:25 +0000 (12:59 -0400)
committerJulian Maurice <julian.maurice@biblibre.com>
Thu, 4 Feb 2016 21:22:29 +0000 (22:22 +0100)
commit59229f74805c9bdc817b0c5f65b311f9825ce3b3
treedf672846507409eb9643207a575ed05ff570506c
parentf861cf879b5a4e65482ba607e80a0b4a8373fc7e
Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off

If the user knows the URL for OPAC lists they can access them even with
the virtualshelves preference turned off. This patch copies the solution
added to opac-topissues.pl by Bug 10595 and applies it to OPAC lists
pages.

To test, apply the patch and set the virtualshelves system preference to
"don't allow."

- Navigate to /cgi-bin/koha/opac-shelves.pl. You should be redirected to
  an Error 404 page.
- Also check:
  - /cgi-bin/koha/opac-shareshelf.pl.
  - /cgi-bin/koha/opac-downloadshelf.pl
  - /cgi-bin/koha/opac-sendshelf.pl
  - /cgi-bin/koha/opac-addbybiblionumber.pl
- Turn virtualshelves back on. Access to lists and list sharing should
  be restored.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit 2923cfdff4466efed55dd3d3dbee8ba37f6ff882)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
opac/opac-addbybiblionumber.pl
opac/opac-downloadshelf.pl
opac/opac-sendshelf.pl
opac/opac-shareshelf.pl
opac/opac-shelves.pl