Bug 30694: Set decreaseloanholds undef when deleting circulation rule
authorEmmi Takkinen <emmi.takkinen@koha-suomi.fi>
Tue, 15 Nov 2022 07:31:13 +0000 (09:31 +0200)
committerJacob O'Mara <jacob.omara@ptfs-europe.com>
Fri, 13 Jan 2023 11:25:50 +0000 (11:25 +0000)
commit63fd9be98befc0be358b0074b94253befa929f48
tree1623d0504fb6256a75b158de072bf41d1e17a88d
parenta9d0b1144f7c60741cfeeb5eb571c67e0695a870
Bug 30694: Set decreaseloanholds undef when deleting circulation rule

When one tries to delete rule with field "Decreased loan period
for high holds" filled, delete fails without errors. This happens
because rule isn't set in code section handling the delete in
smart-rules.pl.

To test:
1. Create a new circulation rule and fill all fields.
2. Try to delete the rule.
=> Rule isn't deleted, all fields except "Decreased loan period
for high holds" are now empty or have value "Unlimited".
3. Modify the rule and set field "Decreased loan period for high
holds" empty.
4. Delete the rule.
=> Rule is deleted successfully.
5. Create a new rule, fill all fields expect field "Decreased loan
period for high holds".
6. Delete the rule.
=> Rule is deleted successfully.
7. Apply this patch.
8. Again create a new rule with field "Decreased loan period for high holds" filled.
9. Try to delete the rule.
=> Rule is deleted successfully.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 91fc31c32ba14817d989bcd34854ebc8e41fa936)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
admin/smart-rules.pl