Bug 27437: Improve hint labels on library creation form
authorOwen Leonard <oleonard@myacpl.org>
Thu, 14 Jan 2021 16:56:00 +0000 (16:56 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 20 Jan 2021 12:42:08 +0000 (13:42 +0100)
commit726cfda78b24df8a87cf060455430c91cb41a930
treef507488da0c39ff4a0d5c879282a32f90f73572c
parent4349cc182e56c070b69bb89f81df75a0b6b78c85
Bug 27437: Improve hint labels on library creation form

This patch makes a few minor template changes to the form for creating
and editing libraries:

- <br /><span class="hint"> changed to <div class="hint">
- References to system preferences are linked directly to that
  preference if the user has permission.
- The MARC organization code label has been corrected so that it works
  now.

To test, apply the patch and go to Administration -> Libraries -> New
library.

- Confirm that the hints for Ill staff email, Reply-to, Return-path, and
  MARC organization code look correct, including aligning with the input
  field above them.
- Confirm that clicking the "MARC organization code" label moves focus
  to the correct field.
- View the page as a user who both does and does not have permission to
  access system preferences, confirming that system preferences are
  linked correctly if the user has the correct permission.

Signed-off-by: Mazen Khallaf <mazen.i.khallaf@gamil.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
JD Amended patch: Add missing space to correctly align input with label

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt