Bug 13355: System preferences tab value wrong in templates
authorTomas Cohen Arazi <tomascohen@gmail.com>
Thu, 27 Nov 2014 12:13:14 +0000 (09:13 -0300)
committerChris Cormack <chrisc@catalyst.net.nz>
Thu, 18 Dec 2014 01:11:20 +0000 (14:11 +1300)
commit75bb2aa63e5ad392e8846a281f695c50fb5464d2
treebb9cf727de6848d1dd6090157c2a717d1c135778
parent20cf49b9ac2279ceccc8f59492759befd699813d
Bug 13355: System preferences tab value wrong in templates

This patch fixes a bug on the system preferences tab templates.

To test:
To reproduce:
(1)
- Choose a tab on the sysprefs section (for example 'Enhanced Content')
- Right click on 'Enhanced Content preferences' title, and choose to 'inspect' the code
=> FAIL: you will see below the form tag something like:
<input type="hidden" name="op" value="save">
<input type="hidden" name="tab" value="">

(2)
- Do a syspref search (for example 'facet').
- Right click on one of the category titles (for example 'OPAC preferences')
=> FAIL: you will see below the form tag something like:
<input type="hidden" name="op" value="save">
<input type="hidden" name="tab" value="HASH(0x6e53050)">

- Apply the patch
- Repeat (1) and (2)
=> SUCCESS: you will see below the form tag something like:

<input type="hidden" name="tab" value="enhanced_content">
and
<input type="hidden" name="tab" value="opac">

respectively.
- Sign off :-D

Regards

Signed-off-by: wajasu <matted@34813.mypacks.net>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 84fbded3645a85c507afaab4dff42396a3974e47)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
admin/preferences.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt