Bug 13614: Replace usage of YUI on basket groups page
authorOwen Leonard <oleonard@myacpl.org>
Thu, 26 May 2022 16:44:35 +0000 (16:44 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Tue, 7 Jun 2022 12:32:17 +0000 (09:32 -0300)
commit8262613b25b481f2eaa68ca8c434145a902c5df5
tree25d4c78d22362a62f3ceac774ad2a92e2ff5d490
parent3a1807e56d29f1a13d9ba11aec7950f955fa7ebe
Bug 13614: Replace usage of YUI on basket groups page

This patch updates the basket groups interface so that it doesn't rely
on YUI to move baskets in and out of groups. The patch also removes
all YUI assets and many long-obsolete references to YUI-related classes
and IDs.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- Go to Acquisitions.
- Locate a vendor with multiple closed baskets.
- Click "Basket groups" in the sidebar menu.
- Create or edit a basket group.
- On the basket group page you should see the basket group form in one
  column and ungrouped baskets in another.
- Both grouped and ungrouped baskets should be in a sortable
  DataTable.
- Test that when you click the "Add to group" button on an ungrouped
  basket the row is removed from the table of ungrouped baskets and
  added to the table of grouped baskets.
  - The button text on the row should now read "Remove."
- Test the reverse operation: Clicking "Remove" on a grouped basket
  should move it to the table of ungrouped baskets.
- Test that when all baskets are moved out of either of the tables a row
  is displayed with a message specific to that table, e.g. "There are no
  ungrouped baskets."
- Test that the basket group saves correctly when zero or more baskets
  are added to the group.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
92 files changed:
koha-tmpl/intranet-tmpl/lib/yui/animation/animation-debug.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/animation/animation-min.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/animation/animation.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/button/assets/button-core.css [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/button/assets/skins/sam/button-skin.css [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/button/assets/skins/sam/button.css [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/button/assets/skins/sam/menu-button-arrow-disabled.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/button/assets/skins/sam/menu-button-arrow.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/button/assets/skins/sam/split-button-arrow-active.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/button/assets/skins/sam/split-button-arrow-disabled.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/button/assets/skins/sam/split-button-arrow-focus.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/button/assets/skins/sam/split-button-arrow-hover.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/button/assets/skins/sam/split-button-arrow.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/button/button-beta-min.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/button/button-debug.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/button/button-min.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/button/button.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/container/assets/alrt16_1.gif [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/container/assets/blck16_1.gif [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/container/assets/close12_1.gif [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/container/assets/container-core.css [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/container/assets/container.css [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/container/assets/hlp16_1.gif [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/container/assets/info16_1.gif [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/container/assets/skins/sam/container-skin.css [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/container/assets/skins/sam/container.css [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/container/assets/tip16_1.gif [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/container/assets/warn16_1.gif [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/container/container-debug.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/container/container-min.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/container/container.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/container/container_core-debug.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/container/container_core-min.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/container/container_core.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/dragdrop/dragdrop-debug.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/dragdrop/dragdrop-min.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/dragdrop/dragdrop.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/element/element-beta-min.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/element/element-debug.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/element/element-min.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/element/element.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/json/json-debug.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/json/json-min.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/json/json.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu-button-arrow-disabled.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu-button-arrow.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/menu-core.css [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/menu.css [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/menu_down_arrow.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/menu_down_arrow_disabled.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/menu_up_arrow.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/menu_up_arrow_disabled.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/menubaritem_submenuindicator.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/menubaritem_submenuindicator_disabled.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/menubaritem_submenuindicator_selected.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/menuitem_checkbox.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/menuitem_checkbox_disabled.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/menuitem_checkbox_selected.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/menuitem_submenuindicator.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/menuitem_submenuindicator_disabled.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/menuitem_submenuindicator_selected.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/skins/sam/menu-skin.css [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/skins/sam/menu.css [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/skins/sam/menubaritem_submenuindicator.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/skins/sam/menubaritem_submenuindicator_disabled.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/skins/sam/menuitem_checkbox.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/skins/sam/menuitem_checkbox_disabled.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/skins/sam/menuitem_submenuindicator.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/assets/skins/sam/menuitem_submenuindicator_disabled.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/menu-debug.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/menu-min.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/menu/menu.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/plugins/bubbling-min.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/plugins/loading-min.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/split-button-arrow-active.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/split-button-arrow-disabled.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/split-button-arrow-focus.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/split-button-arrow-hover.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/split-button-arrow.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/sprite.png [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/utilities/utilities.js [deleted file]
koha-tmpl/intranet-tmpl/lib/yui/yahoo-dom-event/yahoo-dom-event.js [deleted file]
koha-tmpl/intranet-tmpl/prog/css/preferences.css
koha-tmpl/intranet-tmpl/prog/css/print.css
koha-tmpl/intranet-tmpl/prog/css/printreceiptinvoice.css
koha-tmpl/intranet-tmpl/prog/css/right-to-left.css
koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline-mf.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/search.tt
koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt