Bug 28299: Take OpacHiddenItems into account on opac-shelves
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 7 May 2021 09:16:17 +0000 (11:16 +0200)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 9 Jul 2021 17:48:57 +0000 (13:48 -0400)
commit82cf4b82c2e1842cec4b0c5beb055179a31cb512
tree05296b1127ba8154e41544f78117f365adcb1fb1
parenta47e87915bf1defc4283d903dba32510ff83d094
Bug 28299: Take OpacHiddenItems into account on opac-shelves

hidden_items was not passed to XSLTParse4Display

2 things:
* Should we hide the biblio record if OpacHiddenItemsHidesRecord is set?
* allow_onshelf_holds is not working like in other scripts, what's the
expected behaviour? If hidden should we completely ignore the item?

Test plan:
1. Without the patch
2. fill OpacHiddenItems with «damaged: [1]»
3. find a record with several item
4. mark one of them as damaged
5. OPAC: go to the record, you shouldn't see the damaged item
6. add the record to a list
7. see the list
8. in Availability you see the damaged item mentioned, this is the issue
9. apply the patches and restart the services
10. the list should not mention the damaged item :D

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
opac/opac-shelves.pl