Bug 27209: (follow-up) Add ->is_pickup_location_valid
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 14 Dec 2020 10:37:53 +0000 (07:37 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 21 Dec 2020 09:07:45 +0000 (10:07 +0100)
commit865a1dab5c346920c61237c4b7593202328e04f8
tree99eb529a7e8be75cdd1744e2ced79d1005fb8e55
parent672413ea294679d4b5b30d30839650f6d30b45ca
Bug 27209: (follow-up) Add ->is_pickup_location_valid

This patch simply refactors the pickup location check into a method that
can be called on its own. Tests are added, and the tests for
->set_pickup_location should pass unmodified.

To test:
1. Apply the first two patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Hold.t
=> SUCCESS: tests pass
3. Apply this refactoring patch
4. Notice the tests are similar, but check for boolean output
5. Repeat 2
=> SUCCESS: New tests pass, set_pickup_location() behavior unchanged.
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/Hold.pm
t/db_dependent/Koha/Hold.t