Bug 12980: GetHistory does useless processing
authorJonathan Druart <jonathan.druart@biblibre.com>
Tue, 23 Sep 2014 11:02:51 +0000 (13:02 +0200)
committerChris Cormack <chrisc@catalyst.net.nz>
Wed, 3 Dec 2014 20:02:49 +0000 (09:02 +1300)
commita38e5644d74f2ba10099d07ff993325c1f28ff75
tree0cbd6841b425e2f190d5a5736d7edbab5c5a5b7d
parent8e15980809a0e7e8e14d59d1c0c9e2c6054c1a55
Bug 12980: GetHistory does useless processing

GetHistory iterated on the orders to calculate the quantity and price.
These values are never used by the called.
It can be removed.

Test plan:
Verify there is no regression on acqui/histsearch.pl and
catalogue/detail.pl
Actually you just have to check that the total quantity and price are
not displayed on these views.

QA: note that 'count' and 'toggle' are never used in the template.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 46e3f8169c026ed9037f38669c5742e912326339)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
C4/Acquisition.pm
acqui/histsearch.pl
catalogue/detail.pl
t/db_dependent/Acquisition.t