Bug 21248: Fix COinS carp in MARC details page on unknown record
authorPasi Kallinen <pasi.kallinen@joensuu.fi>
Mon, 20 Aug 2018 04:30:45 +0000 (07:30 +0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Mon, 24 Sep 2018 09:41:37 +0000 (11:41 +0200)
commitae819fce4cfc12e2e04f1b449c47466d5b3cefab
treeced2a428b301f0de2943b40c07fab5f0e2b0ed86
parent73926ff81d8823f3dace210593feaa995e22d919
Bug 21248: Fix COinS carp in MARC details page on unknown record

Looking up a nonexistent record in the MARC details -page causes
the COinS to carp. The fix is trivial, just move the COinS call
couple lines, after the record existence check.

TEST PLAN
---------
1) reset_all for kohadevbox
2) log in to staff client - admin/admin
3) search catalogue for green
4) tweak the top URL to have a bad biblionumber (eg. 9999)
5) cat /var/log/koha/kohadev/plack-err.log
   -- floody! with errors.
6) echo | sudo tee /var/log/koha/kohadev/plack-err.log
7) restart_all
8) repeat steps 2 through 5.
   -- just nice starting messages, not floody.
9) run koha qa test tools

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 030047da428521c248868e3ee5d655afd3bed05b)

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 7fe692bf0ec4dd6744c81c068c400927ccc0c54d)

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
catalogue/MARCdetail.pl