]> git.koha-community.org Git - koha.git/commit
Bug 10976: Fix typo itemtype vs itemtypes
authorJonathan Druart <jonathan.druart@biblibre.com>
Wed, 22 Apr 2015 11:22:58 +0000 (13:22 +0200)
committerChris Cormack <chris@bigballofwax.co.nz>
Sun, 17 May 2015 06:36:27 +0000 (18:36 +1200)
commitbcf93e68837edb3b3e8030bad362048e70c9ced9
tree2abf78e4032aa1c26778f8fb396d03dfca1cbddd
parent9006187ab3953da0d6fa5305391bab907e5efdc3
Bug 10976: Fix typo itemtype vs itemtypes

When creating a new report, the limit step let you choose
itype|itemtype.
But it should be itype|itemtypes.
If you try to create a guided report and you choose this option as a
limit, you will get a warning on saving it:
  Errors found when processing parameters for report:
  itype: The authorized value category (itemtype) you selected does not exist.

Looking at the code: reports/guided_reports.pl l.657
  elsif ( $authorised_value eq "itemtypes" ) {

Test plan:
0/ Don't apply the patch
1/ Create a guided report, select Koha itemtype as a limit(step 4)
2/ Confirm you get the error when saving
3/ Apply the patch and repeat step 1
4/ There is no error and the report should work correctly

Tested with steps in comment #4/#5, error is gone after applying patch.
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 856887abcf0468191ecd35b6d9b4e6a36e7a4407)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
C4/Reports/Guided.pm