]> git.koha-community.org Git - koha.git/commit
Bug 27628: Fix minor HTML markup errors in OPAC search results templates
authorOwen Leonard <oleonard@myacpl.org>
Thu, 4 Feb 2021 17:40:24 +0000 (17:40 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 12 Feb 2021 13:19:33 +0000 (14:19 +0100)
commitcd4f4485d737bda4dd7088303044590b79c608a2
treee273211a187747bf73bb3485dfd41b895dc3e794
parent0045e89050ff258bc3dd1518112708fea33c270c
Bug 27628: Fix minor HTML markup errors in OPAC search results templates

This patch makes a couple of minor corrections to templates related to
OPAC search results: An errant quote, and invalidly repeating ids.

The #login4tags id is changed to a class, and CSS related to this id
(which was not used) is removed. For consistency, the id is changed to a
class on the detail page as well.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

 - Perform a search in the OPAC. Confirm that the "Log in to add tags"
   link still looks correct at various browser widths.
 - Confirm that it works to trigger the login modal.
 - Validate the source of the page. There should be no errors.

 - View the detail page for a bibliographic record.
 - The "Log in to add tags" link should look correct and work correctly.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 15c3be55afbcff1d5f149f53273bfb25009582a7)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/opac-tmpl/bootstrap/css/src/_responsive.scss
koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt