Bug 14846 - Items with no holdingbranch causes svc/holds to crash
authorBlou <philippe.blouin@inlibro.com>
Thu, 17 Sep 2015 15:33:38 +0000 (11:33 -0400)
committerFrédéric Demians <f.demians@tamil.fr>
Mon, 14 Dec 2015 15:01:46 +0000 (16:01 +0100)
commitd0636d4800c09a7734df70e3d58c394014606dfc
tree382b6b0236259f66656161da9898aeea1ec5c88d
parente000b9f0f12162f68c22ddc6a2012dae3605a23b
Bug 14846 - Items with no holdingbranch causes svc/holds to crash

When trying to display the holds for a user, if an item has no
holdingbranch, it causes the svc/holds service to crash and the display
to freeze.

Tentative steps to reproduce on any DB:
1) put 1 or more items on hold for a given user.
2) go into the database and set the item.holdingbranch to NULL
3) In the user's page, in checkouts (circulation.pl), click the tab that
   should be written 1 Hold(s)
4) It will be "Processing" indefinitely.

The cause is the svc/holds code that crashes.  The fix will validate
that there's an holdingbranch before proceding with the code.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit c6f7496422a593fdfe4dd2633aed4b190703d03d)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 6012bc8b9988bd4cc2b6fbeecb5de32171f193b6)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
svc/holds