Bug 22456: Add waiting_hold_cancellation circulation rule
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 18 Apr 2022 20:54:14 +0000 (17:54 -0300)
committerTomas Cohen Arazi <tomascohen@theke.io>
Fri, 29 Jul 2022 18:28:13 +0000 (15:28 -0300)
commitd3ebbb88be68e42318f3de08ba55318e2970a70c
tree77b76644404dfb6b7e6556a5022d66b95de3ee31
parenta2dbdc6fc44e379c8bec04f5396799da4f3d9d90
Bug 22456: Add waiting_hold_cancellation circulation rule

This patch adds handling for the waiting_hold_cancellation circulation
rule. It is set no 'No' by default in the atomic update, if not
previously set.

Handling in the rules editor is added, in its own section.

To test:
1. Apply this patch
2. Run:
   $ updatedatabase
=> SUCCESS: All good
3. Verify that the syspref is set:
   $ koha-mysql kohadev
   > SELECT * FROM circulation_rules WHERE rule_name='waiting_hold_cancellation';
=> SUCCESS: Set to 0
4. Play with the rules editor, changing things back and forth, things
   should work, including library-specific and global/defualt settings.
=> SUCCESS: It works
=> SUCCESS: Texts are idiomatic
5. Sign off :-D

Sponsored-by: Montgomery County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Koha/CirculationRules.pm
admin/smart-rules.pl
installer/data/mysql/atomicupdate/bug_22456.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt