]> git.koha-community.org Git - koha.git/commit
Bug 12820: Handle rental fees in Sip issue and renew
authorColin Campbell <colin.campbell@ptfs-europe.com>
Tue, 10 Feb 2015 17:22:43 +0000 (17:22 +0000)
committerChris Cormack <chris@bigballofwax.co.nz>
Sun, 29 Mar 2015 06:32:52 +0000 (19:32 +1300)
commitd95e1ce857714379a4faff88d380314d8715f885
treea9cabb392f8a7e7bafaa555b48c02da802f94c92
parent41e49ef6f8998083d9659477ff5a8247ab1fab45
Bug 12820: Handle rental fees in Sip issue and renew

Implement correct handling of fees associated with checking out
an item.
This is associated with fee acknowledged field (BO)

To quote from the Sip2 document
" If this field is N in a Checkout message and there is a fee
associated with checking out the item, the ACS should tell the
SC in the Checkout Response that there is a fee, and refuse to
check out the item. If the SC and the patron then interact and the
patron agrees to pay the fee, this field will be set to Y on a second
Checkout message, indicating to the ACS that the patron has acknowledged
the fee and checkout of the item should not be refused just
because there is a fee associated with the item"

So there are two Checkout requests the first with BO not set to Y is
rejected but the fee amount is returned. The Second Checkout with BO set
to Y should succeed.

Added a debug log message indicating why we block a checkout
when we dont otherwise indicate

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit fe179c737df8a56be3cac6098d5266becb2dfef2)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Conflicts:
C4/SIP/ILS.pm
C4/SIP/ILS.pm
C4/SIP/ILS/Transaction.pm
C4/SIP/ILS/Transaction/Checkout.pm
C4/SIP/ILS/Transaction/Renew.pm
C4/SIP/Sip/MsgType.pm