]> git.koha-community.org Git - koha.git/commit
Bug 15086: Creators layout and template sql has warnings
authorMark Tompsett <mtompset@hotmail.com>
Thu, 29 Oct 2015 22:23:20 +0000 (18:23 -0400)
committerJulian Maurice <julian.maurice@biblibre.com>
Tue, 17 May 2016 05:52:08 +0000 (07:52 +0200)
commitd9d16622dc57b3bc86b54cafaca942af127e69d2
tree105ef5d8cbb40f8d2b0e7956460c81b8e691bc63
parent1c1167b409ca2cdd9a20ae55278fb078aa14e8fd
Bug 15086: Creators layout and template sql has warnings

When doing a hacked install off the master branch:
use ... {koha database name}
truncate creator_layouts;
truncate creator_templates;
truncate printers_profiles;
source installer/data/mysql/... {name of a sample_labels type file}
Warnings are generated, which may not be visible in the UI.

Most of the warnings were triggered by:
-/*!40000 ALTER TABLE `creator_layouts` DISABLE KEYS */;
-/*!40000 ALTER TABLE `creator_layouts` ENABLE KEYS */;
http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_er_illegal_ha

In the Russian, the layout_name was truncated, because the layout_name was only 20. An atomic update sql and kohastructure.sql update were provided to widen it to 25.
http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_warn_data_truncated

Also fr-FR, ru-RU, and uk-UA were slightly different in structure, so the structure was made the same as the other files.

See comment #1 for the test plan.

NOTE: pl-PL is likely very out of date, but is not affected in this regard.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Works, no more warnings
mysql> show warnings;
Empty set (0.01 sec)

No errors

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit d6ac9270b00ad5a8de6ee755a4ddc40ea4e4d2e3)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
installer/data/mysql/atomicupdate/Bug_15086_UpdateLayoutNameSize.sql [new file with mode: 0644]
installer/data/mysql/de-DE/optional/sample_creator_data.sql
installer/data/mysql/en/optional/sample_creator_data.sql
installer/data/mysql/es-ES/optional/sample_creator_data.sql
installer/data/mysql/fr-FR/2-Optionel/sample_labels.sql
installer/data/mysql/it-IT/necessari/sample_creator_data.sql
installer/data/mysql/kohastructure.sql
installer/data/mysql/nb-NO/2-Valgfritt/sample_creator_data.sql
installer/data/mysql/ru-RU/optional/print_labels.sql
installer/data/mysql/uk-UA/optional/print_labels.sql