]> git.koha-community.org Git - koha.git/commit
Bug 20794: Hide holds tab on details when user lacks circulate_remaining_permissions
authorKatrin Fischer <katrin.fischer.83@web.de>
Sun, 20 May 2018 02:23:47 +0000 (04:23 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 28 Jun 2018 07:09:50 +0000 (09:09 +0200)
commitdae5e20b1ba4aafd194cb1ec8be489920075f3c5
tree0eba1c12d659f2aab947ee900ff6fdcc08c096c2
parent781c33745bda17d94681d05edb0f0bef8271c697
Bug 20794: Hide holds tab on details when user lacks circulate_remaining_permissions

If a user doesn't have circulate_remaining permissions, but has borrowers:
- checkouts tab is hidden
- details tab is visible
- holds tab on details is visible, but results in an error

The problem is that the svc/holds script requires circulate_remaining_permissions.

To test:
- Create 2 staff users with and without circulate_remaining_permissions
  Both need borrowers permission
- Go to the details tab in a patron's account who has holds
- Verify that you get a datatables error for the staff patron without
  circulate_remaining_permissions
- Apply patch
- Verify that now the holds tab is no longer displayed for this patron

Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit b3d1a5bfecbfbac4af8335757414def1ee3e2df5)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt