Bug 25045: Allow restricting anonymous requests on the public API
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 13 Apr 2020 14:40:48 +0000 (11:40 -0300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 27 Apr 2020 10:15:37 +0000 (11:15 +0100)
commitec99043a2ede2f994dae72ee2f68884174f94d4c
tree50926207981a8e63aa88eefcdcc0d46614b9825a
parent78cb447c7cd13bd37a48f7b3e2d2aa47b5d7b4d9
Bug 25045: Allow restricting anonymous requests on the public API

This patch introduces a check on the authenticate_api_request method for
the RESTPublicAnonymousRequests system preference. If disabled,
anonymous  requests get rejected.

The idea is to replicate the homologous OpacPublic system preference
behaviour.

To test:
1. Apply the Unit tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t
=> FAIL: Tests fail, 200 is answered instead of 401 on the route.
3. Apply this patch
4. Repeat 2.
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Koha/REST/V1/Auth.pm