Bug 28581: Add 'from_email_address' method and use in Koha::Patron
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 17 Jun 2021 08:54:46 +0000 (09:54 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 9 Jul 2021 13:05:48 +0000 (09:05 -0400)
commiteff0187295b69e6eb7e7d80cd9ad0a6fb6c30c51
treeafaf40c212e17e3f24a6a1ec1c2a394c0fb2fbbf
parent5197b22d392053b69cbe4c4449014bee249fbdfe
Bug 28581: Add 'from_email_address' method and use in Koha::Patron

This patch adds a new 'from_email_address' method to Koha::Library to
return the appropriate email address to use as the 'from' field for
email notices from the library.

We then update Koha::Patron->queue_notice to use this new method instead
of the incorrect inbound_email_address.

I also update the POD for inbound_email_address to clarify it's use
case.

Test plan

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Koha/Library.pm
Koha/Patron.pm
t/db_dependent/Koha/Libraries.t