]> git.koha-community.org Git - koha.git/log
koha.git
15 years agoBug 3428: Alphabetizes the collection codes in the Advanced Search.
Garry Collum [Sun, 19 Jul 2009 00:02:24 +0000 (20:02 -0400)]
Bug 3428: Alphabetizes the collection codes in the Advanced Search.

If the advancedSearchTypes = CCODE, the code descriptions are not alphabetized, as opposed to itemtypes, which are alphabetized.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug fix reconciliation of circulation compilation error
Henri-Damien LAURENT [Thu, 16 Jul 2009 22:11:59 +0000 (00:11 +0200)]
Bug fix reconciliation of circulation compilation error

reconciliation in circulation.pl introduced a compilation error

15 years agoBug 2770 follwup : force AddRenewal obey circControl system preference [revised]
Ryan Higgins [Thu, 2 Jul 2009 01:37:42 +0000 (20:37 -0500)]
Bug 2770 follwup : force AddRenewal obey circControl system preference [revised]

Also prevents infinite-length renewals by returning undef
if passed an invalid date instead of renewing with no due date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix crash introduced in previous patch
Galen Charlton [Wed, 15 Jul 2009 02:00:36 +0000 (22:00 -0400)]
fix crash introduced in previous patch

In the previous patch,

-    my @subf = $field->subfields;
-    (defined @subf) or @subf = ();

is not equivalent to

+    my @subf = $field->subfields || ();

as, the results of $field->subields is interpeted in scalar
context, not list context, resutling in @subf containing
the number of subfields, not the subfield data itself, which
engenders the error

Can't use string ("1") as an ARRAY ref while "strict refs" in use

later on.  Changing the operator to 'or' instead of '||'
fixes this.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBranch auto-selection in additem
Joe Atzberger [Wed, 8 Jul 2009 21:52:18 +0000 (16:52 -0500)]
Branch auto-selection in additem

Adding a new item should pre-select the library you are logged in at, where possible.
Use GetBranchesLoop.  This solves indy branches filtering, and sort order problems.
Set default off of ->{selected}, to establish pre-selected branch.
Fix flags check in onlymine sub, so superlibrarian + other flags still gets everything.
Removed defined(@array) check, since perl -wc warns it is deprecated.
Note new FIXME for botched date processing.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2539. Remove unintegrated "spsuggest" code from search scripts.
Joe Atzberger [Thu, 2 Jul 2009 03:47:35 +0000 (22:47 -0500)]
Bug 2539. Remove unintegrated "spsuggest" code from search scripts.

The intent of kohaspsuggest is very confused.  It wanted to simultaneously
log every search query, and get spelling suggestions from a totally different
database_host:db_user:db_password:database.  The implementation seems
never have really made it into 3.0, however, since the only trace of the
tables it wants to query are in misc/migration_tools/22_to_30/phrase_log.sql

The job misc/spellcheck_suggest/make_spellcheck_suggest.pl does not even
target the same remote DB as the syspref tells the search code to do.  Instead, it hits the
local DB and, not finding the tables that have no way of existing in a 3.0
install, it CREATES its own tables spontaneously, using MyISAM storage, no less.
This script should be drastically overhauled, or more likely just removed.

Other fixes:
Commented out unconditional warn!
Also reduced bizarre whitespace amounts in catalogue/search.pl and
fixed warning as recommended by perl -wc:
    Scalar value @newresults[0] better written as $newresults[0]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agonew icon included in OPAC details page rework
Galen Charlton [Wed, 15 Jul 2009 01:14:18 +0000 (21:14 -0400)]
new icon included in OPAC details page rework

Picked up icon from earlier version of Owen's patch
for bug 2713.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup opac-search.pl
Joe Atzberger [Thu, 2 Jul 2009 03:12:29 +0000 (22:12 -0500)]
Cleanup opac-search.pl

Use GetBranchesLoop.  Use elsif.  Use $format w/ a fallback "" value.

More to come.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMinor Fixes for jQuery 1.3.2 Upgrade
John Beppu [Thu, 9 Jul 2009 01:09:00 +0000 (20:09 -0500)]
Minor Fixes for jQuery 1.3.2 Upgrade

I looked through all the relevant Javascript on this site
to find spots that would break in the upgrade from jQuery 1.2
to jQuery 1.3, and I fixed them.

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMore changes to implement jQuery upgrade.
Owen Leonard [Thu, 9 Jul 2009 01:09:01 +0000 (20:09 -0500)]
More changes to implement jQuery upgrade.

- Upgrading jquery checkboxes plugin
- Correcting references to checkboxes plugin
- Upgrading jquery hotkeys plugin
- Upgrading syntax for calls to hotkeys plugin
- Removing jquery dimensions plugin (functionality rolled into jQuery)

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUpgraded from jQuery 1.2.3 to 1.3.2
John Beppu [Wed, 8 Jul 2009 18:12:15 +0000 (13:12 -0500)]
Upgraded from jQuery 1.2.3 to 1.3.2

http://docs.jquery.com/Release:jQuery_1.3
http://www.learningjquery.com/2009/03/3-quick-steps-for-a-painless-upgrade-to-jquery-13

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3390 Enabling ZIP compression in pdf generation to reduce file size
Chris Nighswonger [Sat, 4 Jul 2009 04:14:50 +0000 (00:14 -0400)]
Bug 3390 Enabling ZIP compression in pdf generation to reduce file size

Enabling compression gives a ~26% *reduction* over non-compressed Type 3 font embedding.
ie. 4.5 K/pg (compressed graphic) vs. 17.5 K/pg (uncompressed Type 3 font) vs 111 K/pg
(uncompressed graphic).

It also appears that most other applications that export in pdf use compression by
default. (OO Writer, etc.) So this approach appears justified. One could always add code
to allow the user to select embedding mode and compression.

Also correcting mode parameter value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3284) fix superlibrarian check
Nahuel ANGELINETTI [Fri, 26 Jun 2009 09:25:01 +0000 (11:25 +0200)]
(bug #3284) fix superlibrarian check

This fix the superlibrarian check in the previous fix.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3284) fix borrower deletion in independantbranches mode
Nahuel ANGELINETTI [Thu, 25 Jun 2009 10:57:35 +0000 (12:57 +0200)]
(bug #3284) fix borrower deletion in independantbranches mode

This patch fix the checks deleting a borrower in independantbranches mode.
Now, we check the user and the librarian are from the same branch, else we deny the deletion(and disable the link to delete).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSpelling correction per convention: cataloguing -> cataloging (Bug 3277)
Owen Leonard [Sat, 27 Jun 2009 15:43:17 +0000 (10:43 -0500)]
Spelling correction per convention: cataloguing -> cataloging (Bug 3277)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoReturns reworking to handle empty GetItemIssue
Joe Atzberger [Thu, 18 Jun 2009 16:31:33 +0000 (11:31 -0500)]
Returns reworking to handle empty GetItemIssue

Code cannot rely on issueinformation being populated.

Note there is room for better efficiency to have AddReturn also provide the
itemnumber (where existing) so that GetItemnumberFromBarcode is not called
at both levels.  Unfortunately there is discrepancy between this idea (for
efficiency) and the stated purpose of the $iteminformation object returned,
since $iteminformation is specifically the info from the issues table and
MUST be empty when the item was not in fact issued.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoEnable warnings in addbooks.pl Fix code generating undef and mis-matched op warnings...
Colin Campbell [Tue, 23 Jun 2009 08:14:31 +0000 (09:14 +0100)]
Enable warnings in addbooks.pl Fix code generating undef and mis-matched op warnings Remove toggle variable

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2893: extend conditions handled by AllowNotForLoanOverride
Galen Charlton [Wed, 17 Jun 2009 13:00:57 +0000 (08:00 -0500)]
bug 2893: extend conditions handled by AllowNotForLoanOverride

Prior to this patch, turning AllowNotForLoanOverride on
allowed the circ operator to permit the loan of an
item who's individual not-for-loan flag was set, but did
not allow the loan of an item whose item type's not-for-loan
flag was set.  This patch extends the definition of the
system preference so that both cases are covered.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRevision to my earlier patch for displaying the user name on checked-out items
Jane Wagner [Tue, 16 Jun 2009 16:28:06 +0000 (12:28 -0400)]
Revision to my earlier patch for displaying the user name on checked-out items

My earlier patch (using the new syspref OPACShowCheckoutName mistakenly
displayed the Koha borrower number instead of the patron barcode number
in the OPAC display; this revises the script/template to use barcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3317: Author displaying inconsistently or not at all. Revision to previous patch.
Garry Collum [Wed, 17 Jun 2009 00:37:51 +0000 (20:37 -0400)]
Bug 3317: Author displaying inconsistently or not at all. Revision to previous patch.

Revision to previous patch for bug 3317.  Removes the EXPR command from opac-basket.tmpl, which was polluting the apache logs.

NTS: Don't use EXPR.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd +(" ")+ to make few strings translatable (with Paul & Galen fix)
Frédéric Demians [Tue, 9 Jun 2009 14:24:37 +0000 (16:24 +0200)]
Add +(" ")+ to make few strings translatable (with Paul & Galen fix)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFixing toggle
Chris Cormack [Mon, 7 Sep 2009 23:48:57 +0000 (11:48 +1200)]
Fixing toggle

15 years agoBug 2889: Removed toggle variable from categorie.pl and categorie.tmpl.
Garry Collum [Tue, 9 Jun 2009 22:34:55 +0000 (18:34 -0400)]
Bug 2889: Removed toggle variable from categorie.pl and categorie.tmpl.

Removed toggle variable from categorie.pl and categorie.tmpl.  Used template __odd__variable in categorie.tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2889: Added highlighting to smart-rules.tmpl
Garry Collum [Thu, 11 Jun 2009 00:23:52 +0000 (20:23 -0400)]
Bug 2889: Added highlighting to smart-rules.tmpl

Removed unused toggle variable form smart-rules.pl and added highlighting to smart-rules.tmpl through template __odd__.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoPull the last OPAC-specific tmpl vars out of gettemplate.
Joe Atzberger [Thu, 4 Jun 2009 17:43:52 +0000 (12:43 -0500)]
Pull the last OPAC-specific tmpl vars out of gettemplate.

These don't belong every template, only on OPAC:
~ opacstylesheet
~ opaccolorstylesheet
~ opacsmallimage

The latter 2 were already being populated in C4::Auth anyway.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3271 : Added tooltip when adding to a list with no item selected (same as for...
Matthias Meusburger [Fri, 29 May 2009 12:43:55 +0000 (14:43 +0200)]
bug 3271 : Added tooltip when adding to a list with no item selected (same as for cart)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3263: fixed ersatz references to AmazonContent
Galen Charlton [Wed, 27 May 2009 18:10:45 +0000 (13:10 -0500)]
bug 3263: fixed ersatz references to AmazonContent

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3263: Staff Search Results Interface Changes
Galen Charlton [Wed, 27 May 2009 18:10:42 +0000 (13:10 -0500)]
bug 3263: Staff Search Results Interface Changes

Coding by Rick Welykochy <rick@praxis.com.au>

[1] Three new system preferences to enable particular
bib record views in the staff interface:

viewMARC
viewLabeledMARC
viewISBD

Implements enhancement 2642.

[2] New button in the regular and cataloging search results
   pages in the staff interface to allow the operator to redo
   the search against Z39.50 targets instead of the Koha database.

[3] Added copyright date and edition to cataloging and Z39.50 search results.
    Implements enhancement 2640.

Feature sponsored by MassCat.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3244: Support for multiple PAC interfaces.
Ryan Higgins [Wed, 27 May 2009 15:31:47 +0000 (10:31 -0500)]
bug 3244: Support for multiple PAC interfaces.

Adds three env vars allowing url-specific search limits, and defining
how the limit interacts with 'SearchMyLibraryFirst'.
See http://wiki.koha.org/doku.php?id=en:development:rfcs3.2:rfc32_multiple_opac

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2500 Tweaking DDCN Split for Hyphenated Volumn Numbers
Chris Nighswonger [Wed, 27 May 2009 15:30:14 +0000 (11:30 -0400)]
Bug 2500 Tweaking DDCN Split for Hyphenated Volumn Numbers

Presently 252.051 T147 v.1-2 is split as

252.051
T147
v.1
-2

This patch corrects the algorithm so that it splits as

252.051
T147
v.1-2

It also updates Labels_split_ddcn.t to include this particular case.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSmall documentation improvement for C4::Service
Jesse Weaver [Wed, 27 May 2009 14:31:29 +0000 (08:31 -0600)]
Small documentation improvement for C4::Service

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix uninitialized value warnings during COinS generation
Galen Charlton [Wed, 27 May 2009 14:01:00 +0000 (09:01 -0500)]
fix uninitialized value warnings during COinS generation

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup waitingreserves.pl and .tmpl
Joe Atzberger [Tue, 26 May 2009 21:41:03 +0000 (16:41 -0500)]
Cleanup waitingreserves.pl and .tmpl

Use warnings and provide fallback values to avoid them.
Move waitingdate check up to top of loop.
Move $today creation outside loop (should be same for all).
Remove unused and unnecessary variables.
Add subtitle escaping to .tmpl and slightly standardize formatting.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3219: handle variation in Amazon responses
Galen Charlton [Tue, 26 May 2009 19:20:03 +0000 (14:20 -0500)]
bug 3219: handle variation in Amazon responses

An Amazon ItemLookup response can sometimes have
more than one Item element, where the ones after
the first appear to be cross references to items
that have the same ISBN.  Changed parsing so that
those responses are no longer treated like pseudohashes.

This fixes the following crash:

[error] detail.pl: Pseudo-hashes are deprecated at /catalogue/detail.pl line
213., referer: /cgi-bin/koha/catalogue/detail.pl

Which may lead to a nasty:
[error] Out of memory!, referer: /cgi-bin/koha/catalogue/detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3261: Fix for invalid XHTML on Personal Details page.
Garry Collum [Wed, 27 May 2009 01:32:42 +0000 (21:32 -0400)]
Bug 3261: Fix for invalid XHTML on Personal Details page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup view_holdsqueue.pl and .tmpl (minor)
Joe Atzberger [Fri, 22 May 2009 21:45:51 +0000 (16:45 -0500)]
Cleanup view_holdsqueue.pl and .tmpl (minor)

Convert to GetBranchesLoop.
Insert template message to display for ALL libraries search, so that the
message is n0t truncated like "X items found for".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agominor fix - don't declare variables in a conditional
Galen Charlton [Wed, 27 May 2009 11:53:17 +0000 (06:53 -0500)]
minor fix - don't declare variables in a conditional

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFixing a bug that crept in with a cherry-pick
Chris Cormack [Mon, 7 Sep 2009 00:42:31 +0000 (12:42 +1200)]
Fixing a bug that crept in with a cherry-pick

15 years agoBug 3241: Place hold button appears on results page if opacuserlogin is off
Garry Collum [Sat, 23 May 2009 19:22:57 +0000 (15:22 -0400)]
Bug 3241: Place hold button appears on results page if opacuserlogin is off

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoquell warning if format parameter isn't passed to opac-search.pl
Galen Charlton [Fri, 15 May 2009 15:53:42 +0000 (10:53 -0500)]
quell warning if format parameter isn't passed to opac-search.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdded barcode query back to circ/ysearch.pl for patron proxies.
Daniel Sweeney [Wed, 25 Mar 2009 21:37:17 +0000 (16:37 -0500)]
Added barcode query back to circ/ysearch.pl for patron proxies.

This is to allow patron proxy relationships to be built using the patron barcode.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago@renew_failed can cause enormous performance-killing array.
Joe Atzberger [Thu, 14 May 2009 20:28:40 +0000 (15:28 -0500)]
@renew_failed can cause enormous performance-killing array.

The array was populated and values flagged with an accessor, like:
    for (@failedrenews) { $renew_failed[$_] = 1; }
But this means that an array of possibly hundreds of thousands of elements
would have to be auto-populated for high itemnumbers.  A hash is the correct
structure.  We also haven't checked the user input for validity, so we do not know
for sure that @failedrenews really does contain just itemnumbers.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoupdated JSON and JSON::XS package reqs for Debian lenny
Galen Charlton [Thu, 14 May 2009 12:53:33 +0000 (07:53 -0500)]
updated JSON and JSON::XS package reqs for Debian lenny

By default, the JSON module will automatically use
JSON::XS if available.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3169 - Comply with new Google Book branding guidelines
Frédéric Demians [Tue, 12 May 2009 12:28:27 +0000 (14:28 +0200)]
Bug 3169 - Comply with new Google Book branding guidelines

It adds pretty huge image 'Google Preview' on google
book jacket.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoWhoops extra } crept in when fixing a merge conflict, removing it
Chris Cormack [Tue, 12 May 2009 10:13:10 +0000 (22:13 +1200)]
Whoops extra } crept in when fixing a merge conflict, removing it

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 1907 partial fix: prevent warnings on undefined params.
Chris Catalfo [Tue, 12 May 2009 00:35:13 +0000 (00:35 +0000)]
Bug 1907 partial fix: prevent warnings on undefined params.

This patch adds default blank values for a couple of params the script might receive which were producing warns in the error log. Also wraps GetMarcBiblio in an eval.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoScript to check for corruption of marcxml, and optionally to attempt fix.
Joe Atzberger [Mon, 11 May 2009 21:44:29 +0000 (16:44 -0500)]
Script to check for corruption of marcxml, and optionally to attempt fix.

When marcxml cannot be parsed into a MARC::Record object, the biblio is
undisplayable and it obviously breaks many features in Koha.  This script
can test to parse every marcxml, and alert on failures.  Optionally, the
marcxml can be replaced from the marc field.

See extensive perldoc for details.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3211: fix XHTML validation errors in MAR21 bib leader plugin
Galen Charlton [Fri, 8 May 2009 20:10:14 +0000 (15:10 -0500)]
bug 3211: fix XHTML validation errors in MAR21 bib leader plugin

Note that as a result of this patch, not only will the
page use valid XHTML, but the intranet stylesheets are
now used, IMO improving the display of the form.

This patch also fixes the descriptions of the Leader/09
and Leader/17.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3209: add 'p' (mixed materials) to MARC21 Leader/06 dropdown
Galen Charlton [Fri, 8 May 2009 20:10:13 +0000 (15:10 -0500)]
bug 3209: add 'p' (mixed materials) to MARC21 Leader/06 dropdown

Also made the following updates to the MARC21 leader plugin

[1] Changed description of Leader/08 to 'Type of control'
[2] Fixed typo in description value for 'z' in Leader/17
[3] Updated Leader/19, which is now 'Multipart resource record level'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3120: tweak splitting of Dewey call number
Galen Charlton [Fri, 8 May 2009 22:31:14 +0000 (17:31 -0500)]
bug 3120: tweak splitting of Dewey call number

If a call number prefix contains a hyphen, try not to
split on the hyphen.  For example, rather than
splitting the call number 'CD-ROM 787.87 EAS'
like this:

CD
-ROM
787.87
EAS

it should be

CD-ROM
787.87
EAS

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3213 - UNIMARC/MARC21 selection
Frédéric Demians [Mon, 11 May 2009 11:41:49 +0000 (13:41 +0200)]
Bug 3213 - UNIMARC/MARC21 selection

Modify how XSLT stylesheet are choosen
depending on 'marcflavour' syspref.

DOCUMENTATION: XSLTResultsDisplay and XSLTDetailsDisplay
sysprefs aren't MARC21-only anymore.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoTweak offline_circ - honor itemBarcodeInputFilter and add to Makefile.PL
Michael Hafen [Tue, 5 May 2009 21:01:09 +0000 (15:01 -0600)]
Tweak offline_circ - honor itemBarcodeInputFilter and add to Makefile.PL

Add the ofline_circ directory to Makefile.PL as needing to be installed.
Add calls to barcodedecode() on issueing and returning.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix all templates errors reported by xt/author/valid-templates.t
Galen Charlton [Fri, 1 May 2009 22:59:04 +0000 (17:59 -0500)]
fix all templates errors reported by xt/author/valid-templates.t

In process, removed four disused HTML templates and one
disused script, serials/receipt.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for opac-detail being broken after merging
Chris Cormack [Sat, 5 Sep 2009 20:03:29 +0000 (08:03 +1200)]
Fix for opac-detail being broken after merging

15 years agoRevert "followup previous patch - remove disused $opacstylesheet"
Henri-Damien LAURENT [Sat, 5 Sep 2009 15:36:57 +0000 (17:36 +0200)]
Revert "followup previous patch - remove disused $opacstylesheet"

This reverts commit 59b8fd2383053698996ffd2f6d936d8fcb20ca76.
c4/Output would not compile

15 years ago(bug #3497) show publication year, or copyrightdate
Nahuel ANGELINETTI [Wed, 5 Aug 2009 07:48:56 +0000 (09:48 +0200)]
(bug #3497) show publication year, or copyrightdate

This change the shelf view in opac, to show publication year, in the column "Year"(that was previously copyrightdate), and is there is no publication year, show copyright date.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3459) fix opac-topissue to take care of ccode
Nahuel ANGELINETTI [Fri, 31 Jul 2009 15:05:27 +0000 (17:05 +0200)]
(bug #3459) fix opac-topissue to take care of ccode

This bugfix, add a conditionnal sql request, that get the "ccode" document type if AdvancedSearchTypes is positionned to ccode.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3458) fix die and unimarc 700-4 plugin
Nahuel ANGELINETTI [Fri, 31 Jul 2009 13:58:53 +0000 (15:58 +0200)]
(bug #3458) fix die and unimarc 700-4 plugin

This patch, fix the unimarc 700-4 plugin, adding the plugin_parameters() function.
And add an eval, that permit to have error in plugin, but don't die the editor.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3432) fix return of lost items
Nahuel ANGELINETTI [Tue, 21 Jul 2009 07:28:19 +0000 (09:28 +0200)]
(bug #3432) fix return of lost items

This patch delete some useless code, and fix the problem that if a lost item is returned, the lost flag is not deleted.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3409) fix return rules for transfert
Nahuel ANGELINETTI [Fri, 10 Jul 2009 12:30:03 +0000 (14:30 +0200)]
(bug #3409) fix return rules for transfert

This patch add the use of CircControl and HomeOrHoldingBranch for return and transfert rules.
* ItemHomeLibrary goes to item{HomeOrHoldingBranch}
* PatronLibrary goes to the borrower library
* PickupLibrary depends where the items was checked out, and the actual library.

This add a little improvment that does not re-request each time the circcontrol syspref.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoRemoving unused files from the serials module
Matthias Meusburger [Thu, 3 Sep 2009 15:37:31 +0000 (17:37 +0200)]
Removing unused files from the serials module

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3573) use delimiter syspref generating overdues csv
Nahuel ANGELINETTI [Wed, 2 Sep 2009 15:09:21 +0000 (17:09 +0200)]
(bug #3573) use delimiter syspref generating overdues csv

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdding autotruncation
Henri-Damien LAURENT [Wed, 2 Sep 2009 13:30:12 +0000 (15:30 +0200)]
Adding autotruncation

Allow autotruncation to be set on its own
This simply reprocess operands in order to add * at lefthandside
It is a problem with non LTR scripts. But works fine with all the latin scripts

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3541) show reserved items as not available
Nahuel ANGELINETTI [Thu, 20 Aug 2009 14:36:41 +0000 (16:36 +0200)]
(bug #3541) show reserved items as not available

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago[3.0.x](bug #3242) send email when hold is placed
Nahuel ANGELINETTI [Fri, 28 Aug 2009 13:19:26 +0000 (15:19 +0200)]
[3.0.x](bug #3242) send email when hold is placed

This add a new letter in database, and each time a new hold is placed, a new mail is enqueued.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago[3.0.x](bug #3560) This add a filter to search by itemtype
Jean-André Santoni [Thu, 27 Aug 2009 11:16:01 +0000 (13:16 +0200)]
[3.0.x](bug #3560) This add a filter to search by itemtype

The value builder for 4XX should be able to filter results by itemtype.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago[3.0.x](bug #3555) This sets the default branch to the logged user branch when Indepe...
Jean-André Santoni [Wed, 26 Aug 2009 13:26:56 +0000 (15:26 +0200)]
[3.0.x](bug #3555) This sets the default branch to the logged user branch when IndependantBranches is active

In the advanced search form, when IndependantBranches is activated, the default
branch should be set to the logged user branch.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago[3.0.x](bug #3552) This mark mandatory fields with a red asterisk
Jean-André Santoni [Wed, 26 Aug 2009 08:31:51 +0000 (10:31 +0200)]
[3.0.x](bug #3552) This mark mandatory fields with a red asterisk

Many librarian ask for a way to know if a field is mandatory before validation.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3557) fix bor_issues_top
Nahuel ANGELINETTI [Wed, 26 Aug 2009 14:52:27 +0000 (16:52 +0200)]
(bug #3557) fix bor_issues_top

Just add the condition where column is "None".

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3553) do not allow users to create code-less frameworks
Nahuel ANGELINETTI [Wed, 26 Aug 2009 11:18:50 +0000 (13:18 +0200)]
(bug #3553) do not allow users to create code-less frameworks

This patch, disallow the users to create frameworks without frameworkcode.
It adds some javascripts checks, and some perls checks(for non-javascript users).

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago[3.0.x](bug #3549) Sorted framework options in the dropdown menu
Jean-André Santoni [Tue, 25 Aug 2009 08:12:21 +0000 (10:12 +0200)]
[3.0.x](bug #3549) Sorted framework options in the dropdown menu

In addbook.pl, the framwork options are sorted in random order. They should be
sorted in alphabetical order of value or code.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3546) fix issues_stats
Nahuel ANGELINETTI [Mon, 24 Aug 2009 11:56:15 +0000 (13:56 +0200)]
(bug #3546) fix issues_stats

This fix the order of columns.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3512) fix acquisition reports and group by
Nahuel ANGELINETTI [Thu, 6 Aug 2009 08:03:25 +0000 (10:03 +0200)]
(bug #3512) fix acquisition reports and group by

This fix, just change a grep value that make different way to calculate the table depending on the choosen column and line.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago[followup](bug #3505) order collections by alphabetical order
Nahuel ANGELINETTI [Thu, 6 Aug 2009 13:06:08 +0000 (15:06 +0200)]
[followup](bug #3505) order collections by alphabetical order

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3505) fix 210c and 225a unimarc's plugins
Nahuel ANGELINETTI [Wed, 5 Aug 2009 13:11:29 +0000 (15:11 +0200)]
(bug #3505) fix 210c and 225a unimarc's plugins

This fix the 2 plugins, make 225a to work with koha 3.0, and fix 210c to be xhtml valid

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAuto incremental inventory number plugin
Jean-André Santoni [Fri, 14 Aug 2009 13:41:23 +0000 (15:41 +0200)]
Auto incremental inventory number plugin
Renamed it stocknumber.pl to avoid confusion with the already existing inventory.pl

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoThis is a calatoguing plugin based on auth_finder but specific to one of our customers.
Jean-André Santoni [Thu, 6 Aug 2009 08:17:10 +0000 (10:17 +0200)]
This is a calatoguing plugin based on auth_finder but specific to one of our customers.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3453) fix authority search in opac
Nahuel ANGELINETTI [Wed, 29 Jul 2009 08:31:58 +0000 (10:31 +0200)]
(bug #3453) fix authority search in opac

this just set default values in opac search.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #2812) fix holds cancel in OPAC
Nahuel ANGELINETTI [Fri, 24 Jul 2009 14:01:48 +0000 (16:01 +0200)]
(bug #2812) fix holds cancel in OPAC

This fix the user ability to cancel holds in OPAC.
At the moment, a user can cancel all his holds, but in fact, only items that are not in transfert or waiting to be checked out can be cancelled by the user.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3421) fix the xhtml in serial biblio search
Nahuel ANGELINETTI [Wed, 15 Jul 2009 09:58:05 +0000 (11:58 +0200)]
(bug #3421) fix the xhtml in serial biblio search

This fix differents errors, and escape in bib search.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3412) fix double encoded guided report
Nahuel ANGELINETTI [Fri, 10 Jul 2009 14:49:59 +0000 (16:49 +0200)]
(bug #3412) fix double encoded guided report

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3403) fix circulation.pl reservation list
Nahuel ANGELINETTI [Tue, 7 Jul 2009 15:16:13 +0000 (17:16 +0200)]
(bug #3403) fix circulation.pl reservation list

This delete useless code that introduce the leak of reserved items informations.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3411) escape authorities values
Nahuel ANGELINETTI [Fri, 10 Jul 2009 10:16:18 +0000 (12:16 +0200)]
(bug #3411) escape authorities values

The values are not escaped in javascript, so if there is double quotes, the authority cannot be imported because of javascript error. This patch fix this.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoThis little hack makes BuildUnimarcHierarchy able to work with any 2.. field.
Jean-André Santoni [Thu, 23 Jul 2009 13:19:23 +0000 (15:19 +0200)]
This little hack makes BuildUnimarcHierarchy able to work with any 2.. field.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3395) fix unimarc plugin 225$a
Nahuel ANGELINETTI [Mon, 6 Jul 2009 12:58:24 +0000 (14:58 +0200)]
(bug #3395) fix unimarc plugin 225$a

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago[followup](bug #3080) refix the sql request
Nahuel ANGELINETTI [Thu, 2 Jul 2009 10:30:05 +0000 (12:30 +0200)]
[followup](bug #3080) refix the sql request

This fix the sql request that have some problems of synthax and a table repeated in "FROM".

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBUG 3371: ISBN no longer shows twice when more options on
Nicole Engard [Sat, 22 Aug 2009 14:30:36 +0000 (10:30 -0400)]
BUG 3371: ISBN no longer shows twice when more options on

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBUG #3533: Fix documentation link in news for new installs
Nicole Engard [Sat, 22 Aug 2009 14:05:49 +0000 (10:05 -0400)]
BUG #3533: Fix documentation link in news for new installs

This patch only fixes the link for new installs, not for
updates.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCleaned up display on reports page
Nicole Engard [Wed, 19 Aug 2009 01:31:03 +0000 (21:31 -0400)]
Cleaned up display on reports page

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdds helpful note to Home Phone and Home Email fields to remind staff which fields...
Liz Rea [Tue, 18 Aug 2009 14:47:08 +0000 (09:47 -0500)]
Adds helpful note to Home Phone and Home Email fields to remind staff which fields are shown on transit slips.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAvoid numeric comparisons with leading zeroes
Colin Campbell [Thu, 20 Aug 2009 10:12:57 +0000 (11:12 +0100)]
Avoid numeric comparisons with leading zeroes

Numbers in perl with leading zeros are interpreted in octal
Ensure that comparisons are done using string operators
or where appropriate use the MARC::Field method

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3420: Revised follow-up patch for 'patrons with no checkouts'
Garry Collum [Thu, 20 Aug 2009 19:22:57 +0000 (15:22 -0400)]
Bug 3420: Revised follow-up patch for 'patrons with no checkouts'

Comments out all warnings that were used for debugging.

Enables warnigns and fixes the resulting warnings.

This patch replaces the previous follow-up patch for bug 3420.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2889: Adds table highlighting to the Authority search results.
Garry Collum [Thu, 20 Aug 2009 22:07:08 +0000 (18:07 -0400)]
Bug 2889: Adds table highlighting to the Authority search results.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoEdits to the about page : Adding a couple of missing developers, and adding ohloh...
Chris Cormack [Thu, 20 Aug 2009 22:27:42 +0000 (10:27 +1200)]
Edits to the about page : Adding a couple of missing developers, and adding ohloh links, still more links to go

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2505: Enables warnings in reserveratios.pl
Garry Collum [Thu, 20 Aug 2009 23:32:18 +0000 (19:32 -0400)]
Bug 2505: Enables warnings in reserveratios.pl

Also fixes resulting warnings.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoRemove utility script replaced by a test case
Frédéric Demians [Mon, 17 Aug 2009 18:35:27 +0000 (20:35 +0200)]
Remove utility script replaced by a test case

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoTest case identifying incoherences between 'en' sysprefs and translated ones
Frédéric Demians [Mon, 17 Aug 2009 18:35:26 +0000 (20:35 +0200)]
Test case identifying incoherences between 'en' sysprefs and translated ones

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFollow up patch for the about patch, changing management team to release team
Chris Cormack [Mon, 17 Aug 2009 10:52:04 +0000 (22:52 +1200)]
Follow up patch for the about patch, changing management team to release team

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoUpdating about page, some are bound to be missed, please send additional patches
Chris Cormack [Sat, 15 Aug 2009 22:18:16 +0000 (10:18 +1200)]
Updating about page, some are bound to be missed, please send additional patches

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3420: Fixes 'Patrons with no checkouts' report.
Garry Collum [Sat, 15 Aug 2009 13:50:24 +0000 (09:50 -0400)]
Bug 3420: Fixes 'Patrons with no checkouts' report.

Fixed typo in SQL statement.  Commented out some unused SQL statements.

Removed limit for itemtype (column not available in results) and added limit for branchcode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>