Chris Nighswonger [Tue, 9 Feb 2010 13:35:58 +0000 (08:35 -0500)]
Bugfix: Uncommenting pagination code
Pagination code was commented out during development causing the
spill over page one to be wrapped back onto page one. This patch
fixes that problem.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Fri, 2 Oct 2009 11:22:47 +0000 (12:22 +0100)]
Bug 2505 Enabled warnings in authorities/*
Fixed obvious warnings generators in scripts
with mismatched comparisons or undefined variables
removed temporary variable selected while ensuring the
comparison it represented was between two defined variables
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Fri, 9 Oct 2009 11:23:54 +0000 (12:23 +0100)]
Bug 3700 Parameters passed in wrong sequence
As subsequent operations don't get what they expect
all manner of nastiness ensues
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Thu, 17 Sep 2009 09:38:14 +0000 (10:38 +0100)]
add PTFS-Europe as a contributing company
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Thu, 1 Oct 2009 10:27:51 +0000 (11:27 +0100)]
Enable warnings in koha2marclinks.pl
Fix code generating warnings with warnings enabled
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Thu, 1 Oct 2009 10:28:24 +0000 (11:28 +0100)]
Enable warnings in marctagstructure.pl
Fix a couple of comparisons generating warnings
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Wed, 21 Oct 2009 08:54:18 +0000 (09:54 +0100)]
Bug 3723 Correct return of Institution in Patron Info Resp
While the comment correctly notes that the order of variable length
fields is not fixed some units expect mandatory fields to
follow the sequence in the protocol definition and fail
parsing otherwise. Moved institution id to its expected
place in the patron information response.
Indented the first half of the if (patron_valid) so its clearer
that two cases are handled here.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Wed, 4 Nov 2009 21:15:55 +0000 (21:15 +0000)]
(Bug 3767 - Return error if checkin passed an invalid item
If an invalid item barcode is passed to checkin
the sip2 connection dies. This is because although
no item object is created its mehods are called in Checkin
To maintain the connection properly catch the condition
and return the correct response to the unit
(should also fix Bug #3696 )
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 9 Feb 2010 02:14:12 +0000 (21:14 -0500)]
DB rev 116 - finish fixing default value of OrderPdfFormat
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Fri, 5 Feb 2010 10:23:42 +0000 (05:23 -0500)]
bug 3923 followup - change orderpdfformat value if set wrong due to upgrade
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Mon, 8 Feb 2010 17:35:26 +0000 (12:35 -0500)]
Fix for Bug 4138, Adding or deleting suggestions in the OPAC does not properly refresh the page
- Using redirect() and adding URL parameter to enable the display of
messages on the screen confirming the action.
- Also correcting for JavaScript error in form validation routine.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Nighswonger [Mon, 8 Feb 2010 20:23:58 +0000 (15:23 -0500)]
Bugfix: Enabling guide box configuration parameter
This patch enables turning the guide boxes on/off in the patron
cards layout editor.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Nighswonger [Mon, 8 Feb 2010 20:20:50 +0000 (15:20 -0500)]
Removing depricated file from the C4::Labels module.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Nighswonger [Mon, 8 Feb 2010 20:15:02 +0000 (15:15 -0500)]
Bringing label, patroncard, and creator modules into conformity with the rest of C4 style.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Mon, 8 Feb 2010 22:36:38 +0000 (17:36 -0500)]
Bug 4142: Fixes XHTML errors in aqbudgetperiod.tmpl.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Mon, 8 Feb 2010 18:25:19 +0000 (18:25 +0000)]
Bug 4140 label edit template links to non-existent script
changed link to point at labels script
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Fri, 5 Feb 2010 12:44:46 +0000 (07:44 -0500)]
bug 3738 add preferences to new sys pref interface
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Mon, 8 Feb 2010 18:39:58 +0000 (13:39 -0500)]
Merge branch '3.0.x-to-3.2.0' of /home/koha/koha1/dev into to-push
Forward-porting 3.0.x release notes.
* '3.0.x-to-3.2.0' of /home/koha/koha1/dev:
forward-port rest of changes to 3.0.1 release notes
Adding a translation note.
Adding release notes for 3.0.1
minor update on release notes
Henri-Damien Laurent's release notes and version 3.0.2
Preparing 3.0.3
Updated references to Portuguese translation in Release Notes
Followup release notes
Adding release notes
Update on release notes
Adding 3.0.5 release notes
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Mon, 8 Feb 2010 18:38:01 +0000 (13:38 -0500)]
forward-port rest of changes to 3.0.1 release notes
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Tue, 3 Feb 2009 10:34:37 +0000 (11:34 +0100)]
Adding a translation note.
(cherry picked from commit
bd385c22487b345480ad8021d79c8203f1cecfba)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Mon, 2 Feb 2009 15:30:25 +0000 (16:30 +0100)]
Adding release notes for 3.0.1
Signed-off-by: Henri-Damien LAURENT <henridamien@koha-fr.org>
(cherry picked from commit
7ce704ad98ca3044a93cbd3556e598ed35cfac7e)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Thu, 4 Jun 2009 12:09:39 +0000 (14:09 +0200)]
minor update on release notes
(cherry picked from commit
65ac4e38ab9f1b5dc9ae630071a4ac275cbe78bd)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Mon, 8 Feb 2010 18:32:08 +0000 (13:32 -0500)]
Henri-Damien Laurent's release notes and version 3.0.2
(cherry picked from commit
d010503b803cf1888caf25f6ac150a58b663dc21)
Conflicts:
Makefile.PL
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Fri, 26 Jun 2009 13:57:18 +0000 (15:57 +0200)]
Preparing 3.0.3
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Ricardo Dias Marques [Wed, 21 Oct 2009 16:24:21 +0000 (16:24 +0000)]
Updated references to Portuguese translation in Release Notes
Updated references to Portuguese translation in Release Notes
for the 3.0.4 Release:
- For OPAC, removed pt-PT from the list of Partial translations
(because it already correctly appears in the list of complete ones)
- For Staff client, added pt-PT to the list of Partial translations
(cherry picked from commit
f4eb63c7284625f3e16f741726f23fc44ec63e16)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Wed, 21 Oct 2009 13:47:00 +0000 (15:47 +0200)]
Followup release notes
list involved in release notes for koha-devel were wrong
Thanks ricardo
(cherry picked from commit
0521828140af11fa6c54fef3e55e1d4ab4b11496)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Tue, 20 Oct 2009 12:44:21 +0000 (14:44 +0200)]
Adding release notes
(cherry picked from commit
2eba46985bb67eadf7fe896dbe50df4d995e03a5)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Thu, 17 Dec 2009 08:41:24 +0000 (09:41 +0100)]
Update on release notes
(cherry picked from commit
5983a8c3811c6b5f9ed0192eca3f94f07aa3b006)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Mon, 14 Dec 2009 22:02:56 +0000 (23:02 +0100)]
Adding 3.0.5 release notes
(cherry picked from commit
cbaa3da19f2d4d79139e8c43f8b422c0b3214d29)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Mon, 8 Feb 2010 17:46:44 +0000 (12:46 -0500)]
Revert "overdue performance restored (INCOMPLETE FIX)"
Reverted because, as it describes itself, this was an incomplete
fix that simply commented out a feature that had been committed to HEAD
and sponsored by a library. Bug 4139 has been opened for the underlying
performance issue.
This reverts commit
943aa38564c7322fcc3534625cf05e1ba3f09d53.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Mon, 8 Feb 2010 16:33:55 +0000 (16:33 +0000)]
Bug 4133 Amend kohastructure to reflect earlier patch
updatedatebase is now setting aqorders.quantityreceived to NOT NULL
kohastructure needs bringing into line
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Mon, 8 Feb 2010 16:17:30 +0000 (16:17 +0000)]
Bug 3810 Mail::Sendmail should not fail silently
The return from Mail::Sendmail should always be checked
Output the error message if it fails so we have some
indication of where to start looking if it fails
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Mon, 8 Feb 2010 16:08:57 +0000 (11:08 -0500)]
Fix for Bug 4093, OPAC Suggestions List has extra column
- This code was added to opac-suggestions.pl at one point by
Garry Collum and was subsequently removed. Adding it back.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Nighswonger [Mon, 8 Feb 2010 16:01:55 +0000 (11:01 -0500)]
Bugfix: Fixing issues with the patron card pdf rendering code
This patch fixes two bugs:
1. Correcting the text alignment alogrithms for center and right alignment
2. Changes a reference to layout to a copy of the layout to avoid performing
operations on the layout.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Mon, 8 Feb 2010 15:39:46 +0000 (15:39 +0000)]
Bug 4133 Ensure that orders have a valid quantity received
quantityreceived drives other parts of acq noticeably budget balances
ensure that a number (usually 0) is set in NewOrder
give field a valid default and set as not null
reinterpret exsting nulls in table as zero
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Fri, 25 Dec 2009 02:35:43 +0000 (21:35 -0500)]
Fix for Bug 2869, 'do not delete' marc framework tag - reverts to 'default' framework
- "Do not delete" form was missing hidden framework code input.
- Also added details to breadcrumb navigation
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Mon, 8 Feb 2010 15:18:16 +0000 (10:18 -0500)]
Fix for Bug 4136, Invalid XHTML in spinelabel-print view
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Mon, 8 Feb 2010 15:02:09 +0000 (10:02 -0500)]
Markup error, closing tag missing
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Fri, 9 Oct 2009 14:32:46 +0000 (15:32 +0100)]
Bug 3697 Return due date (SIP Field AH) in item info
Although the due date of an on loan item was being retrieved
the appropriate field in the Item object was not set
causing the due date not to be returned in the item
information response
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Fri, 20 Nov 2009 19:41:08 +0000 (19:41 +0000)]
Cleanup date handling in routing.pl
Remove dead code
Clarify the loop assigning dates
Remove the cause of undef warnings in the log
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Wed, 2 Dec 2009 13:13:58 +0000 (13:13 +0000)]
Add dependency Authen::CAS::Client
Required CPAN module was missing from deoendency list
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Tue, 5 Jan 2010 17:35:56 +0000 (17:35 +0000)]
Fix count in supplier dropdown in serials/claims.pl
Previous patch still used old variable name to get count causing
incorrect value to be returned
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Thu, 14 Jan 2010 16:15:56 +0000 (16:15 +0000)]
Correct misleading text
Some koha acq terminology is confusing to new users so lets at least
be consistent in our usages we are adding to the basket here not an order
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Mon, 8 Feb 2010 14:14:41 +0000 (09:14 -0500)]
bug 2576 - fix XHTML validation errors generated by previous commit
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Jane Wagner [Thu, 22 Oct 2009 15:21:21 +0000 (11:21 -0400)]
Bug 2576 reopened -- turn off fines elsewhere in OPAC account
The original patch allowed use of the OPACFinesTab syspref to turn off
the Fines tab in the OPAC patron record. However, a column for fines
still appears in the listing of overdues, and as a tab on the line with
Overdues, Holds, Fines, etc. This patch turns off the other instances of
fine columns/displays if the syspref is off.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Mon, 8 Feb 2010 14:01:25 +0000 (09:01 -0500)]
set koha_login_context in order to get auto-login for SCO working
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Mon, 8 Feb 2010 13:46:21 +0000 (08:46 -0500)]
DB rev 114 - tweak AutoSelfCheckAllowed, AutoSelfCheckID, and AutoShelfCheckPass
* made AutoSelfCheckID and AUtoSelfCheckPass type free instead of textarea
* consolidated DB updates into one
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Jane Wagner [Fri, 30 Oct 2009 13:44:38 +0000 (09:44 -0400)]
Bug 3738 Automate login to web-based self-check system
Some small, single-branch corporate and special libraries use unattended self-checkout stations, and would like to automate the staff login, so that just going to the sco/sco-main.pl URL would bring the self-check up ready for patron use. This patch create three sysprefs, AutoSelfCheckAllowed, and AutoSelfCheckID/AutoSelfCheckPass. If the site wants to allow automated login, staff would then need to create the selfcheck user record and enter that login ID and password into the sysprefs. The kohaclone/opac/sco/sco-main.pl script has been modified to check these sysprefs and pass values (if present and allowed) into the self-check URL. The URL then bypasses the staff login page and comes up ready for checkout, waiting for the first patron barcode.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Frédéric Demians [Sat, 6 Feb 2010 18:17:06 +0000 (19:17 +0100)]
Bug 3920 - Add 2 syspref to activate XSLT use in OPAC/Intranet
- Add two syspref:
- OPACXSLTResultsDisplay
- OPACXSLDetailsDispay
- Add them to .pref files and dispatch them beetween OPAC and Search
tab.
- Upgrade DB version to 3.2 .113
- Fix something wrong in UNIMARCslim2intranetDetail.xsl
- Display OPAC result and detail pages using those syspref.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Matthias Meusburger [Mon, 8 Feb 2010 12:46:32 +0000 (13:46 +0100)]
BZ4104: Removes tagging in staff client
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Tue, 3 Nov 2009 00:58:49 +0000 (19:58 -0500)]
Bug 3752: Fixed XHTML errors in opac-MARCdetail.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Fri, 18 Sep 2009 16:29:57 +0000 (12:29 -0400)]
Bugs 3646 and 2651: Changes the output of compact.xsl from html to xhtml.
Changes the output of compact.xsl to XHTML for catalogue/showmarc.pl?viewas=card.
Adds <title> element in <head>.
Removes link to nonexistent css file (bug 2651).
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Fri, 5 Feb 2010 04:18:01 +0000 (23:18 -0500)]
bug 4129 fix display of html on the overdue report
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Sun, 7 Feb 2010 13:50:15 +0000 (08:50 -0500)]
Bug 3662: Invalid XHTML in update-child.tmpl - resubmission.
Missing </td> closing tag.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Fri, 5 Feb 2010 09:23:33 +0000 (04:23 -0500)]
bug 3923 OrderPdfFormat default was wrong on update
I went back and updated updatedatabase so that anyone else who updates
doesn't end up with the wrong value, this does not fix those who
upgraded and have the wrong value in there already.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Cormack [Sun, 7 Feb 2010 21:49:27 +0000 (10:49 +1300)]
Removing noisy warn in C4/XSLT.pm
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Nighswonger [Mon, 8 Feb 2010 03:06:36 +0000 (22:06 -0500)]
Bugfix: Correcting conditional for branch code check
Also removing needless conditionals on redirects.
Thanks to Braedon Vickers for catching the incorrect conditional.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Mon, 8 Feb 2010 12:20:24 +0000 (12:20 +0000)]
Remove cause of some warnings in order display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Frédéric Demians [Sat, 6 Feb 2010 11:31:11 +0000 (12:31 +0100)]
Bug 4125 - Reformat with perldoc bulkmarcimport.pl doc
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Fri, 5 Feb 2010 17:36:21 +0000 (12:36 -0500)]
Fix for Bug 4113, Failed renewal from circulation screen results in malformed table
Renewal failure message should appear in renewal checkbox column just
like it does in moremember.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Fri, 5 Feb 2010 20:47:34 +0000 (15:47 -0500)]
Bug 4114: Follow-up patch for duplicate id in opac-detail.
Adds the id back in <body>. Renames the id in <div>.
The only reference to this id was in sanop.css, to which opac-detail.tmpl does not link.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Fri, 5 Feb 2010 23:54:47 +0000 (18:54 -0500)]
Bug: 4124 - Submit button in csv-profile.tmpl floats to the right.
Typo - class='actin' should be class='action' in the <form> tag.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Thu, 4 Feb 2010 08:47:22 +0000 (03:47 -0500)]
bugs 3989, 3990, 3996, 3997 - sys prefs resolved
bug 3989 - RoutingSerials & RenewSerialAddsSuggestion
moved to serials tab and descriptions updated
bug 3990 - add RoutingListAddReserves pref to serials tab
bug 3996 - add intranetbookbag pref to staff client tab
but 3997 - add ReservesControlBranch to circulation tab
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Thu, 4 Feb 2010 07:56:18 +0000 (02:56 -0500)]
bug 3993 & 4119 add WebBasedSelfCheck pref to interface
bug 4119 - add WebBasedSelfCheck to sys pref interface
bug 3993 - added quotes around OpacMaintenance description so it appears
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Thu, 4 Feb 2010 07:45:03 +0000 (02:45 -0500)]
bug 4033 add missing OverdueNoticeBcc to the interface
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Thu, 4 Feb 2010 07:36:27 +0000 (02:36 -0500)]
bug 3994 & 3995 add missing OPAC privacy preferences to interface
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Thu, 4 Feb 2010 07:08:31 +0000 (02:08 -0500)]
bug 4087 add missing OpacAddMastheadLibraryPulldown to prefs interface
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Thu, 4 Feb 2010 07:24:16 +0000 (02:24 -0500)]
bug 3986 add CAS preferences to interface
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 5 Feb 2010 13:46:58 +0000 (08:46 -0500)]
added subscription.enddate to kohastructure.sql
kohastructure.sql update missed in DB rev 3.01.00.071
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Fri, 5 Feb 2010 13:08:04 +0000 (13:08 +0000)]
Bug 4117 Fix system error in routing slip recepients popup
order_by parameter should be an arrayref of hashrefs
Have made order surname, firstname asc (see bug 4067)
do not generate logged warnings by manipulating undef
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Thu, 4 Feb 2010 06:57:29 +0000 (01:57 -0500)]
bug 3985 add missing acq preferences
This patch adds AcqCreateItem, CurrencyFormat, gist, and OrderPdfFormat back into the sys prefs interface.
Still missing are acquisitions, OrderPdfTemplate, and emailPurchaseSuggestions.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 5 Feb 2010 13:21:36 +0000 (08:21 -0500)]
corrected POD for GetMember()
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 5 Feb 2010 13:15:04 +0000 (08:15 -0500)]
fixed remaining calls to GetMember() that used old argument style
New way, correct way to use GetMember is
GetMember(field => fieldvalue[, field2 => field2value ...]);
e.g.,
GetMember(borrowernumber => $borrowernumber);
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 5 Feb 2010 13:05:43 +0000 (08:05 -0500)]
removed unconditional warn
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Thu, 4 Feb 2010 18:22:48 +0000 (18:22 +0000)]
Bug 4108 Catch cases when GetMember is generating errors
Fixed two calls where new interface was not used
Arguably new syntax allows more options than we require but it was not catching
error cases (when 0 or undef is passed). It also can now be called in ways
which would validly return multiple hits but explicitly does not
(nor does calling code expect this)
This patch should quieten the flood of errors
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 5 Feb 2010 12:19:46 +0000 (07:19 -0500)]
finished add SpineLabelShowPrintOnBibDetails (DBrev 112)
* improve wording
* add to new system preferences editor
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Kyle M Hall [Mon, 21 Dec 2009 13:12:46 +0000 (13:12 +0000)]
Bug 1248 - Add a "quick spine label" print to the bib item page in cataloging
Turn on the system preference SpineLabelShowPrintOnBibDetails and a link for the spinelabel printer will appear for each item on catalogue/detail.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 5 Feb 2010 11:48:35 +0000 (06:48 -0500)]
added two new intranet directories to installation list
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Nighswonger [Fri, 5 Feb 2010 01:25:28 +0000 (20:25 -0500)]
Bugfix: Fixing a broken link in the patron card layout editor
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Fri, 5 Feb 2010 01:58:12 +0000 (20:58 -0500)]
Bug 4114: Fixes duplicate id definition in opac-detail.tmpl
Removes "id=opac-detail" from <body> tag.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Nighswonger [Fri, 5 Feb 2010 02:37:38 +0000 (21:37 -0500)]
Bugfix: Adding Graphics::Magick module to About Koha page
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Nighswonger [Thu, 4 Feb 2010 19:47:30 +0000 (14:47 -0500)]
Bugfix: Implimentation of JpegBlob and AltJpeg methods
Implimentation of JpegBlob and AltJpeg methods in C4::Creators::PDF
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Sat, 3 Oct 2009 18:11:37 +0000 (14:11 -0400)]
Bug 3691: Invalid XHTML in about.tmpl
Fixes several missing closing html tags.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Nighswonger [Thu, 4 Feb 2010 21:25:31 +0000 (16:25 -0500)]
Bugfix: Correcting hash dereferencing for barcode data
This patch corrects hash dereferencing syntax.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Thu, 4 Feb 2010 16:11:43 +0000 (11:11 -0500)]
Style correction
- Use <div class="dialog alert"> for warnings, not "dialog error"
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Nighswonger [Thu, 4 Feb 2010 17:08:50 +0000 (12:08 -0500)]
Bugfix: Correcting name of help file in Label Creator Tool
The Label Profile Editor help file was mis-named. This patch corrects
the name.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Nighswonger [Thu, 4 Feb 2010 15:20:47 +0000 (10:20 -0500)]
Bugfix: Correcting hash dereferencing for image data
This patch corrects hash dereferencing syntax.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Nighswonger [Thu, 4 Feb 2010 15:20:46 +0000 (10:20 -0500)]
Bugfix: Adding error trapping for missing or invalid branch code
This patch adds code to trap, log, and return an intelligent message to the user
when a missing or invalid branch code is passed in. This condition can occur if
the user is logged in as the kohaadmin or the user has multiple instances of the staff
client open and has switched users in some instance.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Wed, 3 Feb 2010 18:28:37 +0000 (13:28 -0500)]
fix 4066 - add rotating collections to toolbar menu
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Brendan A. Gallagher [Thu, 4 Feb 2010 06:33:13 +0000 (06:33 +0000)]
Follow up Patch for moving the itemtype icons directory from sfdicons to vokal
Sponsered by vokal
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
brendan [Wed, 3 Feb 2010 21:26:26 +0000 (21:26 +0000)]
Changed the folder location for Vokal icons from sdficons to vokal...
These icons where contributed by Vokal
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
brendan [Wed, 3 Feb 2010 22:18:14 +0000 (22:18 +0000)]
Adding the vokal directory for icons
Contributed by VOKAL
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Wed, 3 Feb 2010 20:20:17 +0000 (15:20 -0500)]
More fixes for Bug 2600, HTML tags in titles not escaped in many places
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Wed, 3 Feb 2010 18:48:00 +0000 (13:48 -0500)]
Fixes for Bug 2600, HTML tags in titles not escaped in many places
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Wed, 3 Feb 2010 21:44:24 +0000 (16:44 -0500)]
added intranetbookbag syspref to install scripts
Had been omitted, so wasn't appearing in fresh
installs.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Wed, 3 Feb 2010 21:14:55 +0000 (16:14 -0500)]
bug 4099: fix adding new patron category
Added categories.enrolmentperioddate to kohastructure.sql, which commit
dc9991 had omitted.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Wed, 3 Feb 2010 20:56:19 +0000 (15:56 -0500)]
fix POD errors reported by xt/author/podcorrectness.t
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Wed, 3 Feb 2010 14:45:27 +0000 (14:45 +0000)]
Fix pod markup errors in C4/Budgets.pm
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Wed, 3 Feb 2010 15:43:23 +0000 (10:43 -0500)]
Fixes for Bug 3089, Date entry fields should indicate required date format
- Added include, date-format.inc, which shows format, e.g. "(DD/MM/YYYY)"
- Hint shows expected date format based on system preference
- Removing calendar.inc include from templates which don't use it
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Tue, 2 Feb 2010 07:58:30 +0000 (02:58 -0500)]
remove mysql5.0 errors in patroncard upgrade
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>