]> git.koha-community.org Git - koha.git/log
koha.git
12 years agoBug 8130: Followup: errors must be a hashref
Jonathan Druart [Thu, 19 Jul 2012 11:50:08 +0000 (13:50 +0200)]
Bug 8130: Followup: errors must be a hashref

http://bugs.koha-community.org/show_bug.cgi?id=8130
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
12 years agoBug 8130: [SIGNED-OFF] Followup - Empty file upload error never displays.
Kyle M Hall [Thu, 19 Jul 2012 12:41:39 +0000 (08:41 -0400)]
Bug 8130: [SIGNED-OFF] Followup - Empty file upload error never displays.

http://bugs.koha-community.org/show_bug.cgi?id=8130
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
12 years agoBug 8130 [FOLLOW-UP] attach PDF files to a patron record
Owen Leonard [Tue, 10 Jul 2012 17:56:26 +0000 (13:56 -0400)]
Bug 8130 [FOLLOW-UP] attach PDF files to a patron record

Markup corrections:

- Hide table of files if no files are attached
- Move error messages out of table (invalid)
- Add <tr> tags to table (invalid)
- Apply standard form structure to upload form
- Add proper labels and ids to upload form
- Correct unescaped ampersands

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
12 years agoBug 8130 follow-up, removing duplicate tab
Paul Poulain [Mon, 2 Jul 2012 12:53:25 +0000 (14:53 +0200)]
Bug 8130 follow-up, removing duplicate tab

In bug 7955, http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955#c21, Nicole spotted that the "notices" tab appear twice.

This patch removes the duplicated tab that has been introduced by this feature, probably a rebase mistake

12 years agoBug 8130 follow-up DBRev number
Paul Poulain [Thu, 28 Jun 2012 11:53:50 +0000 (13:53 +0200)]
Bug 8130 follow-up DBRev number

12 years agoBug 8130 - attach PDF files to a patron record
Kyle M Hall [Mon, 21 May 2012 20:42:53 +0000 (16:42 -0400)]
Bug 8130 - attach PDF files to a patron record

Adds the ability to attach unlimited arbitrary files to
a borrower record.

Test Plan:
1) Enable system preference EnableBorrowerFiles
2) Look up borrower record, click 'Files' tab on left
3) Upload a file, download the file, delete the file.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
rebased for current master.

Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
rebased again; some indentation issues in include menus.

12 years agoBug 6939 DefaultClassificationSource should be default in 942
Colin Campbell [Mon, 18 Jun 2012 10:23:42 +0000 (11:23 +0100)]
Bug 6939 DefaultClassificationSource should be default in 942

A logic bug in the original code adding DefaultClassificationSource
caused the default not to be used (the last used value was used instead)
The bug was fixed in additem by bug 2398 but addbiblio's use
of the code was not fixed.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8205 follow-up DBRev number
Paul Poulain [Thu, 28 Jun 2012 07:22:58 +0000 (09:22 +0200)]
Bug 8205 follow-up DBRev number

12 years agoBug 8205: Add OPACShowUnusedAuthorities syspref
Jared Camins-Esakov [Wed, 30 May 2012 21:29:29 +0000 (17:29 -0400)]
Bug 8205: Add OPACShowUnusedAuthorities syspref

Rather than list authorities that are not actually used by a library,
this commit introduces a new syspref: OPACShowUnusedAuthorities to
enable libraries to hide unused authorities in the OPAC authority browser.

To test:
1) Do a search in the OPAC authority browser that brings up multiple
   results, including some that are used in the bibliographic database
   and some that are not.
2) Observe that the results include both used and unused authorities.
3) Set OPACShowUnusedAuthorities to "Do not."
4) Repeat the same search as in step 1.
5) Observe that the results no longer include unused authorities.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Preference is implemented cleanly and works like advertised.
As a note: The unused authority records will be hidden from display,
but the result list paging does not adjust for the hidden records.
So the result pages will show more or less records total, depending
on how many records are hidden.

12 years agoBug 8279: CAS Debugging improvements
Matthias Meusburger [Thu, 21 Jun 2012 08:39:16 +0000 (10:39 +0200)]
Bug 8279: CAS Debugging improvements

  Adds more precise debug informations for easier CAS troubleshootings resolution.

  Before this patch, whenever ticket validation failed, the debug message was "Invalid ticket".
  But ticket validation may fail for other reasons: CAS server not reachable, casServerUrl syspref is wrong...

  This patch adds the reason for ticket validation failing.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8288 - showmarc.tt should not include full doc-head-close.inc
Owen Leonard [Fri, 22 Jun 2012 15:52:32 +0000 (11:52 -0400)]
Bug 8288 - showmarc.tt should not include full doc-head-close.inc

showmarc.tt and opac-showmarc.tt are used to load a plain view
of a MARC record and thus do not need the full set of page assets
loaded with other pages (CSS and JavaScript). Removing the
standard doc-head-close include will reduce the load time of
these pages.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7304 followup DBRev number
Paul Poulain [Wed, 27 Jun 2012 14:56:08 +0000 (16:56 +0200)]
Bug 7304 followup DBRev number

12 years agoBug 7304: More permissions for budgets
Julian Maurice [Fri, 18 May 2012 07:12:43 +0000 (09:12 +0200)]
Bug 7304: More permissions for budgets

- Possibility to add users to a budget
- Restrictions changed to:
  - None
  - Owner
  - Owner and users
  - Owner, users and library
- Restricted users cannot spent on these budgets (they cannot modify them
  either)

Modified pages:
 - admin/aqbudgets.pl
 - admin/aqplan.pl
 - suggestion/suggestion.pl
 - acqui/acqui-home.pl
 - acqui/addorderiso2709.pl
 - acqui/basket.pl
 - acqui/neworderempty.pl

Unit tests in t/Budgets/CanUserUseBudget.t and t/Budgets/CanUserModifyBudget.t

Bug 7304 tmp

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7905: Follow up - Multi-line subscription notes
Katrin Fischer [Sat, 16 Jun 2012 12:18:36 +0000 (14:18 +0200)]
Bug 7905: Follow up - Multi-line subscription notes

This patch adds the TT filter to other places where we are displaying the
subscription notes:

- OPAC detail page, subscription tab
- OPAC subscription brief history page
- Staff detail page, subscription tab

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7905: display serial notes on several lines
Adrien Saurat [Thu, 5 Apr 2012 14:43:08 +0000 (16:43 +0200)]
Bug 7905: display serial notes on several lines

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch works and makes use of TT filters!

I agree the display could be improved to work a bit nicer
for long lines or multi-line comments, but this is still a nice
improvement.

12 years agoBug 5345: DataTables integration in acquisition module [5]
Jonathan Druart [Fri, 17 Feb 2012 14:56:30 +0000 (15:56 +0100)]
Bug 5345: DataTables integration in acquisition module [5]

basketgroup.tt

http://bugs.koha-community.org/show_bug.cgi?id=8105
Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8181 [REVISED] Replace DynArch calendar widget with jQueryUI version
Owen Leonard [Tue, 24 Apr 2012 14:49:15 +0000 (10:49 -0400)]
Bug 8181 [REVISED] Replace DynArch calendar widget with jQueryUI version

All instances of the old DynArch calendar have been replaced with
jQueryUI versions and the old library files have been removed.

calendar.inc has been modified to include jQueryUI localization
strings and global configuration options. Just add a "datepicker"
class to an input field to trigger a datepicker prompt.

If you would like two fields in one from to limit each other (one
is date from, one is date to), add these classes to each:
"datepickerfrom" and "datepickerto." This will prevent an invalid
entry, e.g. a date in the latter which falls before the former.

jQueryUI is now upgraded to the latest verision, 1.8.21.

Edit: Now with proper translatability, date formatting, first day
of the week handling, and RTL support.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
QA Comment:  rebased on current master; minor merge conflicts with other patches pushed

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8191 : Adding a new value to 8 position of coded data field 100
Sophie Meynieux [Tue, 5 Jun 2012 15:44:25 +0000 (17:44 +0200)]
Bug 8191 : Adding a new value to 8 position of coded data field 100

From july 2012, unimarc norm evolves and the value k "monograph with both publication date and print date" must be added for this position.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Checked the new value shows up and is correctly copied into the field.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8255: allow local cover images to be cached
Jared Camins-Esakov [Fri, 15 Jun 2012 17:59:55 +0000 (13:59 -0400)]
Bug 8255: allow local cover images to be cached

At the moment, local cover images cannot be cached by the web browser
or any intermediate reverse proxies. This results in an unnecessary
load on the server, and is entirely unnecessary.

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7143'
Paul Poulain [Mon, 25 Jun 2012 16:01:28 +0000 (18:01 +0200)]
Merge remote-tracking branch 'origin/new/bug_7143'

12 years ago7143 Followup for timeline
Marcel de Rooy [Thu, 21 Jun 2012 09:01:15 +0000 (11:01 +0200)]
7143 Followup for timeline

Fixes few tabs within date; adds a regex to fix mistakes with spaces.

Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7368 - General staff client typo omnibus
Marc Veron [Mon, 25 Jun 2012 07:59:36 +0000 (09:59 +0200)]
Bug 7368 - General staff client typo omnibus

Corrects 2 typos, see comment #9

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6090: Do not enqueue empty messages
Julian Maurice [Thu, 8 Mar 2012 12:50:47 +0000 (13:50 +0100)]
Bug 6090: Do not enqueue empty messages

This patch avoid enqueuing messages that have an empty body. It can
happen when letter is empty or becomes empty after being processed by
parseletter

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8194 - Layout problem on subscription add when showing manual history
Owen Leonard [Fri, 15 Jun 2012 14:36:33 +0000 (10:36 -0400)]
Bug 8194 - Layout problem on subscription add when showing manual history

Markup errors were causing display problems when the "manual history"
section is shown.

To test, apply the patch, load the subscription add page, and check
the "manual history" checkbox. The "Serials planning" section
should appear directly below the "manual history" section.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7379: display of copy number description (AV)
Adrien Saurat [Sat, 9 Jun 2012 14:44:28 +0000 (15:44 +0100)]
Bug 7379: display of copy number description (AV)

The biblio/items detail pages (staff and OPAC) display
the copynumber description if an authorized value
is configured accordingly.

Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8224 - Make authorized values appear in planning list
Alex Arnaud [Mon, 11 Jun 2012 08:58:24 +0000 (10:58 +0200)]
Bug 8224 - Make authorized values appear in planning list

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I can confirm the bugs on current master and this patch fixes both problems.

- Pull down list for "Planning" on the budget page was not showing
  categories of authorized values
- Planning page showed the categories, but budget_period_id was
  missing from the URL

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8241: Remove text fragment from Z39.50-Server search
Katrin Fischer [Sun, 17 Jun 2012 05:41:25 +0000 (07:41 +0200)]
Bug 8241: Remove text fragment from Z39.50-Server search

Removes an accidently added "curr" from below the search options
for administration > Z39.50 client targets.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8241 - Remove stray references to YUI autocomplete
Owen Leonard [Tue, 12 Jun 2012 13:46:12 +0000 (09:46 -0400)]
Bug 8241 - Remove stray references to YUI autocomplete

- Removing unused references to YUI assets in authorities/auth_finder.tt
- Removing unneeded call to autocomplete JS in help-top.inc and
  adding new jQuery dependencies.
- Minor HTML markup corrections to auth-finder-search.inc discovered
  in debugging the patch.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested:
- help files on various pages
- auth finder plugin in cataloguing
- authority search in authorities module

12 years agoBug 8282: Bug in modules list in about.pl
Matthias Meusburger [Thu, 21 Jun 2012 13:41:54 +0000 (15:41 +0200)]
Bug 8282: Bug in modules list in about.pl

  Last modules were not displayed if the number of modules did not match the number of rows of the table (when $number_of_modules % 4 != 0)

Signed-off-by: Marc Veron <veron@veron.ch>
Added some code to about.tt to have empty the last remaining cells, not sure if an other signoff is needed.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8289 Upgrading from 2.2 does not work anymore
Paul Poulain [Fri, 22 Jun 2012 09:10:18 +0000 (11:10 +0200)]
Bug 8289 Upgrading from 2.2 does not work anymore

The updatedatabase22to30.pl script update the engine from MyISAM to InnoDB for most tables.

However, the TYPE=InnoDB was deprecated, and is not removed.
The correct syntax is now ENGINE=InnoDB

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
12 years agoBug 8272 - OPAC : date expiration format
Owen Leonard [Tue, 19 Jun 2012 17:08:28 +0000 (13:08 -0400)]
Bug 8272 - OPAC : date expiration format

Adding TT date filter to output of expiration date
on OPAC user page.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8043 - today's checkouts are in Previous checkouts in circulation.pl
Kyle M Hall [Thu, 14 Jun 2012 10:33:51 +0000 (06:33 -0400)]
Bug 8043 - today's checkouts are in Previous checkouts in circulation.pl

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8251 - Patrons get incorrectly debarred
Tomas Cohen Arazi [Fri, 15 Jun 2012 17:51:42 +0000 (14:51 -0300)]
Bug 8251 - Patrons get incorrectly debarred

Patrons get incorrectly debarred because of the use of Datetime->delta_days
wich happens to always return a positive number.

Also changed the use of Datetime->truncate function so it follows the docs,
using 'day' instead of 'days' (which is used in DateTime::Duration).

This patch has been tested against master.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8154: The export today's checked in barcodes generated file is always empty
Jonathan Druart [Mon, 18 Jun 2012 08:19:12 +0000 (10:19 +0200)]
Bug 8154: The export today's checked in barcodes generated file is always empty

Comparation of date and datetime is always false

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Exported file contains the list of checked in items.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8267 - Overdue notices not working
Kyle M Hall [Mon, 18 Jun 2012 14:08:23 +0000 (10:08 -0400)]
Bug 8267 - Overdue notices not working

The variable $i was being re-used and overwriting the necessary value that was being passed to a subroutine. Renaming $i to $j fixed it. I also added an extra safety check within parse_letter that would also have prevented this bug.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 3708 follow-up DBRev number
Paul Poulain [Wed, 20 Jun 2012 21:11:20 +0000 (23:11 +0200)]
Bug 3708 follow-up DBRev number

12 years agoBug 3708 - Add another customizable region to the OPAC: right sidebar nav
Paul Poulain [Wed, 20 Jun 2012 21:11:06 +0000 (23:11 +0200)]
Bug 3708 - Add another customizable region to the OPAC: right sidebar nav

This patch creates a new system preference, OpacNavRight, in
which the librarian can add HTML which will appear on the OPAC
main page under the login form. If the user is logged in the content
will appear in place of the login form.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 4255 - Add item type to facet list
Meenakshi.R [Wed, 30 May 2012 10:36:33 +0000 (16:06 +0530)]
Bug 4255 - Add item type to facet list

This is for MARC 21 only.

Made following changed:

- In getFacets in C4/Koha.pm added item type facet for 952y and 942c
- In getRecords in C4:Search.pm added code to get description of itemtype codes
- facets.inc in both staff and opac to show item types related label in the facets block

To test:

Add records such that a certain itype (say BK) is present in both 942c and 952y in two DIFFERENT records.

Run a search where both test records are present. Test to see if itype types are presented in the facets block (both OPAC and staff).

Click on the itype (say BK), both the test records should appear in the refined results. This shows that the feature works for both 942c and 952y.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
QA Comment: fixed capitalization in template includes according to HTML4 coding
guideline ("Item types" instead of "ItemTypes")

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5910: [SIGNED-OFF] only add "All authority types" for UNIMARC
Jared Camins-Esakov [Sun, 10 Jun 2012 14:16:16 +0000 (10:16 -0400)]
Bug 5910: [SIGNED-OFF] only add "All authority types" for UNIMARC

UNIMARC is the only marcflavour that does not already have an option
for searching all authority types, so check that the marcflavour is
UNIMARC before displaying the additional "All authority types" option.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5910: allow users to search on all auth types
Paul Poulain [Tue, 9 Aug 2011 14:50:50 +0000 (16:50 +0200)]
Bug 5910: allow users to search on all auth types

Add search on "all authorities types" option in the authorities type select

rewritten for T::T

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_6634'
Paul Poulain [Wed, 20 Jun 2012 20:19:06 +0000 (22:19 +0200)]
Merge remote-tracking branch 'origin/new/bug_6634'

12 years agobug 6634 : 3 more cases of manager_id not populated
Maxime Pelletier [Wed, 28 Mar 2012 21:26:01 +0000 (17:26 -0400)]
bug 6634 : 3 more cases of manager_id not populated

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6774 follow-up DBRev number
Paul Poulain [Wed, 20 Jun 2012 20:04:51 +0000 (22:04 +0200)]
Bug 6774 follow-up DBRev number

12 years agoBug 6774 Display barcode on OPAC detail page(Correcting Typo).
Amit Gupta [Fri, 7 Oct 2011 05:27:24 +0000 (10:57 +0530)]
Bug 6774 Display barcode on OPAC detail page(Correcting Typo).

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Rebased to current master, works in my tests, but needs another set of eyes.
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
12 years agoBug 7447 allow to specify a date in overdue_notice.pl
Paul Poulain [Mon, 16 Jan 2012 16:19:26 +0000 (17:19 +0100)]
Bug 7447 allow to specify a date in overdue_notice.pl

This patch add a new parameter to overdue_notices.pl, that is a date.
If you add --date=YYYY-MM-DD when running overdue_notices, it will generate overdues as if you were on date provided

that's usefull if you want to relaunch an overdue calculation that has failed, of after changing your circ rules

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoAdding Claire Hernandez as contributor + adding missing contributors in about.tt
Paul Poulain [Wed, 20 Jun 2012 19:49:40 +0000 (21:49 +0200)]
Adding Claire Hernandez as contributor + adding missing contributors in about.tt

12 years agoBug 7642 - remove the cloud weight from the tags
Robin Sheat [Sun, 10 Jun 2012 13:32:56 +0000 (14:32 +0100)]
Bug 7642 - remove the cloud weight from the tags

Signed-off-by: Stacey Walker <stacey@catalyst-eu.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7857 - [SIGNED-OFF] database upgrade fails with plack
Dobrica Pavlinusic [Mon, 18 Jun 2012 08:32:00 +0000 (10:32 +0200)]
Bug 7857 - [SIGNED-OFF] database upgrade fails with plack

This patch fixes PERL5LIB path injection to include installer dir
which is required

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7857 - database upgrade fails with plack
Dobrica Pavlinusic [Fri, 30 Mar 2012 20:03:20 +0000 (22:03 +0200)]
Bug 7857 - database upgrade fails with plack

Updating database structure

Update errors :

    Can't locate C4/Context.pm in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl /usr/local/lib/perl/5.10.0 /usr/local/share/perl/5.10.0 .) at /srv/koha/installer/data/mysql/updatedatabase.pl line 37.
    BEGIN failed--compilation aborted at /srv/koha/installer/data/mysql/updatedatabase.pl line 37.

It seems that plack cleans enviroment, so we have to re-instart PERL5LIB
so script invocation won't fail.

It also fixes exit 1 which fail with plack.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7857 - invalidate cached preferences after SetVersion
Dobrica Pavlinusic [Thu, 5 Apr 2012 12:15:30 +0000 (14:15 +0200)]
Bug 7857 - invalidate cached preferences after SetVersion

This allows plack to correctly move to login page after database upgrade

12 years agoBug 7955 follow-up spelling fixes
Paul Poulain [Wed, 20 Jun 2012 19:31:43 +0000 (21:31 +0200)]
Bug 7955 follow-up spelling fixes

* removing useless upper cases
* s/precedent/previous/ and s/Actual/Current/ to be consistent with other Koha pages

12 years agoBug 7955 follow-up DBRev number
Paul Poulain [Wed, 20 Jun 2012 19:30:54 +0000 (21:30 +0200)]
Bug 7955 follow-up DBRev number

12 years agoBug 7955: Statistics tab for Patron checkouts
Jonathan Druart [Fri, 13 Apr 2012 14:21:32 +0000 (16:21 +0200)]
Bug 7955: Statistics tab for Patron checkouts

This patch adds a new 'statistics' tab in the Patron module.
For a borrower, this tab contains a table with:
- number of checkout for today
- number of checkin for today
- "precedent state", the number of checkouts the patron had yesterday on
  its library card
- "actual state", the number of checkouts on the borrower card at the current date

A new syspref (StatisticsFields) contains a list of fields (separated by
pipe (|) on which the table results is based. The default value is
location|itype|ccode

Signed-off-by: Mathilde Formery <mathilde.formery@ville-nimes.fr>
12 years agoBug 7994: Fix pref yaml errors
Claire Hernandez [Mon, 11 Jun 2012 13:52:10 +0000 (15:52 +0200)]
Bug 7994: Fix pref yaml errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7994: scripts to check yaml files
Claire Hernandez [Mon, 23 Apr 2012 13:11:46 +0000 (15:11 +0200)]
Bug 7994: scripts to check yaml files

$ prove yaml_valid.t
checks a closed list of files
$ perl yaml_valid.pl -f myfile.yaml
try to load a yaml file with YAML::LoadFile and show errors

(both files pertidied)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
12 years agoBug 8006 - Loading offline circulation does not anonymize
Kyle M Hall [Wed, 25 Apr 2012 12:44:50 +0000 (08:44 -0400)]
Bug 8006 - Loading offline circulation does not anonymize

Simple, one line fix. Added the privacy parameter to the list
of parameters passed to C4::Circulation::MarkIssueReturned.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug : DataTables integration in acquisition module [1]
Jonathan Druart [Thu, 7 Jun 2012 10:45:05 +0000 (12:45 +0200)]
Bug : DataTables integration in acquisition module [1]

parcel.tt

http://bugs.koha-community.org/show_bug.cgi?id=8098
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed bug number.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8099: DataTables integration in acquisition module [2]
Jonathan Druart [Fri, 17 Feb 2012 14:55:18 +0000 (15:55 +0100)]
Bug 8099: DataTables integration in acquisition module [2]

acqui-home.tt

http://bugs.koha-community.org/show_bug.cgi?id=8099
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8100: DataTables integration in acquisition module [8]
Jonathan Druart [Fri, 25 May 2012 14:37:42 +0000 (16:37 +0200)]
Bug 8100: DataTables integration in acquisition module [8]

neworderbiblio.tt

http://bugs.koha-community.org/show_bug.cgi?id=8100

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed bug number.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8102: DataTables integration in acquisition module [14]
Jonathan Druart [Fri, 25 May 2012 14:27:40 +0000 (16:27 +0200)]
Bug 8102: DataTables integration in acquisition module [14]

supplier.tt

http://bugs.koha-community.org/show_bug.cgi?id=8102
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Corrected bug number.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5345: DataTables integration in acquisition module [12]
Jonathan Druart [Fri, 17 Feb 2012 14:58:54 +0000 (15:58 +0100)]
Bug 5345: DataTables integration in acquisition module [12]

parcels.tt

http://bugs.koha-community.org/show_bug.cgi?id=8103
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5345: DataTables integration in acquisition module [7]
Jonathan Druart [Fri, 17 Feb 2012 14:57:13 +0000 (15:57 +0100)]
Bug 5345: DataTables integration in acquisition module [7]

lateorders.tt

http://bugs.koha-community.org/show_bug.cgi?id=8104
Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8152: Clicking cancel link on edit suggestion redirect to the suggestions list
Jonathan Druart [Fri, 25 May 2012 09:29:23 +0000 (11:29 +0200)]
Bug 8152: Clicking cancel link on edit suggestion redirect to the suggestions list

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8180 - cataloguing/additem.pl plack scoping
Dobrica Pavlinusic [Fri, 1 Jun 2012 14:19:38 +0000 (16:19 +0200)]
Bug 8180 - cataloguing/additem.pl plack scoping

$dbh needs our scoping when using "Add item" to prevent error
Can't call method "prepare" on an undefined value at /srv/koha/cataloguing/additem.pl line 88.

Test scenario:

1. start intranet with plack
2. select one Edit items on one record
3. fill in new item and click on "Add item"

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8183 - acqui/parcels.pl plack scoping
Dobrica Pavlinusic [Fri, 1 Jun 2012 18:42:52 +0000 (20:42 +0200)]
Bug 8183 - acqui/parcels.pl plack scoping

Scope our $template for plack to prevent following error:

Can't call method "param" on an undefined value at /srv/koha_ffzg/acqui/parcels.pl line 177.

Test scenario:

1. Home > Acquisitions > Search for vendor
2. click on "Receive shipment"

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8216: Allow SIP modules to pass critic tests
Colin Campbell [Sat, 9 Jun 2012 09:40:19 +0000 (10:40 +0100)]
Bug 8216: Allow SIP modules to pass critic tests

Add C4/SIP to perlcritic tests. Fix those issues that were
generating perlcritic errors

Signed-off-by: Stacey Walker <stacey@catalyst-eu.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8223 - Properly format SQL query in C4::Bookseller::GetBookSeller
Kyle M Hall [Mon, 11 Jun 2012 08:45:57 +0000 (04:45 -0400)]
Bug 8223 - Properly format SQL query in C4::Bookseller::GetBookSeller

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8229: Tabs in marc subfield structure is not shown correctly
Matthias Meusburger [Mon, 11 Jun 2012 13:24:00 +0000 (14:24 +0100)]
Bug 8229: Tabs in marc subfield structure is not shown correctly

  - Fixed URLs in marc_subfields_structure.tt

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8232: Comments in OPAC contain untranslatable javascript messages
Katrin Fischer [Mon, 11 Jun 2012 14:09:00 +0000 (15:09 +0100)]
Bug 8232: Comments in OPAC contain untranslatable javascript messages

To test:
- add a new comment to a record in the OPAC
- Your comment (preview, pending approval) is not translatable
- update po files by running 'perl translate update <language>'
- Open po file and check if strings are there, translate
- install language again by running 'perl translate install <language>'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7367 Followup for opac-suggestions template
Marcel de Rooy [Thu, 14 Jun 2012 06:31:46 +0000 (08:31 +0200)]
Bug 7367 Followup for opac-suggestions template

This small typo was found by Albert Oller.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Very trivial fix.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years ago7368 Followup for history.txt Only correcting whitespace for correct placement in...
Marcel de Rooy [Mon, 11 Jun 2012 12:18:02 +0000 (14:18 +0200)]
7368 Followup for history.txt Only correcting whitespace for correct placement in about form

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Very trivial.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8222 - make the zipcode no longer mandatory
Robin Sheat [Sun, 10 Jun 2012 14:56:21 +0000 (15:56 +0100)]
Bug 8222 - make the zipcode no longer mandatory

Having the zipcode field mandatory by default is a bit annoying for
places where no one cares about it. This patch stops it being the case
on new installs.

Signed-off-by: Michael Davis <m.r.davis@cranfield.ac.uk>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agopatch for Bug 8226 - 'OpacFooter' markup/css improvements
Mason James [Mon, 11 Jun 2012 04:40:04 +0000 (16:40 +1200)]
patch for Bug 8226 - 'OpacFooter' markup/css improvements

Signed-off-by: Michael Davis <m.r.davis@cranfield.ac.uk>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8227 Fix deprecated construct compile time warning in Serials
Colin Campbell [Mon, 11 Jun 2012 10:32:58 +0000 (11:32 +0100)]
Bug 8227 Fix deprecated construct compile time warning in Serials

The perl parser no longer fools itself into sometimes thinking
qw( ... ) is a ( qw( ... )) this adds the required parentheses
for the foreach expression silencing the compile time warning

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6720: show authority type in auth details
Jared Camins-Esakov [Fri, 15 Jun 2012 14:40:59 +0000 (10:40 -0400)]
Bug 6720: show authority type in auth details

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Authority type on detail page in staff now shows correctly.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7129: Added a sprintf to format the actual cost.
Aleksa Vujicic [Thu, 19 Jan 2012 02:37:06 +0000 (15:37 +1300)]
Bug 7129: Added a sprintf to format the actual cost.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Rebased to current master, please test.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
QA note: changed call to use $order instead of @$results[0], for consistency
with surrounding variables

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7943 follow-up: Fix template filename
Jared Camins-Esakov [Fri, 15 Jun 2012 14:07:22 +0000 (10:07 -0400)]
Bug 7943 follow-up: Fix template filename

In preparation for some later work on authorities, the filename for the
OPAC authority viewer changed.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7943: Authority search results are untranslatable
Jared Camins-Esakov [Wed, 30 May 2012 19:20:40 +0000 (15:20 -0400)]
Bug 7943: Authority search results are untranslatable

The HTML for authority search results was previously generated in
C4::AuthoritiesMarc::BuildSummary, which meant that it couldn't be
translated. This patch moves the HTML generation into the templates
by introducing a new authorities-search-results.inc include file for
both the OPAC and the Intranet which contains a Template::Toolkit BLOCK
for rendering the authority results. Fixes the authority autocomplete
by removing the untranslatable strings, and returning only data from
the database.

To test:
1. Apply patch.
2. Test authority searching in the authority module in the staff client
3. Test authority searching in the authority control plugin in the
   cataloguing module (and the plugin for UNIMARC field 210$c, if you
   can figure out how)
4. Test authority searching in the OPAC

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested with MARC21 data.

1) Applies cleanly on current HEAD.

2) Authority search in staff

Patch works wonderfully, only some small notes found while testing that have
not been changed by this patch:

ENH note: Search terms show up nowhere. So if I want to change the sorting, I have to
repeat typing in my search term. Even if the form does not keep the term, it
should be visible somewhere on the screen what I searched for.

ENH note: The pagination on top and at the bottom of the result list are formatted
differently. Maybe some missing CSS?

ENH note: Also the authority type is not shown at all in the result list.

3) Cataloguing and authority plugins

The autocomplete function works nicely.

ENH note: There is only one small enhancement
I could imagine. If I start my search from 100 it will limit the search to
'persons' but the autocomplete will also suggest other authorities. It would
be a bit cleaner, if the autocomplete could limit by the appropriate authority
type too. Very nice feature.

Plugins overall work nicely. Created links include the authority numbers and work
correctly.

4) Authority search in OPAC

Works nicely. Display is consistent, but translatability greatly improved.

ENH note: In staff we use 'Details' in OPAC we use 'View full heading' - I wonder
if maybe 'details' would be better understandable for users?

Note: Code reveals a system preference 'AuthDisplayHierarchy' that is
not available in the system preference editor. I talked to Jared and he
will work on this feature later on. For now it's no regression, as the
preference has never been visible.

12 years agoBug 7961 - Local cover images should support CSV link files
Dobrica Pavlinusic [Sat, 14 Apr 2012 09:39:20 +0000 (11:39 +0200)]
Bug 7961 - Local cover images should support CSV link files

Corrent code doesn't have support for filenames which contain spaces
or commans which breaks CSV files saved from spreadsheet similar to:

  12345, "conver image, with spaces.jpg"

This patch tweaks file parsing a bit. We are always splitting line to
only two values (to support commas as part of filename) and removing
spaces only on beginning and end of filename (to cover space after
comma in CSV example above while preserving spaces in filename).

With this change only invalid character in picture filename left
are quotes (") which are commonly used to quote strings with spaces.

Covers added will be logged in action_log, using CATALOGUING / MODIFY
action (which is shown as "Catalog" in tools > Log viewer)

Test scenario:

1. collect pictures with spaces and commas in name
2. dump file list into CSV file and add biblio number as first column
   (name of file is idlink.txt or datalink.txt)
3. create zip with CSV file and pictures
4. verify that all pictures got uploaded and linked to biblio records
5. verify that modification log includes cover image name

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8136 Changes the expected lenght of 100$a in rebuild_zebra.pl
christophe croullebois [Tue, 22 May 2012 11:59:33 +0000 (13:59 +0200)]
Bug 8136 Changes the expected lenght of 100$a in rebuild_zebra.pl

In rebuild_zebra.pl, if we are in "unimarc" ("marcflavour" syspref), the sub "fix_unimarc_100" is called and checks if 100$a lenght is equal to 35.
If it is not the case, the sub inserts the localtime and more, so we loose the datas in reindexing.
The standart lenght is 36.
I have just changed 35 to 36.

Signed-off-by: Sophie Meynieux <sophie.meynieux@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch...
Sophie Meynieux [Sun, 10 Jun 2012 15:01:26 +0000 (17:01 +0200)]
Bug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch table, if items are not deleted because they are issued.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
http://bugs.koha-community.org/show_bug.cgi?id=7318

12 years agoBug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch...
Sophie Meynieux [Sun, 10 Jun 2012 10:23:20 +0000 (12:23 +0200)]
Bug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch table, if items are not deleted beacause on loan.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 7329: Items onloan are deleted when undoing import into catalog
Christophe Croullebois [Wed, 7 Dec 2011 10:54:29 +0000 (11:54 +0100)]
Bug 7329: Items onloan are deleted when undoing import into catalog

this patch checks the "on loan" and "reserved" status before deleting item, and
do noting in this case, so the record can't be deleted due to existing item.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 8247 - adding basket doesn't save basket name, internal or vendor note
Dobrica Pavlinusic [Thu, 14 Jun 2012 15:17:52 +0000 (17:17 +0200)]
Bug 8247 - adding basket doesn't save basket name, internal or vendor note

URL: /cgi-bin/koha/acqui/basketheader.pl?booksellerid=32&op=add_form

I'm also getting mysql referential integrity error:

DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_srvgit`.`aqbasket`, CONSTRAINT `aqbasket_ibfk_1` FOREIGN KEY (`booksellerid`) REFERENCES `aqbooksellers` (`id`) ON UPDATE CASCADE) at /srv/koha/C4/Acquisition.pm line 416.

Test scenario:

1. Find vendor and select "New basket"
2. fill in basket name, internal and vendor note
3. press save
4. verify that created basket doesn't have name nor internal or vendor notes

Signed-off-by: Marc Veron <veron@veron.ch>
First tested without patch applied, new basket's name and internal / vendor notes were empty-
Applied patch, new basket's name and notes behave OK.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_8092'
Paul Poulain [Thu, 14 Jun 2012 15:57:09 +0000 (17:57 +0200)]
Merge remote-tracking branch 'origin/new/bug_8092'

12 years agoBug 8092 follow-up: Fix perlcritic violations
Jared Camins-Esakov [Thu, 14 Jun 2012 15:24:27 +0000 (11:24 -0400)]
Bug 8092 follow-up: Fix perlcritic violations

Apparently you are not supposed to use "return undef;" or perlcritic
gets mad. Sorry, perlcritic!

12 years agoMerge remote-tracking branch 'origin/new/bug_7952'
Paul Poulain [Thu, 14 Jun 2012 13:56:29 +0000 (15:56 +0200)]
Merge remote-tracking branch 'origin/new/bug_7952'

12 years agoBug 7952 - followup to fix t/Creators.t
Dobrica Pavlinusic [Thu, 14 Jun 2012 12:00:16 +0000 (14:00 +0200)]
Bug 7952 - followup to fix t/Creators.t

Since we are now using temporary file, we are creating test.pdf
at end of test and checking if it exists and have non-zero size.

12 years agoMerge remote-tracking branch 'origin/new/bug_5337'
Paul Poulain [Thu, 14 Jun 2012 13:44:22 +0000 (15:44 +0200)]
Merge remote-tracking branch 'origin/new/bug_5337'

12 years agoBug 5337 : Upping the count of the unit tests
Chris Cormack [Tue, 12 Jun 2012 06:37:37 +0000 (18:37 +1200)]
Bug 5337 : Upping the count of the unit tests

12 years agoBug 7952 - PDF::Reuse under plack writes to console STDOUT instead to browser
Dobrica Pavlinusic [Thu, 12 Apr 2012 22:20:00 +0000 (00:20 +0200)]
Bug 7952 - PDF::Reuse under plack writes to console STDOUT instead to browser

Without name option to prFile, PDF::Reuse opens '-' file which is real
console STDOUT on plack so pdf file gets emited to terminal instead of
sending it to browser.

This change creates temporary file using File::Temp, pass it to PDF::Reuse
and then reads it back and prints it out for plack (or CGI) to pick up.

Test secenario:

1. Home › Tools › Patron Card Creator › Manage Card Batches
2. select batch checkbox and click Export
3. select template and click Export
4. click on pdf file to download it

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7810 - C4/Auth.pm - on plack restart session is undefined
Dobrica Pavlinusic [Fri, 23 Mar 2012 08:54:25 +0000 (09:54 +0100)]
Bug 7810 - C4/Auth.pm - on plack restart session is undefined

So we shouldn't try to delete it. This produces application error
instead of redirection to login page.

I had similar problems with CGI, especially when session in browser
is still active, and one on filesystem or database is already expired.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Solved the problem when my Plack installation started acting up due to
stale cookies.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7444: Update circ/circulation.pl to use KohaDates TT Plugin
Ian Walls [Fri, 9 Mar 2012 18:55:38 +0000 (13:55 -0500)]
Bug 7444: Update circ/circulation.pl to use KohaDates TT Plugin

Removes all date formatting done in circ/circulation, and sets any/all date
outputs to iso format.  The formatting of dates is now handled in the template
using the KohaDates plugin.

This allows use to remove a dependency on C4/Dates.pm from the script.

This patch also removes the usage of C4/Overdues/CheckBorrowerDebarred.  Since
borrowers.debarred is returned by GetMemberDetails, it doesn't make sense to
include another module to run another MySQL query just to fetch the date again.

To Test:

1. View the checkout page for a patron with materials checked out today and in days past, as
well as items on reserve.
2. View a patron who is nearing their expiry date
3. Renew a patron
4. Renew a material from the checkout page using the renewal date selector
5. Attempt to checkout a book to a patron that is on hold for someone else
6. Attempt to checkout a book that is currently checked out
7. View a debarred patron

In all cases, any dates displayed should be in syspref format

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years ago[PATCH] [SIGNED-OFF] bug 7570: add a space to the table header
Paul Poulain [Mon, 11 Jun 2012 15:54:21 +0000 (17:54 +0200)]
[PATCH] [SIGNED-OFF] bug 7570: add a space to the table header

Add a space to separate Location from (Status)

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Typo fix, all ok.

12 years agoBug 7570 - Add Item availability status to cart.
Meenakshi.R [Fri, 8 Jun 2012 05:39:58 +0000 (11:09 +0530)]
Bug 7570 - Add Item availability status to cart.

    Added Item availability status to cart(Location table cell).

Changes:
-opac/opac-basket.pl:
Added code to show In transmit status and modified @items to call "GetItemsInfo" instead of "GetItemsLocationInfo" to get accurate avalibility status.
-koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt:
Added code for showing availibility staus in opac-basket page and in  "More details" link.

Test Cases:
-Add records to your cart with different cases like 1 record with  different Item status(Lost,Avaliable,Withdrawn,etc).
-Click on your cart and see the results in a new window.
-Click on "More details" link and check the results.

Signed-off-by: Michael Davis <m.r.davis@cranfield.ac.uk>
12 years agoBug 7941 : Fix version numbers in modules
Chris Cormack [Tue, 10 Apr 2012 23:02:48 +0000 (11:02 +1200)]
Bug 7941 : Fix version numbers in modules

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8171 - Improper escaping of quotes during z39.50 queries leads to broken html
Owen Leonard [Mon, 4 Jun 2012 19:23:30 +0000 (15:23 -0400)]
Bug 8171 - Improper escaping of quotes during z39.50 queries leads to broken html

Implementing fix as suggested by Chris Cormack:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171#c4

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_8092'
Paul Poulain [Mon, 11 Jun 2012 14:57:00 +0000 (16:57 +0200)]
Merge remote-tracking branch 'origin/new/bug_8092'

12 years agoBug 8092: Cheer up Jenkins on loading Cache modules
Jared Camins-Esakov [Sat, 9 Jun 2012 14:57:52 +0000 (10:57 -0400)]
Bug 8092: Cheer up Jenkins on loading Cache modules

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7411: Remove diacritics from generated userid
Katrin Fischer [Sat, 9 Jun 2012 17:09:32 +0000 (18:09 +0100)]
Bug 7411: Remove diacritics from generated userid

Patch introduces a new module Text::Unaccent.

To test:
1) Add a new patron with diacritics in surname and first name, leave userid empty.
2) Save user and check the created userid has only the base characters and
diacritics have been removed correctly.
3) Create another user with the same surname and first name, check userid
is generated correctly.

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>