]> git.koha-community.org Git - koha.git/log
koha.git
13 years agoFollow-up fix for Bug 5462, Fix variable names so we dont break template::toolkit
Owen Leonard [Mon, 14 Feb 2011 07:49:07 +0000 (07:49 +0000)]
Follow-up fix for Bug 5462, Fix variable names so we dont break template::toolkit

A change was made to MARCdetail.tmpl without making a corresponding
change to MARCdetail.pl. I've reworked the original change so that
both can work together.

0XX --> tab0XX

Apparently TMPL variables can't start with a number now?

MR: Recreated patch file to recover failure to apply.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFollow up on Bug 5462: fixing variable names breaks messaging preference form
Ian Walls [Sat, 12 Feb 2011 22:19:23 +0000 (17:19 -0500)]
Follow up on Bug 5462: fixing variable names breaks messaging preference form

The messaging prefs form was hardcoded to use 'transport-$transport_type', rather than
'transport_$transport_type'.  The result was an uneditable messaging preferences form.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFollow-up correction for Bug 5462 - Fix variable names for template::toolkit
Owen Leonard [Mon, 7 Feb 2011 22:09:01 +0000 (17:09 -0500)]
Follow-up correction for Bug 5462 - Fix variable names for template::toolkit

Previous commit modified checks for the item-level_itypes preference
to look for a different variable name but didn't update where that
variable is set in Auth.pm.

Other scripts perform a direct check of item-level_itypes and must
continue to use the name of the variable in the database.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge branch 'bug_5462_signoff' of git://github.com/colinsc/koha into new/enh/bug_5462
Chris Cormack [Thu, 3 Feb 2011 19:52:39 +0000 (08:52 +1300)]
Merge branch 'bug_5462_signoff' of git://github.com/colinsc/koha into new/enh/bug_5462

13 years agoBug 5462: fixed current preferences tab highlighting bug created by dashfix
Christopher Hall [Sun, 28 Nov 2010 20:59:30 +0000 (09:59 +1300)]
Bug 5462: fixed current preferences tab highlighting bug created by dashfix

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoBug 5462: more dash fixing for variable names within scripts
Christopher Hall [Tue, 16 Nov 2010 02:42:25 +0000 (15:42 +1300)]
Bug 5462: more dash fixing for variable names within scripts

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoBug 5462: modified intranet scripts to match templates
Christopher Hall [Mon, 15 Nov 2010 03:06:24 +0000 (16:06 +1300)]
Bug 5462: modified intranet scripts to match templates

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoBug 5462: both intranet and opac seem to be 'clean', still need to make relevant...
Christopher Hall [Mon, 15 Nov 2010 02:47:00 +0000 (15:47 +1300)]
Bug 5462: both intranet and opac seem to be 'clean', still need to make relevant changes in scripts

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoBug 5462: fixed incorrect TMPL_IF
Christopher Hall [Fri, 12 Nov 2010 03:50:11 +0000 (16:50 +1300)]
Bug 5462: fixed incorrect TMPL_IF

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoBug 5462: fixed dashes (replaced with _) and fullstops (removed) for variable names
Christopher Hall [Fri, 12 Nov 2010 01:17:03 +0000 (14:17 +1300)]
Bug 5462: fixed dashes (replaced with _) and fullstops (removed) for variable names

Done within opac and intranet templates, still needs to be done for corresponding scripts.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
13 years agoFixing a syntax error, that snuck in with a merge
Chris Cormack [Thu, 3 Feb 2011 09:52:36 +0000 (22:52 +1300)]
Fixing a syntax error, that snuck in with a merge

13 years agoFix for Bug 3319 - Need error message when adding patron and libraries are defined
Owen Leonard [Tue, 17 Aug 2010 16:58:33 +0000 (12:58 -0400)]
Fix for Bug 3319 - Need error message when adding patron and libraries are defined

- Hiding patron add toolbar when branches or categories are undefined
- Blocking patron entry form if branches or categories are undefined
- Removing nonfunctional template logic for displaying missing category
  error message.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 3212 Force leader 9 position to 'a' for new biblios
Frédéric Demians [Wed, 5 Jan 2011 10:45:52 +0000 (11:45 +0100)]
Bug 3212 Force leader 9 position to 'a' for new biblios

When Creating a new biblio record, if the cataloguer doesn't use the leader
plugin, a biblio record can be saved with a leader not containing a 'a' in 9
position. If the biblio contains UTF-8 characters, its decoding can fail.

This issue applies to MARC-21 not UNIMARC.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5673: test guarantorid consistently
Colin Campbell [Mon, 31 Jan 2011 16:19:49 +0000 (16:19 +0000)]
Bug 5673: test guarantorid consistently

Incorrect checking of guarantorid was causing moremember.pl to
try and construct addresses using data from non-existent guarantors
ensure that test is consistently checking that value is defined and not
'', '0' or 0 [ i.e. what perl does for you anyway!!]

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 2341: items marked 'on order' not reserveable from search results
Ian Walls [Mon, 31 Jan 2011 02:43:55 +0000 (21:43 -0500)]
Bug 2341: items marked 'on order' not reserveable from search results

Items created as part of the acquisitions process, and assigned the temporary notforloan value of -1,
cannot be placed on hold from the search results in either the OPAC or staff client (the link is missing).

This patch changes the evaluation of items->notforloan from a Boolean (if $items->{notforloan}) to a comparison
(if $items->{notforloan} > 0).  Any notforloan status with a negative value can therefore be reserved.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug: 4263 - Repeatable subfields in items
Chris Cormack [Thu, 3 Feb 2011 01:32:32 +0000 (20:32 -0500)]
Bug: 4263 - Repeatable subfields in items

Squashed commit of the following:

commit f441094d5095d165eab18340c983a831cce8f6e0
Author: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Date:   Mon Jul 5 20:33:23 2010 +0200

    bug4263 followup : Can't blank subfields

    Previous bug4263 reintroduced bug 2466: fix clearing item field
    This keeps bug4263 followup to be assigned (donot blank dateaccessioned)
    But also allow to blank item subfields.

commit 92889b766c41b48bdd0e3a33ca4b183b1e259805
Author: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
Date:   Fri Apr 23 13:54:30 2010 +0200

    (bug #4263) dateaccessionned is cleaned on item modification

    Every item modification, date accessionned is cleaned, if there is no modification made, we must'nt reset to "undef" the value.

commit 5abb2db16b2564d32e84b7cc680acbc301d73179
Author: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
Date:   Tue Mar 2 09:57:33 2010 +0100

    (bug #4263) fix the edition of items with repeatable subfields

    The subfield management in item level is broken, fields are concatenated in one field, and if the librarian edit it, the values are not selected.
    This big patch fix three things:
     1) saving fields that are stocked in SQL(using koha2marc mapping) are now well cut and separated in _REAL_ subfields
     2) loading records with repeatable subfields are now well returned
     3) Editing items with repeatable fields works well

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 4263 Removing extranious block of code
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4931: Stocking can be by homebranch or holding branch
Chris Cormack [Thu, 3 Feb 2011 00:40:10 +0000 (19:40 -0500)]
Bug 4931: Stocking can be by homebranch or holding branch

Squashed commit of the following:

commit 105de81639cbac5084e4a5c099b19569043e69ff
Author: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
Date:   Tue Jul 13 11:58:01 2010 +0200

    (bug #4931) fix forgottens input in buttons

    the previous patch missed an hidden input in next buttons that break next page. This fix it.

commit db00295a6b9d1d36fc888ba6a0558011fd6884ba
Author: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
Date:   Fri Jul 2 15:27:59 2010 +0200

    (bug #4931) add the ability to choose home or holding branch in stocktaking

    This add radio box in stocktaking to base it on home or holdingbranch

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 4391 Followup: Adding back lost declaration of $branchcode
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoUpdating history docs
Chris Cormack [Wed, 2 Feb 2011 21:32:54 +0000 (10:32 +1300)]
Updating history docs

13 years agoBug 5661 Fix a problem when doing an authority search with no sort order
Frédérick Capovilla [Wed, 2 Feb 2011 21:17:21 +0000 (16:17 -0500)]
Bug 5661 Fix a problem when doing an authority search with no sort order

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5681: Fixes leading zeroes in Add Mulpiple Copies
Paul Poulain [Wed, 15 Dec 2010 19:28:03 +0000 (20:28 +0100)]
Bug 5681: Fixes leading zeroes in Add Mulpiple Copies

From Biblibre:
I don't know why, but removing sprintf solves the problems with leading zeroes
and the problems with large values.

(written by jean-andré santoni)

Note from Chris:

The width is never set, so the sprintf always defaults to a float, which
trims the leading zeros. I am not smart enough to figure out how to set
a valid width when calling it, and removing the sprintf seems to work
See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5681 for
test results

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5683 - it is possible to save corrupt records
Jared Camins-Esakov [Wed, 2 Feb 2011 16:47:49 +0000 (11:47 -0500)]
Bug 5683 - it is possible to save corrupt records

This patch makes it impossible to save records with variables fields that don't
contain any subfields. Prior to this patch, link_bibs_to_authorities.pl would
sometimes corrupt records.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBumping database version
Chris Cormack [Tue, 1 Feb 2011 06:43:21 +0000 (19:43 +1300)]
Bumping database version

13 years agoBug 4160: Currency conversion doesn't handle rates other than 100
Katrin Fischer [Mon, 31 Jan 2011 20:45:40 +0000 (15:45 -0500)]
Bug 4160: Currency conversion doesn't handle rates other than 100

Changes data type for currency.rate to accomodate bigger currency conversion rates.

FLOAT( 15, 5 )

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5665: Routing slip prints too wide for narrow printers
Reed Wade [Mon, 31 Jan 2011 10:14:08 +0000 (10:14 +0000)]
Bug 5665: Routing slip prints too wide for narrow printers

This patch switches off some min-width styling which causes right hand
of page to be clipped.

Work sponsored by Opus

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoRevised fix for Bug 3850 - Budget Planning Pages Need Design Work
Owen Leonard [Sun, 30 Jan 2011 14:42:18 +0000 (09:42 -0500)]
Revised fix for Bug 3850 - Budget Planning Pages Need Design Work

- Filter moved to left-hand sidebar consistent with other pages
- Export option moved to left-hand sidebar to improve visibility
- Show/hide column controls moved to their own role with clear labels
- "Locked" icon added to replace indicating locked status by row color

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 3881: Updating database version number
Chris Cormack [Mon, 31 Jan 2011 09:29:36 +0000 (22:29 +1300)]
Bug 3881: Updating database version number

13 years agoBug 3881 fixing italian sysprefs
Chris Cormack [Mon, 31 Jan 2011 09:26:04 +0000 (22:26 +1300)]
Bug 3881 fixing italian sysprefs

13 years agoBug 3881: OPAC Privacy reimplementation
Ian Walls [Sun, 30 Jan 2011 05:48:36 +0000 (00:48 -0500)]
Bug 3881: OPAC Privacy reimplementation

Reimplements Paul Poulain's original OPAC Privacy patch, with some minor improvements and changes to wording

If the library enables the OPACPrivacy system preference along with the opacreadinghistory preference, and sets
an AnonymousPatron (must be a valid patron number in the database), the user will see a new tab upon login to
the OPAC, My Privacy.  From there, the user can:

- Set their OPAC Privacy to one of three values
  0 - Forever.  This keeps their reading history unless they explicitly delete it; the bulk anonymiser won't touch it
  1 - Default.  Keep reading history until either they delete it or the library does
  2 - Never.    Instantly anonymises reading history upon item return

- Instantly delete their reading history
  There is a warning and a popup to confirm.  I've removed Paul's extra confirm checkbox, which seemed redundant

A note of which preference the patron has selected is added to the Patorn Details page in the staff client.  This is read-only.

This patch also consolidates Privacy system preferences into the Privacy section of the OPAC tab.

Thank you to BibLibre for the original implmentation of this patch, and Los Gatos Public Library for funding and
testing the reimplementation.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5452 - Overdue date color in borrower's today issues
Chris Cormack [Sat, 29 Jan 2011 18:58:48 +0000 (07:58 +1300)]
Bug 5452 - Overdue date color in borrower's today issues

Patch sent by Fridolyn SOMERS, but not in git format

13 years agoBUG 5649: Change wording on review.tmpl from white\black to approve\rejected consiste...
Schuster [Tue, 25 Jan 2011 09:03:49 +0000 (04:03 -0500)]
BUG 5649: Change wording on review.tmpl from white\black to approve\rejected consistent with the rest of the page

Changes the wording on review.tmpl from white\black to approve\rejected consistent with the rest of the page

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5477 [SIGN-OFF] Fix test cases that require database access
Robin Sheat [Fri, 28 Jan 2011 19:04:08 +0000 (14:04 -0500)]
Bug 5477 [SIGN-OFF] Fix test cases that require database access

This moves the DB-requiring tests out of the way, with the exception of
00-load.t which is used by the git hooks. For it, it makes it skip
loading problematic modules. This allows 'make test' to complete successfully
without a database configured, wich is a required part of making packages.

This has been tested against the v3.02.03 tag and the master branch.

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5376: Batch Mod and Delete require superlibrarian permissions
Ian Walls [Tue, 25 Jan 2011 04:09:39 +0000 (23:09 -0500)]
Bug 5376: Batch Mod and Delete require superlibrarian permissions

This only occurs with IndependantBranches turned on; in an attempt to check that the items being
modified belonged to the user's branch, the code made a simultaneous comparison and assignment,
which is not permitted in all compilations of Perl.

Splitting the assignment of $itembranchcode and the check for its non-null value fixes the problem

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5654: remove disused directory
Galen Charlton [Mon, 24 Jan 2011 22:51:27 +0000 (17:51 -0500)]
bug 5654: remove disused directory

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoAdding Jerome Charaoui to the history docs, 130 people have code in Koha now
Chris Cormack [Wed, 26 Jan 2011 07:10:24 +0000 (20:10 +1300)]
Adding Jerome Charaoui to the history docs, 130 people have code in Koha now

13 years agoHistory updated
Chris Cormack [Wed, 26 Jan 2011 07:08:00 +0000 (20:08 +1300)]
History updated

13 years agoBug 5506 Fix installation of prefs translations in standard installs
Jerome Charaoui [Tue, 25 Jan 2011 21:35:27 +0000 (22:35 +0100)]
Bug 5506 Fix installation of prefs translations in standard installs

[3.2] Should be applied

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 5650, item type page key wrong
Owen Leonard [Mon, 24 Jan 2011 19:38:48 +0000 (14:38 -0500)]
Fix for Bug 5650, item type page key wrong

- Fixes for authorised_values.pl and itemtypes.pl
- Hiding table when there are no values to prevent js error
- Hiding table pager when there are no values
- Removing paging code from the script

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBumping database version
Chris Cormack [Tue, 25 Jan 2011 15:10:42 +0000 (04:10 +1300)]
Bumping database version

13 years agoBug 5619: Subfield 9 missing from most authorised heading fields
Ian Walls [Mon, 24 Jan 2011 12:31:27 +0000 (07:31 -0500)]
Bug 5619: Subfield 9 missing from most authorised heading fields

Adds subfield 9 to DEFAULT MARC21 frameworks for the following fields:

648, 654, 655, 656, 657, 658, 662

Based on entry for 650$9 (values otherwise all the same).  This patch does NOT handle non-DEFAULT frameworks

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoRevert "Fix for Bug 3659, Add place hold option from patron checkout tab"
Chris Cormack [Mon, 24 Jan 2011 17:24:32 +0000 (06:24 +1300)]
Revert "Fix for Bug 3659, Add place hold option from patron checkout tab"

This reverts commit da2040634ed4f589c5f6b188ab3a3fac83d99a9b.

Wrong patch was applied

13 years agoFix for Bug 3659, Add place hold option from patron checkout tab
Owen Leonard [Mon, 17 Jan 2011 13:28:47 +0000 (08:28 -0500)]
Fix for Bug 3659, Add place hold option from patron checkout tab

Adds a button on patron-related pages, "Search to hold"
Clicking search to hold sets a cookie with the patron's
borrowernumber and sends the user to the search page.

On subsequent search results pages the user will have
the option to place holds specifically for the remembered
patron. This works on the search results page (single
and multiple hold) and on the detail page.

The saved cookie will time out after 10 minutes or
be erased when a new patron is loaded by circulation.pl

New jQuery plugin added: jquery.cookie.min.js

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4309 Do not throw error on auth search of multiple fields
Colin Campbell [Thu, 6 Jan 2011 17:49:22 +0000 (17:49 +0000)]
Bug 4309 Do not throw error on auth search of multiple fields

Ensures the multiple search does not throw a 500 error but
allows a single search to be used as well

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5618: Adding missing system preferences
Chris Cormack [Sun, 23 Jan 2011 19:19:11 +0000 (08:19 +1300)]
Bug 5618: Adding missing system preferences

13 years agoBug 5618: Multiple renewals in the opac
Chris Cormack [Thu, 20 Jan 2011 17:16:43 +0000 (12:16 -0500)]
Bug 5618: Multiple renewals in the opac

Enables logged-in OPAC patrons to renew multiple items at once using checkboxes.

Errors are now handled better (for example, when item is on reserve)

Sponsored by Los Gatos Public Library

Squashed commit of the following:

commit 020d9904ddb22af238c8a90c1f7447ead5a6d0e7
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Thu Jan 20 08:57:01 2011 +1300

    Bug 5618: typo fix

commit 147cfd91dbe88fd58c5d404db9bf06a21310e2ef
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Thu Jan 20 08:47:39 2011 +1300

    Bug 5618: Adding better error handling for reserves, and always redirecting instead of exploding

commit 2dfb6c687d0d38c240e22d41f2aef6e3a9e53f02
Author: Chris Cormack <chrisc@koha.(none)>
Date:   Fri Jan 14 15:39:20 2011 +1300

    Bug 5618: Is mostly working now, needs some prettying up

commit f8d260a4dcde144c9ed487521a79ee687ff8feb3
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Fri Jan 14 15:03:45 2011 +1300

    bug 5618: Initial commit to set up checkboxes for choosing multiple items

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/enh/bug_5551' into kcmaster
Chris Cormack [Sun, 23 Jan 2011 18:24:40 +0000 (07:24 +1300)]
Merge remote branch 'kc/new/enh/bug_5551' into kcmaster

13 years agoMerge remote branch 'kc/new/bug_5586' into kcmaster
Chris Cormack [Sun, 23 Jan 2011 18:21:47 +0000 (07:21 +1300)]
Merge remote branch 'kc/new/bug_5586' into kcmaster

13 years agoMerge remote branch 'kc/new/enh/bug_4289' into kcmaster
Chris Cormack [Sun, 23 Jan 2011 18:21:20 +0000 (07:21 +1300)]
Merge remote branch 'kc/new/enh/bug_4289' into kcmaster

13 years agoBug 4289: OpacPublic prevents login into OPAC
Ian Walls [Fri, 21 Jan 2011 22:11:51 +0000 (17:11 -0500)]
Bug 4289: OpacPublic prevents login into OPAC

If OpacPublic is set to Public, opac-user.pl does not ask for authentication, and takes the patron to a
null OPAC summary page.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5327 fixing missing number of tests
Chris Cormack [Thu, 20 Jan 2011 22:28:58 +0000 (11:28 +1300)]
Bug 5327 fixing missing number of tests

13 years agoBumping Koha version
Chris Cormack [Thu, 20 Jan 2011 22:12:16 +0000 (11:12 +1300)]
Bumping Koha version

13 years agoBug 5551 - allow shelf browser filters to be changed
Robin Sheat [Fri, 14 Jan 2011 02:22:14 +0000 (15:22 +1300)]
Bug 5551 - allow shelf browser filters to be changed

This adds three system preferences: ShelfBrowserUsesLocation,
ShelfBrowserUsesHomeBranch, and ShelfBrowserUsesCcode. These can be
toggled to determine whether the shelf browser will ensure that the
items being show will match against location, homebranch, or collection
code, respectively.

Note that this also involves a bit of a refactor to clean up the shelf
browser code.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoAdded more unit tests to check when JSONStream should fail.
Zach Sim [Thu, 20 Jan 2011 21:46:09 +0000 (10:46 +1300)]
Added more unit tests to check when JSONStream should fail.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5327: Added unit tests to Output_JSONStream.t
Zach Sim [Thu, 20 Jan 2011 20:16:28 +0000 (09:16 +1300)]
Bug 5327: Added unit tests to Output_JSONStream.t

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/enh/bug_5628' into kcmaster
Chris Cormack [Thu, 20 Jan 2011 20:20:41 +0000 (09:20 +1300)]
Merge remote branch 'kc/new/enh/bug_5628' into kcmaster

13 years agoBug 5268: Combining icons with liblime-kids
Chris Cormack [Thu, 20 Jan 2011 19:51:09 +0000 (08:51 +1300)]
Bug 5268: Combining icons with liblime-kids

13 years agoMerge remote branch 'kc/new/enh/bug_5640' into kcmaster
Chris Cormack [Thu, 20 Jan 2011 08:06:23 +0000 (21:06 +1300)]
Merge remote branch 'kc/new/enh/bug_5640' into kcmaster

13 years agoBug 5640: Adding the icons to the opac also
Chris Cormack [Thu, 20 Jan 2011 08:03:56 +0000 (21:03 +1300)]
Bug 5640: Adding the icons to the opac also

13 years agoBug 5327: small typo in the Members.t test
Chris Cormack [Thu, 20 Jan 2011 07:14:04 +0000 (20:14 +1300)]
Bug 5327: small typo in the Members.t test

13 years agoBug 5327 Made test file for Accounts.pm
johnboy [Wed, 19 Jan 2011 22:17:35 +0000 (11:17 +1300)]
Bug 5327 Made test file for Accounts.pm

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5634: BZ5634 order branch list alphabetically, without taking care of uc/lc
Paul Poulain [Tue, 18 Jan 2011 16:19:18 +0000 (11:19 -0500)]
Bug 5634: BZ5634 order branch list alphabetically, without taking care of uc/lc

Perl separates uc & lc in cmp. So we just uc() to have list properly ordered

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug5640: BZ5640 (MT3584): Nimes icon set
Paul Poulain [Tue, 18 Jan 2011 15:56:59 +0000 (10:56 -0500)]
Bug5640: BZ5640 (MT3584): Nimes icon set

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug5640: BZ5640 (MT3584): Nimes icon set
Paul Poulain [Tue, 18 Jan 2011 15:56:59 +0000 (10:56 -0500)]
Bug5640: BZ5640 (MT3584): Nimes icon set

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5327: Shifting and little tidy up of the members tests
Chris Cormack [Wed, 19 Jan 2011 22:52:19 +0000 (11:52 +1300)]
Bug 5327: Shifting and little tidy up of the members tests

13 years agoBug 5327 Some tests added
johnboy [Wed, 19 Jan 2011 21:32:58 +0000 (10:32 +1300)]
Bug 5327 Some tests added

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4289: Updating other sysprefs until we change the installer, we need to do this
Chris Cormack [Wed, 19 Jan 2011 07:55:33 +0000 (20:55 +1300)]
Bug 4289: Updating other sysprefs until we change the installer, we need to do this

13 years agoNew icon set, renaming and making files in the intranet too
Chris Cormack [Tue, 18 Jan 2011 23:35:57 +0000 (12:35 +1300)]
New icon set, renaming and making files in the intranet too

13 years agoNew icon set for kids, has ben rezided to 48 by 48px
claudia [Tue, 18 Jan 2011 21:11:12 +0000 (10:11 +1300)]
New icon set for kids, has ben rezided to 48 by 48px

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4289: Bumping version number up
Chris Cormack [Wed, 19 Jan 2011 01:31:58 +0000 (14:31 +1300)]
Bug 4289: Bumping version number up

13 years agoBug 4289 Followup: Add syspref default value and in opac.pref
Frédéric Demians [Tue, 7 Dec 2010 16:33:13 +0000 (17:33 +0100)]
Bug 4289 Followup: Add syspref default value and in opac.pref

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4289: 'OpacPublic' feature
Mason James [Tue, 7 Dec 2010 16:33:12 +0000 (17:33 +0100)]
Bug 4289: 'OpacPublic' feature

applied to git tag 'v3.02.00-rc'

Frédéric Demians:

  - Rebased this patch to HEAD
  - Solved a merge conflict
  - The patch works as described here:
    http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4289

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5327 - Now we are doing db calls, we need to shift this to t/db_dependent
Chris Cormack [Wed, 19 Jan 2011 00:38:52 +0000 (13:38 +1300)]
Bug 5327 - Now we are doing db calls, we need to shift this to t/db_dependent

13 years agoAdded unit tests to test all of get_amazon_tld in Amazon.pm.
Zach Sim [Tue, 18 Jan 2011 23:07:25 +0000 (12:07 +1300)]
Added unit tests to test all of get_amazon_tld in Amazon.pm.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Tue, 18 Jan 2011 22:26:18 +0000 (11:26 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

13 years agoBug 5327: Little change to Record.t
Chris Cormack [Tue, 18 Jan 2011 22:09:28 +0000 (11:09 +1300)]
Bug 5327: Little change to Record.t

13 years agoBug 5327 1 more test added.
johnboy [Tue, 18 Jan 2011 21:44:11 +0000 (10:44 +1300)]
Bug 5327 1 more test added.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoAdded unit tests for Biblio and moved it to db_dependent as it requires the database.
Zach Sim [Tue, 18 Jan 2011 21:52:23 +0000 (10:52 +1300)]
Added unit tests for Biblio and moved it to db_dependent as it requires the database.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Tue, 18 Jan 2011 09:54:06 +0000 (22:54 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

13 years agoBug 5327 Cleaning up XISBN.t a bit
Chris Cormack [Tue, 18 Jan 2011 09:52:02 +0000 (22:52 +1300)]
Bug 5327 Cleaning up XISBN.t a bit

13 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Tue, 18 Jan 2011 06:55:12 +0000 (19:55 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

13 years agoBug 5327 - Fixing a path issue with XISBN.t
Chris Cormack [Tue, 18 Jan 2011 06:53:58 +0000 (19:53 +1300)]
Bug 5327 - Fixing a path issue with XISBN.t

13 years agoBug 5327 litte fix for Background tests
Chris Cormack [Tue, 18 Jan 2011 03:35:08 +0000 (16:35 +1300)]
Bug 5327 litte fix for Background tests

13 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Tue, 18 Jan 2011 03:25:58 +0000 (16:25 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

13 years agoBug 5327 shifting database dependent modules and scripts to t/db_dependent
Chris Cormack [Tue, 18 Jan 2011 03:18:37 +0000 (16:18 +1300)]
Bug 5327 shifting database dependent modules and scripts to t/db_dependent

13 years agobug 5327 updated test file
johnboy [Tue, 18 Jan 2011 02:56:38 +0000 (15:56 +1300)]
bug 5327 updated test file

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoAdded unit tests using a test database for XISBN.
Zach Sim [Tue, 18 Jan 2011 02:54:49 +0000 (15:54 +1300)]
Added unit tests using a test database for XISBN.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoCreated unit testing using the testdatabase for XISBN.
Zach Sim [Tue, 18 Jan 2011 02:25:22 +0000 (15:25 +1300)]
Created unit testing using the testdatabase for XISBN.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Mon, 17 Jan 2011 23:01:04 +0000 (12:01 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

13 years agoAdded extra unit tests to Debug.t
Zach Sim [Mon, 17 Jan 2011 22:14:21 +0000 (11:14 +1300)]
Added extra unit tests to Debug.t

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5327 started testing
johnboy [Mon, 17 Jan 2011 22:34:39 +0000 (11:34 +1300)]
bug 5327 started testing

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5327 Starting tests for BackgroundJob
johnboy [Mon, 17 Jan 2011 22:06:05 +0000 (11:06 +1300)]
Bug 5327 Starting tests for BackgroundJob

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Mon, 17 Jan 2011 22:35:15 +0000 (11:35 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

13 years agoBug 5327 Starting Unit Tests for Auth.pm
spartaness [Mon, 17 Jan 2011 21:57:31 +0000 (10:57 +1300)]
Bug 5327 Starting Unit Tests for Auth.pm

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5327' into kcmaster
Chris Cormack [Mon, 17 Jan 2011 20:41:53 +0000 (09:41 +1300)]
Merge remote branch 'kc/new/bug_5327' into kcmaster

13 years agoBug 5327 removing uneeded tests
claudia [Mon, 17 Jan 2011 19:56:33 +0000 (08:56 +1300)]
Bug 5327 removing uneeded tests

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5399: Follow up style patch, moving exits out of subroutine
Chris Cormack [Mon, 17 Jan 2011 09:53:28 +0000 (22:53 +1300)]
Bug 5399: Follow up style patch, moving exits out of subroutine

13 years agoBug 5399: remove useless eval 'use C4::Foo'
Galen Charlton [Mon, 17 Jan 2011 09:45:41 +0000 (09:45 +0000)]
Bug 5399: remove useless eval 'use C4::Foo'

Also add a couple FIXMEs

Marcel: Signed and updated for current master

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5026 Undefined dates formatted poorly in serials-edit
Colin Campbell [Mon, 17 Jan 2011 08:17:40 +0000 (08:17 +0000)]
Bug 5026 Undefined dates formatted poorly in serials-edit

Don't display junk in empty fields
Don't generate errors

Merged some changes to make variable names moremeaningful in loops ( within loops)

Thanks to M De Rooy for spotting a couple of issues in the original patch

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoAdding a new developer to the history
Chris Cormack [Mon, 17 Jan 2011 07:59:11 +0000 (20:59 +1300)]
Adding a new developer to the history

13 years agoBug 4920 - neworderempty.tmpl shouldn't call calcNeworderTotal() onload
Dobrica Pavlinusic [Mon, 20 Dec 2010 12:08:23 +0000 (12:08 +0000)]
Bug 4920 - neworderempty.tmpl shouldn't call calcNeworderTotal() onload

Currently, modifying existing orders will recalculate values if exchange rate
has changed, which destroys previous data (our use case is just to modify
Planning value fields).

Since fields also have onChange event which also triggers caclNeworderTotal,
onload event seems redundant.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5403 Remove DisplayISBN and GetPublisherNameFromIsbn
Colin Campbell [Tue, 14 Dec 2010 09:28:53 +0000 (09:28 +0000)]
Bug 5403 Remove DisplayISBN and GetPublisherNameFromIsbn

These two subroutines were no longer being used by any other code
removed them from their respective modules
If we need any ISBN in future we should use Business::ISBN directly

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>