]> git.koha-community.org Git - koha.git/log
koha.git
15 years agoCleanup and tighten Letters module.
Joe Atzberger [Fri, 19 Sep 2008 00:02:46 +0000 (19:02 -0500)]
Cleanup and tighten Letters module.

Subroutine arguments enforced w/ with more checks, explicit return undef where warranted.
Placeholders used in SQL where applicable.
One logical error corrected :
- next MESSAGE if ( lc( $message->{'message_transport_type'} eq 'rss' ) );
+ next MESSAGE if ( lc($message->{'message_transport_type'}) eq 'rss' );

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2505 followup: restored correct item type image display
Galen Charlton [Fri, 24 Apr 2009 14:57:24 +0000 (09:57 -0500)]
bug 2505 followup: restored correct item type image display

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2505: adding warnings to opac-detail.pl
Andrew Moore [Wed, 17 Dec 2008 22:32:25 +0000 (16:32 -0600)]
Bug 2505: adding warnings to opac-detail.pl

Before starting to edit opac/opac-detail.pl, I added 'use warnings' and
eliminated all of the warnings that I could get it to produce. I also
extracted two lines that prepared an amazon ISBN into a function. They
were causing a few warnings and might as well be extracted. They should
probably be moved to a module somewhere since these two lines are copied
all over our code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoModify GoogleJacket display
Frederic Demians [Wed, 21 Jan 2009 12:28:34 +0000 (13:28 +0100)]
Modify GoogleJacket display

On detail page, when GoogleJacket is enabled,
book cover is retrieved from Google. This image
is a link to GoogleBook services: full text,
book localisation in a bookstore, etc.

This patch removes the link on book cover and
add underneath a text 'Source Google' with a
link to GoogleBook services.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agorefactor: removing a few unnecessary loops and moving HTML out of script into template
Andrew Moore [Wed, 17 Dec 2008 22:30:46 +0000 (16:30 -0600)]
refactor: removing a few unnecessary loops and moving HTML out of script into template

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3152 OPAC reading history column headers don't line up with text
Jane Wagner [Fri, 24 Apr 2009 12:33:50 +0000 (08:33 -0400)]
Bug 3152 OPAC reading history column headers don't line up with text

Fixed template files to make column headers and text line up; moved
the <td></td> for cover art outside the various content provider IF
statements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3128 - followup and correction
Joe Atzberger [Thu, 23 Apr 2009 22:23:24 +0000 (17:23 -0500)]
Bug 3128 - followup and correction

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3128: IE7 tweak
Joe Atzberger [Wed, 22 Apr 2009 21:16:56 +0000 (16:16 -0500)]
Bug 3128: IE7 tweak

Again, jquery has the answer, mainly because it fails cleanly and
quietly on NULL/undef elements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoNew Developer
Chris Cormack [Thu, 23 Apr 2009 21:59:17 +0000 (09:59 +1200)]
New Developer

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 1546 - replacing REPLACE statements
John Beppu [Thu, 23 Apr 2009 19:35:53 +0000 (14:35 -0500)]
bug 1546 - replacing REPLACE statements

replaced REPLACE statements with a pair of INSERT and UPDATE statements.
Hopefully, these are the last ones.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3118: Remove comment that perturbs IE
Joe Atzberger [Wed, 22 Apr 2009 20:22:38 +0000 (15:22 -0500)]
Bug 3118: Remove comment that perturbs IE

Formatting bugs not fixed.  Class added to relevant labels.
Both CSS and jquery setting of width do not "take" in IE7.
The background-color, however, can be affected.  Go figure.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdding the dev weekend and another developer to the history docs
Chris Cormack [Wed, 22 Apr 2009 23:33:41 +0000 (11:33 +1200)]
Adding the dev weekend and another developer to the history docs

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoIE bugs 3124 and 3115: z3950 search and guided_reports
Joe Atzberger [Wed, 22 Apr 2009 18:24:34 +0000 (13:24 -0500)]
IE bugs 3124 and 3115: z3950 search and guided_reports

Clip trailing comma in js list argument.

Column selection improved with jquery and submit time check.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoTypo in history docs
Chris Cormack [Wed, 22 Apr 2009 23:33:40 +0000 (11:33 +1200)]
Typo in history docs

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFix for Bug 3119: Add due date to the patron circulation history window
Owen Leonard [Mon, 20 Apr 2009 18:25:01 +0000 (13:25 -0500)]
Fix for Bug 3119: Add due date to the patron circulation history window

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFix for Bug 1877, Link to patron record from manage suggestions
Owen Leonard [Tue, 21 Apr 2009 20:19:42 +0000 (15:19 -0500)]
Fix for Bug 1877, Link to patron record from manage suggestions

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoPatch to improve auto-generated MARC21 authorities
Brian Harrington [Tue, 21 Apr 2009 16:13:22 +0000 (12:13 -0400)]
Patch to improve auto-generated MARC21 authorities

This patch makes sure that MARC21 authorities have a minimal
Leader, 008, and 040.  If an authority record is created through
BiblioAddsAuthority it generates a 670 based on information in
the bib record.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug #3101 - Changed the Print and Confirm button
Brendan A. Gallagher [Sat, 18 Apr 2009 21:15:01 +0000 (17:15 -0400)]
Bug #3101 - Changed the Print and Confirm button

Changed button to read "Print slip, Transfer and Confirm"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix to previous patch - use 'lt', not '<', to compare date strings
Galen Charlton [Mon, 20 Apr 2009 17:13:41 +0000 (12:13 -0500)]
fix to previous patch - use 'lt', not '<', to compare date strings

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoVisual alert (red) on overdue return.
Joe Atzberger [Mon, 20 Apr 2009 17:00:15 +0000 (12:00 -0500)]
Visual alert (red) on overdue return.

This was requested by a Koha user at KohaCon09.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2847 - Added url escaping for categorie.tmpl
Cory Jaeger [Mon, 20 Apr 2009 16:57:56 +0000 (11:57 -0500)]
Bug 2847 - Added url escaping for categorie.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2847 - Fix html escaping in categorie.tmpl (more needed)
Cory Jaeger [Sun, 19 Apr 2009 22:41:55 +0000 (17:41 -0500)]
Bug 2847 - Fix html escaping in categorie.tmpl (more needed)

Added escape="html" to several TMPL_VAR tags which need it in order
to deal with quotes and other special chars in user supplied data.
Many other templates still need to have escaping added to fields which
allow free form entry.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFix Bug #2925
Nicole Engard [Sun, 19 Apr 2009 15:46:16 +0000 (10:46 -0500)]
Fix Bug #2925

This patch fixes the language issue on the serial full
display on the OPAC by changing 'waited' to 'waiting'.

In addition I have made it so that the Date Received
only shows if the item is 'Available'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFixing xhtml errors
Chris Cormack [Sun, 19 Apr 2009 14:00:05 +0000 (02:00 +1200)]
Fixing xhtml errors

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoPartial fix for Bug #3139
Nicole Engard [Sun, 19 Apr 2009 13:42:04 +0000 (08:42 -0500)]
Partial fix for Bug #3139

Standardized all references to Address and Zip/Postal Code.

Also fixed bug #3138 by making the Alt address ready City, State.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoModification on Bug # 3102 - "Location" instead of "Localization"
Brendan A. Gallagher [Sat, 18 Apr 2009 23:15:47 +0000 (19:15 -0400)]
Modification on Bug # 3102 - "Location" instead of "Localization"

This a change to previous patch for Bug #3102 (That has been pushed to head).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofir for #2338
Paul Poulain [Sat, 18 Apr 2009 23:37:32 +0000 (01:37 +0200)]
fir for #2338

When I go to serials/claims.pl, "All Suppliers (2)" is selected in the supplier
dropdown list, and no missing issues are listed. When I choose another supplier
from that list ("Supplier 1 (2)"), then two missing issues are listed. Should
"All Suppliers" instead read "Choose a Supplier" ?

chris: I think it might be safe to remove the all suppliers option all together as its
doing nothing

paul: agreed, this patch removes the All Supplier line, that is useless, confusing & untranslatable

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix for 2336
Paul Poulain [Sat, 18 Apr 2009 23:24:05 +0000 (01:24 +0200)]
fix for 2336

When you put a library in a group it doesn't show on the details list.  The
details list has a properties column that maybe is supposed to be used for this
since there doesn't appear to be any other use for it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix for #1731
Paul Poulain [Sat, 18 Apr 2009 23:04:23 +0000 (01:04 +0200)]
fix for #1731

The "place hold" button is hidden in detail.pl when there are no items or the
items are not for loan. MARC detail should do the same.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFix for 2363
Paul Poulain [Sat, 18 Apr 2009 21:46:24 +0000 (23:46 +0200)]
Fix for 2363

There is a comma at the beginning that shouldn't be there and then there are
commas in the vol, no combo making it hard to read.  it should be something
like this:

Vol 28, No 7; Vol 28, No 8; Vol 28, No 9

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoNew developer added to the history
Chris Cormack [Sat, 18 Apr 2009 21:44:29 +0000 (09:44 +1200)]
New developer added to the history

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoUpdate for bug 1545 allowing for the title to be edited
Chris Cormack [Sat, 18 Apr 2009 21:44:30 +0000 (09:44 +1200)]
Update for bug 1545 allowing for the title to be edited

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoChange typo Localisation to Localization for Bug # 3102
Brendan A. Gallagher [Sat, 18 Apr 2009 20:42:30 +0000 (16:42 -0400)]
Change typo Localisation to Localization for Bug # 3102

[RM note: I think there are a few people who wouldn't
 call "localisation" a typo - such as our UK, NZ,
 Australian, etc. contributors ;-) ].  That said,
 I'm pushing this patch to consistent with the
 general trend of the English varient used on the
 /prog/ templates.  There's no implication that en_US
 is the "correct" version of the language.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix for #946
Paul Poulain [Sat, 18 Apr 2009 21:01:01 +0000 (23:01 +0200)]
fix for #946

A member returns a book : it would be better to see the category of this member
in "information member" near his name.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdded Koha 3 Manual Release
Nicole Engard [Sat, 18 Apr 2009 20:21:21 +0000 (15:21 -0500)]
Added Koha 3 Manual Release

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoRepair the old repairmissingbiblionumbers script
Nahuel ANGELINETTI [Sat, 18 Apr 2009 19:58:32 +0000 (21:58 +0200)]
Repair the old repairmissingbiblionumbers script

This patch refound all the script which fix all records without any biblionumber.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3013 Fix for 007 value builder to include all material types
Jane Wagner [Sat, 18 Apr 2009 19:53:04 +0000 (15:53 -0400)]
Bug 3013 Fix for 007 value builder to include all material types

Delivered version only had Text material type; this patch includes
all 14 material types with appropriate values for each.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAllowing users to edit saved sql in guided reports. Bug 1545
Chris Cormack [Sat, 18 Apr 2009 17:59:55 +0000 (05:59 +1200)]
Allowing users to edit saved sql in guided reports. Bug 1545

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix for #908
Paul Poulain [Sat, 18 Apr 2009 19:32:43 +0000 (21:32 +0200)]
fix for #908

In an list of autorised values (Parameters >autotised values), if you delete an
autorised value after confirm, you go back to the first page of the list, and
you must return manually to the page you left before.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix for #918
Paul Poulain [Sat, 18 Apr 2009 19:34:40 +0000 (21:34 +0200)]
fix for #918

In authorities, you can create frameworks like for biblio.
But in these it's impossible to delete useless fields, because when you click on
delete button, you go back to the default framework.
SO if you confirm your deletion, it delete your field in the default framework
and so in all the framwork (I think...).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3132: Reformatting guarantor entry based on C vs. P patron types
Owen Leonard [Sat, 18 Apr 2009 19:42:10 +0000 (14:42 -0500)]
Bug 3132: Reformatting guarantor entry based on C vs. P patron types

Professional patrons might have Organizations as guarantors, so display the guarantor entry form with a single line labelled appropriately. For Child patrons display the form fields as before.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3133 - correct typos
Joe Atzberger [Sat, 18 Apr 2009 17:43:06 +0000 (12:43 -0500)]
Bug 3133 - correct typos

This corrects 3 typographical errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofollowup to 3004 - fix typo
Galen Charlton [Sat, 18 Apr 2009 17:12:06 +0000 (12:12 -0500)]
followup to 3004 - fix typo

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoRemoving duplicate email form field. Fixes Bug 3010.
Owen Leonard [Sat, 18 Apr 2009 16:21:43 +0000 (11:21 -0500)]
Removing duplicate email form field. Fixes Bug 3010.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoremove last reference to deprecated syspref noOPACUserLogin
Galen Charlton [Sat, 18 Apr 2009 15:39:41 +0000 (10:39 -0500)]
remove last reference to deprecated syspref noOPACUserLogin

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2958: fix search results navigation for CCL, CQL, and PQF queries
Galen Charlton [Thu, 9 Apr 2009 14:55:41 +0000 (09:55 -0500)]
bug 2958: fix search results navigation for CCL, CQL, and PQF queries

The shortcut to build $query_cgi in C4::Search::buildQuery()
for CCL, CQL, and PQF queries is incorrect, as (for now)
the "q=" prefix is required.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoHistory docs
Chris Cormack [Sat, 18 Apr 2009 14:34:27 +0000 (02:34 +1200)]
History docs

Squashed commit of the following:

commit 143a24041dd1988e025458ccb285a64809640f45
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Apr 19 01:48:35 2009 +1200

    Updating indian news

commit 21e518389b99acd038a5f0f5a3819e66bfc32062
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Fri Apr 17 04:43:41 2009 +1200

    Adding more dehli public library news

commit a610f13cabf07d4de44e6b841be57e391301d0f3
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Thu Apr 16 02:41:48 2009 +1200

    More history work from the devel list

commit 8d7f33c548600177a2b55f46a53f9828238c6e05
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Apr 12 22:24:40 2009 +1200

    Added translation information

commit c1d20eb095275904a01090f278356ee6c1b77f71
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Apr 12 21:07:46 2009 +1200

    Up to March 2006 on the devel list

commit 45b9ea49220dc350d684e5fe175062dfc95d146c
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 21:39:14 2009 +1200

    Up to August 2005 on the devel list

commit 2788b21f1efb9ace2e23cabfbd82bfc27868ab33
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 20:21:01 2009 +1200

    Adding tags

commit f3b26c2eccc86a0616c5e98cedeee68ce5662abb
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 20:05:03 2009 +1200

    Last little fix

commit f5e778278e9483c9ee4be24fa95692079a5ccbb4
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 19:55:17 2009 +1200

    More formatting

commit 83ea369a4e0c5cb6141cf0b2dc104e0e9d0b1761
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 19:32:08 2009 +1200

    Formatting tweaks

commit f5c6709268f216b52826a45f427258717e011777
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 19:20:40 2009 +1200

    Tab separated text

commit 6a80241a9a77b79b4d3ab8881f0b91217d8238a5
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 17:30:07 2009 +1200

    Up to May 2005 on the devel list

commit 6ea5ec539e023d3652ed097467c65f81257a2146
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 16:07:30 2009 +1200

    Up to october 2003 on th devel list

commit 8e0d72b86c2da276d1fc5731e69974b135c047f2
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 10:49:59 2009 +1200

    Now up to February 2003 on the devel list

commit aedcfd1c66fe2bd61c5bc5cb0aa3ae9e446d356c
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 09:34:32 2009 +1200

    Adding history about paul

commit cb728d09ee3024abb3d98cca90f68514e9a6e14e
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 08:41:51 2009 +1200

    Typo fix

commit 9f515f9df0450a9a797bb0abb68233eddb2d15ef
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Fri Apr 10 21:43:35 2009 +1200

    Done up to October 2002 on the devel list

commit 87382c7d2c2fb05b23eedb0840a94b729f211d16
Author: Chris Cormack <chris@deb-lap.(none)>
Date:   Fri Apr 10 20:31:22 2009 +1200

    Up to june 2002 on the developer list

commit 75d24ed5f05c45ea7c25e2c8623bec114c35ce81
Author: Chris Cormack <chris@deb-lap.(none)>
Date:   Fri Apr 10 18:47:21 2009 +1200

    Adding information from the devel list

commit 4ab492672feab94cabc2337f1c8ef01e588c90f6
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Wed Apr 8 08:47:31 2009 +1200

    Adding date for biblibre

commit 4a0153d1dbd5abdf289f9e842c8e60908286c66a
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Apr 7 22:39:23 2009 +1200

    Finished the main mailing list and the announce list, working on the translate list now

commit 4c99f3809ce2539d8c2312ad76bc533ebe2a0fdf
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Apr 7 21:03:07 2009 +1200

    Fixing typo

commit ad5f8685529503da0a4a214fc900a9b2fd9a880a
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Apr 7 20:47:00 2009 +1200

    Adding biblibre, fixing rfp history

commit 0be5d854db10eb2d1710a940c141c1689e3e226a
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Apr 7 19:47:59 2009 +1200

    More history work

commit 2b423736e5e343fbf5abe84e6e1055541bb2a7c3
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Apr 7 07:04:30 2009 +1200

    Fixing dates for OLC

commit 5065f400dc369531725bfe4469b115a168110f52
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Mon Apr 6 22:07:07 2009 +1200

    More work on the history

commit d5dd62629bddded528edf5b99e1b316554ff3138
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Mon Apr 6 20:18:03 2009 +1200

    Finished committers history

commit d707b19d04f094239d0300b6a0a296b7ac93c799
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Mon Apr 6 19:57:07 2009 +1200

    Finishing off committer history

commit b15d07d0c8f299d719365dd087e98066beee19a9
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Apr 5 21:38:39 2009 +1200

    VCS history for 2007

commit 47e69aa34409389d8c203e35b70a1480351705ef
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Apr 5 21:30:21 2009 +1200

    VCS and main mailing list history for 2006

commit 3e45921c5fee7a122e745d025524970a11ef9b09
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Apr 5 20:07:26 2009 +1200

    Continuing on with the History

commit f8719ebb2bde3871c45de9b043f0260b5bd810d7
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Apr 5 19:14:08 2009 +1200

    Adding links to computerworld articles

commit 500370aa98b869edb0b0b36ca7af5a8b094f515b
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Apr 5 18:59:30 2009 +1200

    2005 vcs and main mailing list history

commit f6fad5cfba85aa4213038ce301cc84436f76df2f
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Apr 5 07:59:18 2009 +1200

    Up to June 2005

commit 43d40046e0fb9baf75b58c769632bc99346295cb
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Thu Apr 2 22:05:33 2009 +1300

    Working on 2005

commit f15da9231fffecbe2b6d35c53e9e1adf370222c1
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Thu Apr 2 09:33:09 2009 +1300

    More history work

commit 93174bbd9bde579c91a3bc49976faf118a83da52
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Mar 31 22:04:56 2009 +1300

    More history

commit f2fd3c6d74ef4489100401bbbf936df1efa16d19
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Mar 31 18:55:08 2009 +1300

    More 2004

commit a17646986b0abf99b121309e22fce299449a3cc4
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Mar 31 18:27:29 2009 +1300

    Working on 2004

commit 5886fae2d293f801ed436a3efa8660966a31ba3e
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Mar 31 13:52:07 2009 +1300

    Continuing on with the history updates

commit 1f64c51abf414d8432280023e72d5f191961a8a0
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Mar 31 09:02:25 2009 +1300

    More history

commit c20b84d7d42b7774d8c5ab7f20a54f6314e4f30c
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Tue Mar 31 13:48:49 2009 +1300

    formatting fix

commit 7698ba607429e502126ccf2df1e9e9a4755fa448
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Mon Mar 30 22:02:12 2009 +1300

    And even more history

commit cac079f7541e9276710dc778527ea9c84e8d185a
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Mon Mar 30 21:45:36 2009 +1300

    COntinuing on

commit ce7402c7dbcf01483f9905b4eb75f1d89568e0d8
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Mon Mar 30 21:05:27 2009 +1300

    Continuing on

commit 3dcd055d4640160a54e88d8c6519785a390a93a7
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Mon Mar 30 20:44:41 2009 +1300

    Continuing on the history

commit cf07159fd8d400750d1878213fab7b01b45c5197
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Mon Mar 30 20:33:28 2009 +1300

    More history updates

commit a3c31379e115e9aeab44c752126f6f4878c3bf15
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Mar 29 23:16:52 2009 +1300

    More history

commit 831a385489a90f750cc760e18b598339c02aa620
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Mar 29 22:53:25 2009 +1300

    Continuing on

commit 26e38756019023dfd928538553fdf95311eee4ed
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Mar 29 22:15:11 2009 +1300

    More doc

commit bb13ea869d83f4493dc53041a0894880a5fefd66
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Mar 29 21:54:50 2009 +1300

    Continuing work on the history doc

commit 69aff74445eac3c260c081cb63e403c1025b7950
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Mar 29 21:37:37 2009 +1300

    History documentation

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 3100: increase width of alternate postal code
Galen Charlton [Thu, 9 Apr 2009 15:31:45 +0000 (10:31 -0500)]
bug 3100: increase width of alternate postal code

The alternative postal code input on the patron
editing form was only permitted 5 characters of
input.  Increase this to 10 to match the
primary zipcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoMulti-bug fix - SetMarcUnicodeFlag for records coming from Koha
Joe Atzberger [Thu, 9 Apr 2009 16:50:47 +0000 (11:50 -0500)]
Multi-bug fix - SetMarcUnicodeFlag for records coming from Koha

This has bearing on bugs 2905, 2665, 2514 and other "wide character" crashes
related to diacritics and Unicode.  This should help open the door for reliable
input of diacriticals via acquisitions.

MARC21_utf8_flag_fix.pl diagnoses and fixes existing problems with MARC data
affected by the bug.

Adding SetMarcUnicodeFlag to TransformKohaToMarc prevents the bug from corrupting
further data.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoTweak perldoc (--help) for leader_fix.pl
Joe Atzberger [Tue, 7 Apr 2009 22:37:56 +0000 (17:37 -0500)]
Tweak perldoc (--help) for leader_fix.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoScript to repair MARC21 leader/09.
Joe Atzberger [Fri, 3 Apr 2009 20:42:20 +0000 (15:42 -0500)]
Script to repair MARC21 leader/09.

Acquisitions process seems to be adding records with incorrect
representation of the MARC encoding in leader/09.  It should be
'a' meaning UTF-8, for all Koha's internalized records, but in
many cases it appears blank (for MARC-8).  This script diagnoses
and repairs the value in the leader, depending on runtime options.

The symptom of this problem is that high-value UNICODE characters
in the record will cause Koha to crash whenever it tries to parse
the MARCXML, giving a "Wide character" fatal.  While we work on
fixing the input, this script will fix the existing data.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug: unescaped single-quote in french sys. prefs. sql file
Michael Hafen [Mon, 13 Apr 2009 21:53:42 +0000 (15:53 -0600)]
bug: unescaped single-quote in french sys. prefs. sql file

The description for autoBarcode had an unescaped single-quote.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoRe-insert useldapserver into koha-conf.xml
Joe Atzberger [Mon, 13 Apr 2009 22:05:49 +0000 (17:05 -0500)]
Re-insert useldapserver into koha-conf.xml

This doesn't insert the large and typically unused <ldapserver> block,
just the switch with a comment pointing to C4::Auth_with_ldap.  This otherwise
was undocumented requirement, making LDAP config a bit of a shot in the dark.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoremove last reference to deprecated syspref NoReturnSetLost
Galen Charlton [Tue, 14 Apr 2009 13:51:08 +0000 (08:51 -0500)]
remove last reference to deprecated syspref NoReturnSetLost

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 3110 - Move Serial Preferences to Serials Tab
John Beppu [Tue, 14 Apr 2009 19:45:15 +0000 (14:45 -0500)]
bug 3110 - Move Serial Preferences to Serials Tab

- Moved the following system preferences to the Serials tab:
  OPACDisplayExtendedSubInfo
  OPACSubscriptionDisplay
  RenewSerialAddsSuggestion
  SubscriptionHistory

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBut 3117 : fix typo in C4::Matcher causing compilation failure.
Ryan Higgins [Wed, 15 Apr 2009 17:23:21 +0000 (10:23 -0700)]
But 3117 : fix typo in C4::Matcher causing compilation failure.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoqualify warn; sort_by is not a required search parameter
Galen Charlton [Wed, 8 Apr 2009 20:13:12 +0000 (15:13 -0500)]
qualify warn; sort_by is not a required search parameter

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix various warnings
Galen Charlton [Wed, 8 Apr 2009 20:34:45 +0000 (15:34 -0500)]
fix various warnings

* Use of uninitialized value in pattern match (m//) at C4/Biblio.pm line 1305
  (displaying MARC21 856s that don't have $3)
* Use of uninitialized value in multiplication (*) at catalogue/detail.pl line 243.
  (attemping to calculate average Amazon rating if no Amazon info
   is available)
* opac-detail.pl: Use of uninitialized value in length at C4/External/Amazon.pm line 90
  (attempting to calculate length of $isbn if it happens to be undef)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix various warnings
Galen Charlton [Wed, 8 Apr 2009 20:34:45 +0000 (15:34 -0500)]
fix various warnings

* Use of uninitialized value in pattern match (m//) at C4/Biblio.pm line 1305
  (displaying MARC21 856s that don't have $3)
* Use of uninitialized value in multiplication (*) at catalogue/detail.pl line 243.
  (attemping to calculate average Amazon rating if no Amazon info
   is available)
* opac-detail.pl: Use of uninitialized value in length at C4/External/Amazon.pm line 90
  (attempting to calculate length of $isbn if it happens to be undef)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 3049: display correct due date of renewed loans
Galen Charlton [Wed, 8 Apr 2009 19:46:01 +0000 (14:46 -0500)]
bug 3049: display correct due date of renewed loans

The intranet item display provided by moredetail.pl
would display the original due date of the item, and
would thus be incorrect if the item had been renewed
and got a different due date.

The incorrect date was coming from items.onloan,
which AddIssue() sets to the due date.  This patch
fixes the bug in two ways:

[1] AddRenewal() now updates items.onloan with the
    correct due date.
[2] Two templates were updated to display the
    due date from (indirectly) issues.date_due
    instead of items.onloan, thus making it less
    likely that the wrong value will be displayed.

This patch does *not* update items.onloan to reflect
the correct due date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2919 -- fix value_builder plugins for dateaccessioned, barcode
Joe Atzberger [Thu, 5 Feb 2009 19:04:20 +0000 (13:04 -0600)]
Bug 2919 -- fix value_builder plugins for dateaccessioned, barcode

This patch depends on my previous one "Begin cleanup on additem" and
fixes one bug introduced in that patch.

Overhaul of additem sections to factor out common pieces especially attributes.
Plugin js vastly simplified and reimplemented in jquery.  Performance improved.

Note that a particularly busy cataloging department should still leave
barcode blank for server-side autopopulation to avoid collision.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBegin cleanup on additem.
Joe Atzberger [Wed, 21 Jan 2009 01:18:21 +0000 (19:18 -0600)]
Begin cleanup on additem.

REFACTOR logic out of conditional branches when the assignment ($nextop) is the same.
Be sure to EXIT after printing a redirect, instead of wasting clock filling in the
template for a process the user will never see.  Remove  the now inapplicable logic for
differentiation between "/cgi-bin" and "non /cgi-bin" installations.  There is no
longer any /cgi-bin in the actual directory file path.

This does not fix the value_builder js errors like "Blurbarcode52251 is not defined",
but it does not cause them either (see Bug 2919).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoMinor markup corrections for validity.
Owen Leonard [Wed, 8 Apr 2009 18:39:37 +0000 (13:39 -0500)]
Minor markup corrections for validity.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoauto truncation was not used
Henri-Damien LAURENT [Fri, 3 Apr 2009 10:28:24 +0000 (12:28 +0200)]
auto truncation was not used

Auto truncation now works on LTR languages
For RTL languages(Arab, Hebrew), development should be really improved.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoIntroduce sth caching to Letters.pm
Joe Atzberger [Fri, 27 Mar 2009 15:34:34 +0000 (10:34 -0500)]
Introduce sth caching to Letters.pm

The re-creation of statement handles for the same queries, repeatedly,
seriously degrades the performance of notices.  This introduces new
class-level caching to avoid that problem.

Note: initial provisions
to do the same with caching of COLUMNS information about tables is
also included, but this would probably be most usefully implemented
in C4::Context (or a separate more central module).  The benefits of
caching that info would probably be even greater.  Note that this
proposed implementation might be obsoleted by ORM integration, where
DB structure info would already be cached.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoPartial fix for Bug 2655, "Items waiting on the hold shelf display as 'Available...
Owen Leonard [Mon, 6 Apr 2009 13:50:51 +0000 (08:50 -0500)]
Partial fix for Bug 2655, "Items waiting on the hold shelf display as 'Available' in OPAC"

GetItemsInfo() returns a count_reserves variable which may be "Waiting" or "Reserved," but opac-detail.pl didn't include a check for these possibilities. This patch has opac-detail.tmpl output "On hold" in either case.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoperltidy finishreceive.pl and two comments added
Joe Atzberger [Tue, 7 Apr 2009 22:37:50 +0000 (17:37 -0500)]
perltidy finishreceive.pl and two comments added

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3090 - Add perldoc details
Joe Atzberger [Tue, 7 Apr 2009 22:37:55 +0000 (17:37 -0500)]
Bug 3090 - Add perldoc details

This is half of the fix for 3090.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoparcel.pl cleanup
Joe Atzberger [Tue, 7 Apr 2009 22:37:52 +0000 (17:37 -0500)]
parcel.pl cleanup

It looks like a lot of change, but it isn't much:
perltidy, removed unused "toggle" code, and corrected comments.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoorderreceive cleanup
Joe Atzberger [Tue, 7 Apr 2009 22:37:49 +0000 (17:37 -0500)]
orderreceive cleanup

Convert to GetBranchesLoop, remove unused variables.
Pull out params that are assigned the same value in each loop and just assign them once.
Pull out params that are assigned the same value in each half of the conditional, and just assign them unconditionally.
Remove useless call of $template->param($count).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFix for Bug 3095, Add to lists page doesn't redirect with no javascript
Owen Leonard [Tue, 7 Apr 2009 19:21:18 +0000 (14:21 -0500)]
Fix for Bug 3095, Add to lists page doesn't redirect with no javascript

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoMarkup and style corrections.
Owen Leonard [Thu, 5 Mar 2009 20:37:49 +0000 (14:37 -0600)]
Markup and style corrections.

Corrects case of "onclick" and creates new style for "send" link rather than re-using inapplicable toolbar ID.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoremove incomplete bib bulk editing code
Galen Charlton [Mon, 6 Apr 2009 14:45:56 +0000 (09:45 -0500)]
remove incomplete bib bulk editing code

Per discussion I had with Henri, removing experimental
bulk editing from the staff search results code, as
feature is incomplete and can be dangerous if
one tries to use it on a large search result
set.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago3040 : seriestitle mistaken as collection title
Henri-Damien LAURENT [Mon, 16 Mar 2009 21:05:21 +0000 (22:05 +0100)]
3040 : seriestitle mistaken as collection title

If series title was previously taken as collectiontitle
then you should launch
misc/maintenance/UNIMARC_fix_collectiontitle.pl
misc/batchRebuildBiblioTables.pl

[RM note: applies only to UNIMARC users - MARC21
users should not run the batch jobs.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAnother try at fixing Bug 2949.
Owen Leonard [Sat, 4 Apr 2009 15:19:33 +0000 (10:19 -0500)]
Another try at fixing Bug 2949.

This fix is in circulation.tmpl instead of the search box include. That eliminates the clash with returns.pl. Focus works correctly when checking out, when circulation.pl is at its "empty" state, and when patron selection form is displayed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agorestored tab-delimited report download
Galen Charlton [Sun, 5 Apr 2009 16:29:32 +0000 (11:29 -0500)]
restored tab-delimited report download

Previous patch broke this, always providing the
guided report download in CSV format regardless of
whether CSV or tab-delimited was requested.

Also, default name of downloaded file is reportresults.csv
for CSV output and reportresults.tab for tab-delimited.

Also removed a couple subroutine prototypes that
were leading to unnecessary compile-time warnings
under use warnings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 3066 - Overhaul guided reports
Joe Atzberger [Tue, 31 Mar 2009 20:08:10 +0000 (15:08 -0500)]
Bug 3066 - Overhaul guided reports

execute_query now refactored, returns reliable results, does
zero presentation-layer crap.  Arguments reduced, client scripts
adapted to new API and performance improved.  Text::CSV now used
to generate CSV output, ensuring portability, encoding and accuracy.

Replaced tools/runreport.pl with misc/cronjobs/runreport.pl:
    ~ security fixed
    ~ documentation improved
    ~ TODO: finish sendmail option.

Bug 3077 also fixed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCondense inarticulate construction of TMPL structures.
Joe Atzberger [Thu, 26 Mar 2009 15:59:17 +0000 (10:59 -0500)]
Condense inarticulate construction of TMPL structures.

Use map to replace multiple temporary hash constructions.
Also a minor POD fix.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agorunreport.pl and prep work on Guided.pm
Joe Atzberger [Fri, 27 Mar 2009 15:34:33 +0000 (10:34 -0500)]
runreport.pl and prep work on Guided.pm

The old location of runreport.pl was under tools, leaving it exposed
to web requests.  This is a security flaw since it does NOT check any
Auth and allows the user to request any Saved Report be run.  This is
not a problem under misc/crontab/ and it suggests the more appropriate use.

Guided.pm is not fixed here (see bug 3066), but it is prepared to be fixed
and made compatible with runreport as detailed in the perldoc.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agopatch for bug-3017
Mason James [Mon, 9 Mar 2009 02:13:06 +0000 (15:13 +1300)]
patch for bug-3017

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoInternationalize Amazon support
Frédéric Demians [Wed, 1 Apr 2009 19:36:28 +0000 (21:36 +0200)]
Internationalize Amazon support

With this patch:

  * On Amazon book cover, 'search inside' text is not displayed
    anymore because it's not translatable.
  * Link the image to local Amazon web site 'search inside' service.
    Based on AmazonLocale syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoUpdated INSTALL.debian
David Bavousett [Thu, 18 Sep 2008 16:43:46 +0000 (11:43 -0500)]
Updated INSTALL.debian

Modified INSTALL.debian to update install and web
configuration instructions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoChanges to installed indexing.
J. David Bavousett [Fri, 26 Dec 2008 22:12:06 +0000 (16:12 -0600)]
Changes to installed indexing.

These changes tidy up ISBN and ISSN indexing, per Michele Maenpaa.  It's being
set up manually on many new installations, and probably ought to become part of the default
Koha installation.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoChanges to bulkmarcimport.pl
J. David Bavousett [Fri, 26 Dec 2008 21:56:55 +0000 (15:56 -0600)]
Changes to bulkmarcimport.pl

Adds three new switches:

-idmap <filename> - optional output file of
                    map of source record ID numbers
                    to Koha biblionumber
-x                - if idmap is supplied, MARC tag
                    to get source record ID from
-y                - if idmap is supplied, MARC subfield
                    to get source record ID from

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoModifications to C4/Matcher for colon and ending punctuation
J. David Bavousett [Fri, 26 Dec 2008 21:38:00 +0000 (15:38 -0600)]
Modifications to C4/Matcher for colon and ending punctuation

Recommended by Michele Maenpaa, this adds handling colon and end-punctuation stripping
in subroutine _normalize, and fixes length testing in subroutine _get_match_keys

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdded ISBN to RSS results.
J. David Bavousett [Fri, 30 Jan 2009 16:05:46 +0000 (10:05 -0600)]
Added ISBN to RSS results.

Added ISBN tag to RSS results, right after the title.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCorrected: Hiding renew link in the OPAC for items which cannot be renewed. Fixes...
Owen Leonard [Wed, 1 Apr 2009 18:17:54 +0000 (13:17 -0500)]
Corrected: Hiding renew link in the OPAC for items which cannot be renewed. Fixes bug 3083.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #3084) in baskets, change the isbn of column
Nahuel ANGELINETTI [Thu, 2 Apr 2009 13:34:30 +0000 (15:34 +0200)]
(bug #3084) in baskets, change the isbn of column

this patch add a new column and put the isbn in it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdding details to OPAC search results RSS, described in Bug 2973.
Owen Leonard [Thu, 2 Apr 2009 19:06:33 +0000 (14:06 -0500)]
Adding details to OPAC search results RSS, described in Bug 2973.

This includes a change to Search.pm to add a variable, subtitle_nospan, in order to display subtitles in the feed without search term highlighting HTML. The modified template attempts to display Amazon, Syndetics, or Baker & Taylor book cover images. Google images are not included because they require Javascript.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 3088: fix crash in opac-ISBDdetail.pl
Galen Charlton [Fri, 3 Apr 2009 23:15:08 +0000 (18:15 -0500)]
bug 3088: fix crash in opac-ISBDdetail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoadded dependencies for new OAI-PMH server
Galen Charlton [Wed, 1 Apr 2009 16:49:43 +0000 (11:49 -0500)]
added dependencies for new OAI-PMH server

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdd a UNIMARC to Dublin Core XSL
Frédéric Demians [Thu, 26 Mar 2009 20:54:25 +0000 (21:54 +0100)]
Add a UNIMARC to Dublin Core XSL

This XSL transforms XML UNIMARC biblio record into
its DC representation. It is the equivalent of
MARC21slimOAIDC.xsl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdd another OAI server
Frederic Demians [Thu, 26 Mar 2009 20:54:24 +0000 (21:54 +0100)]
Add another OAI server

This OAI server has those characteristics:

   * It doesn't use C4::OAI anymore.
   * It uses HTTP::OAI library which is easily expandable.
   * XML result is not build anymore directly but using
     XML::SAX::Writer. It should solve encoding and XML related issues.
   * It returns two formats: oai_dc and marcxml.
   * DC is generated from biblioitems.marcxml by applying XSLT
     (MARC21slim2OAIDC.xsl or UNIMARCslim2OAIDC.xsl).
   * It uses the same tokens as previous OAI server (thanks Philippe
     Jaillon).
   * There is no more sets (it wasn't operational in previous version).

Add two new dependencies:

   * HTTP::OAI
   * XML::SAX::Writer
     available as a Debian package: libxml-sax-writer-perl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug #3071 - Z39.50 search result highlights are mixed
Frédéric Demians [Sun, 29 Mar 2009 08:55:34 +0000 (10:55 +0200)]
Bug #3071 - Z39.50 search result highlights are mixed

This patch modifies z3950 search result page in order to
use jquery to highlight rows rather than an explicit
css class.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFix Amazon cover for UNIMARC
Frédéric Demians [Mon, 30 Mar 2009 06:42:22 +0000 (08:42 +0200)]
Fix Amazon cover for UNIMARC

In UNIMARC, 010 tag contains ISBN. In UNIMARC, ISBN with '-'
are valid. This patch modify ISBN normalization in order to
automaticaly suppress '-' before sending ISBN to Amazon
to get book cover.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBUG-1503: fixes broken matching for 'hidden' values.
Mason James [Sun, 29 Mar 2009 23:54:15 +0000 (12:54 +1300)]
BUG-1503: fixes broken matching for 'hidden' values.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix to ignore 600$2 'Source of heading' fields for MARC21 subject display
Mason James [Wed, 1 Apr 2009 04:11:13 +0000 (17:11 +1300)]
fix to ignore 600$2 'Source of heading' fields for MARC21 subject display

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdding patron address to select patron form.
Owen Leonard [Mon, 30 Mar 2009 16:15:04 +0000 (11:15 -0500)]
Adding patron address to select patron form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoImprove performance and fault tolerance for sync_items...
Joe Atzberger [Mon, 23 Mar 2009 21:25:21 +0000 (16:25 -0500)]
Improve performance and fault tolerance for sync_items...

Pulled the GetMarcFromKohaField outside the loop, since we only need to
check it once.  Same for $item_sth.  Added safety checks for success of
delete_field and GetMarcItem, with warnings on failure.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agocleanup some of value_builder MARC21 plugins
Joe Atzberger [Fri, 13 Mar 2009 19:22:43 +0000 (14:22 -0500)]
cleanup some of value_builder MARC21 plugins

Tons of unnecessary dependencies removed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>