]> git.koha-community.org Git - koha.git/log
koha.git
11 years agoRevert "Bug 7167: Adds Unit tests for C4::Update::Database"
Jared Camins-Esakov [Thu, 27 Dec 2012 19:02:52 +0000 (14:02 -0500)]
Revert "Bug 7167: Adds Unit tests for C4::Update::Database"

This reverts commit 69c19e28b49d1732601c79c9aacf8de4b754b9d8.

11 years agoRevert "Bug 7167: Set final updatedatabase.pl version"
Jared Camins-Esakov [Thu, 27 Dec 2012 19:02:50 +0000 (14:02 -0500)]
Revert "Bug 7167: Set final updatedatabase.pl version"

This reverts commit c34017336c3cd03f471b1c5100b9f6b4dbe589db.

11 years agoBug 7167: Set final updatedatabase.pl version
Jared Camins-Esakov [Thu, 27 Dec 2012 16:17:00 +0000 (11:17 -0500)]
Bug 7167: Set final updatedatabase.pl version

11 years agoBug 7167: Adds Unit tests for C4::Update::Database
Jonathan Druart [Mon, 3 Dec 2012 14:27:46 +0000 (15:27 +0100)]
Bug 7167: Adds Unit tests for C4::Update::Database

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
11 years agoBug 7167: Followup: Removes useless global variables
Jonathan Druart [Mon, 3 Dec 2012 15:39:10 +0000 (16:39 +0100)]
Bug 7167: Followup: Removes useless global variables

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
11 years agoBug 7167 follow-up setting DBrevision, before pushing
Paul Poulain [Wed, 28 Nov 2012 13:48:28 +0000 (14:48 +0100)]
Bug 7167 follow-up setting DBrevision, before pushing

The 2 files C4/Auth.pm and install.pl *must* have the $version variable
set to what is the last old-mechanism for updatedatabase

This patch set to 3.11.00001 that is the last number when I QA this patch

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
11 years agoBug 7167: New version for updatedatabase
Jonathan Druart [Thu, 14 Jun 2012 09:46:57 +0000 (11:46 +0200)]
Bug 7167: New version for updatedatabase

This patch use DataTable, see BUG|BZ 6836
      - css/datatables.css
      - lib/jquery/plugins/jquery.dataTables.min.js
      - js/datatables.js

http://bugs.koha-community.org/show_bug.cgi?id=7167

Bug 7167 follow-up

Major changes:
* creating database tables for update on the fly, the  1st time the update script is called
* version is checked on mainpage.pl (and here only). If syspref Version differ from kohaversion.pl, the old updatedatabase is launched. If there are updates missing from new mechanism, the updatedatabase page is reached
* kohaversion check on each page is now useless in Auth.pm, removed dead code
* Updated installer: at the end of the process, retrieve all updates and automatically mark them "OK", as they're included in installer

Minor changes:
* adding copyright
* adding poddoc
* updating a warning, for better clarity
* switching from $$var to $var->
* small TT glitch fixed in updatedatabase.tt
* about.pl now returns the Version systempreference PLUS all the patches that have been applied

Bug 7167 follow-up perlcritic & numbers display & partial apply depending on DEBUG

* add use strict to updatedatabase, that is now perlcritic compliant
* partial apply of DB revs is now managed by DEBUG env variable = if DEBUG=0, the user can just apply every DBrev. If DEBUG=1, we're in a dev env, the user know has the option to apply DBrevs one by one
Display:
* in updatedatabase, small spelling changes
* in about.pl, remove 0 just after . (3.06.01 is displayed as 3.6.1)
* improve the display of applied numbers on about.pl
 - before this patch, if you have N, N+1, N+2, N+3 and N+10 DB rev applied, about was displaying : , N+1 / N+2 / N+3 / N+10
 - after this patch you have N......N+3 / N+10
* add ORDER BY into list_versions_already_knows to have number retrieved in the same order whatever the order they are applied

http://bugs.koha-community.org/show_bug.cgi?id=6679
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: Improve the update.pl script

 * Added CLI options to update.pl
 * Call update.pl from the installer.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: Now, we check versions on mainpage.pl and after login

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: Reimplementing Marcel's suggestions & fixes

 * Fixing the bugguy old version check (that was made against 3.0900000 instead of 3.0900027 -the last current kohaversion number
 * in the CLI script, if there is nothing to report, just say it

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Bug 7167: Remove check_coherency

As suggested by Katrin, we've removed the call to check_coherency. It intended to provide readable comments when some SQL was wrong. Removing this sub result in the SQL error being displayed. That's OK because the sysadmin or the developer can google the error, understand it, then fix it.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: Changing in .sql parsing

We first split on delimiter and then extract comments. You can now put
\n for delimiter comments.
ex:

DELIMITER ;
-- this is a comment
SELECT * FROM  my_table;
-- another comment

Before this patch, we had to write:
DELIMITER ;
-- this is a comment;
SELECT * FROM  my_table;
-- another comment;

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: Add .pl and .sql examples

Those files are in version directory, so will never be executed by the updater
If you want to provide an update, do it in a 3.09/ directory (if your update is expected for 3.10 version)

Note that the updater use a md5sum checker. So, if the same update is in 2 different places, it will be detected. That will be handy for changes made on both stable and master: a library running stable will get the update when updating. When upgrading to the next major release, Koha will detect the patch has already been applied, and no error will be thrown. With the previous mechanism, a DBRev ported to stable was re-executed when upgrading to master, resulting in a nasty (but usually harmless) error message

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: Improve display + factorize get_queries

Despite it's size, this patch is dealing with display questions only:
 * The text "comments" and "queries" was hardcoded in ajax-updatedb-getinfo.pl script. It has been replaced by a JSON call, returning 2 separate values, "comments:" and "queries:" is now in the template, making it translatable
 * Some minor tweak in the display (like putting things in bold, displaying OK in green, warnings in yellow and KO in red)
 * Reordering the column headers for more readability:
    * Status column is merged with availability, column is after status
    * Status/availability terms more clear: "Not applied" instead of "unknown", "Applied and OK", "Applied and failed", "Applied and forced" are the 3 other statuses
    * Removed one click to display comments on DBREv not yet applied: before the patch, one had to click "Show details", then "Get comments", now, "Get comments" is enough

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: FIX typos & moving a script to a proper place

* renamed availables to available
* renamed already_knows to already_applied
* fixed FSF & copyright headers
* removing a "use strict" because we already had use Modern::Perl
* fixed a tiny typo in about.tt

* moving update.pl to misc/bin because it's a CLI script

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: Add dependency File::Find::Rule

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: We want to execute non-numeric version with the -all option

Dealing with Marcel comment 100:
> Note that the current code around line 52/53 does not
> handle that correctly:
> Argument "\x{74}\x{65}..." isn't numeric in numeric ge (>=) at
> installer/data/mysql/update.pl line 52.

Now, a non-numeric DBRev will be applied if you provide the --all parameter, without throwing the error

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167 reindentation & removing dead code

* The if (! defined $ENV{PERL5LIB}... block was wrongly intented
* The 3 lines running update.pl are useless: the update (new mechanism) is run from admin/updatedatabase.pl script. This part of install.pl is run only when you have "old style" DB revisions.

Summary:
 * old mechanism = it's run as previously, by reaching the installer/install.pl?step=3 page, that applies all revisions
 * new mechanism = when you log-in or reach mainpage.pl, you reach admin/updatedatabase.pl, where you can see what will be run, and run it

Tiny side effect = the check for old mechanism is now done *after* authentification (thus it's not done on each page call). It means that the user will have to enter login/password twice :
 * first to log-in to Koha
 * second to run installer/updatedatabase.pl?step=3
As the old mechanism is deprecated, we can expect this will happend only a few time in the history of a setup, it's not a big deal.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: Don't raise an error in routine TableExists

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: FIX merge

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: Add .pl and .sql examples

Those files are in version directory, so will never be executed by the updater
If you want to provide an update, do it in a 3.09/ directory (if your update is expected for 3.10 version)

Note that the updater use a md5sum checker. So, if the same update is in 2 different places, it will be detected. That will be handy for changes made on both stable and master: a library running stable will get the update when updating. When upgrading to the next major release, Koha will detect the patch has already been applied, and no error will be thrown. With the previous mechanism, a DBRev ported to stable was re-executed when upgrading to master, resulting in a nasty (but usually harmless) error message

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167 follow-up fix POD syntax to please koha-qa.pl
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoAdd Bernardo Gonzalez Kriegel to history
Jared Camins-Esakov [Thu, 27 Dec 2012 15:17:27 +0000 (10:17 -0500)]
Add Bernardo Gonzalez Kriegel to history

Welcome, Bernardo, you are the 198th committer to Koha!

11 years agoBug 9315: Bad version of String::Random reported by koha_perl_deps.pl
Bernardo Gonzalez Kriegel [Fri, 21 Dec 2012 22:22:45 +0000 (19:22 -0300)]
Bug 9315: Bad version of String::Random reported by koha_perl_deps.pl

This patch fixes version number of String::Random as reported by
koha_perl_deps.pl

To test (on master)
1) run perl koha_perl_deps.pl -u, it will show as required String::Random version 1.4
2) apply the patch
3) run koha_perl_deps.pl -u, it will show (or not) as required String::Random version 0.22

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Patch works correctly according to the test plan.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_7368' into 3.12-master
Jared Camins-Esakov [Thu, 27 Dec 2012 15:14:45 +0000 (10:14 -0500)]
Merge branch 'bug_7368' into 3.12-master

11 years agoBug 7368: Update GetXmlBiblio documentation
Marcel de Rooy [Mon, 10 Dec 2012 08:30:08 +0000 (09:30 +0100)]
Bug 7368: Update GetXmlBiblio documentation

Only changing some documentation about GetXmlBiblio

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Added the word 'contain'

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
11 years agoMerge branch 'bug_7143' into 3.12-master
Jared Camins-Esakov [Thu, 27 Dec 2012 15:12:16 +0000 (10:12 -0500)]
Merge branch 'bug_7143' into 3.12-master

11 years agoBug 7143 adding Kiriaki Roditi as translator
Paul Poulain [Tue, 18 Dec 2012 17:14:06 +0000 (18:14 +0100)]
Bug 7143 adding Kiriaki Roditi as translator

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
11 years agoBug 9183: Refactor ZOOM event loop
Jared Camins-Esakov [Sat, 1 Dec 2012 03:45:48 +0000 (22:45 -0500)]
Bug 9183: Refactor ZOOM event loop

Prior to this patch, there were three identical ZOOM event loops in
C4::Search. This is wasteful, and goes against all good programming
practice. This patch refactors the ZOOM event loops into a separate
subroutine which is called by SimpleSearch, searchResults, and
GetDistinctValues call.

The new routine, _ZOOM_event_loop process the ZOOM event loop and,
once it has been fully processed, passes control to a closure provided
by the calling routine for processing the results, and destroys the
result sets.

To test (after applying patch):
1) Do a regular bibliographic search that should return results.
2) Do a search in the Cataloging module that should return results.
3) If you get results from both searches, the patch works.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9009: Increment version number
Jared Camins-Esakov [Thu, 27 Dec 2012 15:05:56 +0000 (10:05 -0500)]
Bug 9009: Increment version number

Database update for bug 9009 has been given version 3.11.00.014

11 years agoBug 9009 - Add separate user js and css for SCO module
Kyle M Hall [Mon, 5 Nov 2012 17:22:24 +0000 (12:22 -0500)]
Bug 9009 - Add separate user js and css for SCO module

Add system preferences SCOUserCSS and SCOUserJS to define separate CSS and JavaScript for the Self Checkout Module.

Test plan:
1) Apply patch
2) Run updatedatabase.pl
3) Add something arbitrary to the new sysprefs SCOUserCSS and SCOUserJS ( such as TestCSS and TestJS ).
4) Load the SCO module in a browser, and view the HTML, verify the CSS and JS values in the system preferences have been included.

Signed-off-by: Marc Veron <veron@veron.ch>
I tested with an alert('hello') as JavaScript and some background-color for the CSS. Worked as expected.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9162: Increment version number
Jared Camins-Esakov [Thu, 27 Dec 2012 14:57:27 +0000 (09:57 -0500)]
Bug 9162: Increment version number

Database update for bug 9162 has been given version 3.11.00.013

11 years agoBUG 9162 - Add a system preference to set which notes fields appears on title notes...
Vitor FERNANDES [Wed, 28 Nov 2012 11:07:54 +0000 (11:07 +0000)]
BUG 9162 - Add a system preference to set which notes fields appears on title notes/description separator

Added a new system preference to control the fields to not appear in the separator.
Change GetMarcNotes to use the system preference created to only appear the fields that aren't in the list,

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
FIX some indentation in C4/Biblio.pm
+FIX 1 end of parentheses in sysprefs.sql
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9206: Increment version number
Jared Camins-Esakov [Thu, 27 Dec 2012 14:48:58 +0000 (09:48 -0500)]
Bug 9206: Increment version number

Database update for bug 9206 has been given version 3.11.00.012

11 years agoBug 9206: Followup QA FIX
Jonathan Druart [Wed, 26 Dec 2012 13:52:52 +0000 (14:52 +0100)]
Bug 9206: Followup QA FIX

- Fix indentation
- It is useless to loop on all items. If at least 1 item is already
  issued, we want to return 1.

11 years agoBug 9206 - Only allow place holds in records that the patron don't have in his posses...
Kyle M Hall [Fri, 14 Dec 2012 14:13:49 +0000 (09:13 -0500)]
Bug 9206 - Only allow place holds in records that the patron don't have in his possession - QA Followup

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
11 years agoBug 9206 - Only allow place holds in records that the patron don't have in his possession
Vitor FERNANDES [Tue, 4 Dec 2012 15:57:35 +0000 (15:57 +0000)]
Bug 9206 - Only allow place holds in records that the patron don't have in his possession

Added a system preference to turn on/off this feature.
By default the system allow the patron to place holds even if it is in his possession.
Script to place holds check if the system preference is off and if patron has at least one item to block holds.
Messages to say that are already in patron possession added to templates.
Method to check if patron has one issue from one record added to C4::Circulation

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8377 follow-up: fix update message
Jared Camins-Esakov [Thu, 27 Dec 2012 14:45:50 +0000 (09:45 -0500)]
Bug 8377 follow-up: fix update message

Add the bug number to the updatedatabase message.

11 years agoBug 8377: Increment version number
Jared Camins-Esakov [Thu, 27 Dec 2012 14:28:29 +0000 (09:28 -0500)]
Bug 8377: Increment version number

Database update for bug 8377 has been given version 3.11.00.011

11 years agoBug 8377: Followup move style in a css file and do not pass template to a pm
Jonathan Druart [Fri, 9 Nov 2012 14:12:59 +0000 (15:12 +0100)]
Bug 8377: Followup move style in a css file and do not pass template to a pm

1/ It's better to set style of the video marked in a css file.

2/ Replace some
  for my $i in (0..#$array)
with
  for my $element in (@array)

3/ the routine in a pm returns a hash not the $template variable

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client
Mirko Tietgen [Thu, 22 Nov 2012 12:22:22 +0000 (13:22 +0100)]
Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client

This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio.

Rebased to Master 22.11.2012

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7620: OPACNoResult, Add keyword to query string
Lyon3 Team [Thu, 11 Oct 2012 14:12:48 +0000 (16:12 +0200)]
Bug 7620: OPACNoResult, Add keyword to query string

When search failed, this patch gets the keyword(s) and add them
to the string entered by the user to OPACNoResultFound

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9169 - Wrap relator code in <span> to allow for CSS customization
Owen Leonard [Thu, 29 Nov 2012 16:32:52 +0000 (11:32 -0500)]
Bug 9169 - Wrap relator code in <span> to allow for CSS customization

This patch adds <span class="relatorcode"> around the display of
relator codes in the OPAC and the staff client, and adds a space
before the bracket (" [relatorcode]") for readability.

To test, add custom CSS to OPACUserCSS and IntranetUserCSS and
view a record which includes relator code data. Suggested:

.relatorcode {
    background-color: rgb(230, 240, 242);
    border-radius: 3px 3px 3px 3px;
    color: rgb(51, 51, 51);
    display: inline-block;
    font-size: 75%;
    font-weight: normal;
    margin-left: 0.4em;
    padding: 0.1em 0.4em;
}

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9158: correcting whitespace in series (440) display
Chris Hall [Tue, 27 Nov 2012 23:41:28 +0000 (12:41 +1300)]
Bug 9158: correcting whitespace in series (440) display

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch changes 'first; second; third.' to 'first ; second ; third.'

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8955 [Follow-up] Self checkout should degrade gracefully w/o JavaScript
Owen Leonard [Tue, 6 Nov 2012 16:14:44 +0000 (11:14 -0500)]
Bug 8955 [Follow-up] Self checkout should degrade gracefully w/o JavaScript

This follow-up fixes some instance of unnecessary JavaScript
which I missed the first time around: The renew and check-in
buttons on the list of checkouts. The functionality can be
easily accomplished without JS.

Also corrected:

- Capitalization error
- Miss-named variable causing the "too many checkouts" not
  to be displayed
- Misplaced [% END %] tags hidding "Return to account" button
  on some dialogs.
- Corrected variable scope error which prevented the "return"
  button from appearing.

To test, log into self checkout using an account which has
checkouts. Testing renewing items both by scanning barcodes
and by clicking the "renew" button in the list of checkouts.

Renew something until it reaches its limit and test checking
it out by scanning the barcode. Test the "check in" button.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8955 - Self checkout should degrade gracefully with JavaScript turned off
Owen Leonard [Wed, 24 Oct 2012 15:02:28 +0000 (11:02 -0400)]
Bug 8955 - Self checkout should degrade gracefully with JavaScript turned off

Several changes in this patch, the largest of which is that the
renew/return dialogs no longer require JavaScript in order to properly
alter and submit the form. Instead each button uses a separate form.

To test, log in to self checkout and submit a barcode which is checked
out and can be renewd, and a barcode which is checked out but has
reached the checkout limit. On the resulting dialogs each button
should function properly.

Also changed: I removed some useless JavaScript processing related
to a bogus "valid_session" variable which was unused.

Similarly removed is template logic based on a "timedout" variable which
was not set by the script. Note that the script contains NO server-
side handling of timeout. Timeout is dependent on JavaScript.

To test these changes, confirm that with JavaScript enabled you are
automatically logged out after the time specified in the SelfCheckTimeout
preference.

Other minor changes: Terminology and capitalization corrections,
minor style tweaks.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9278 - Remove unused OPAC CSS file sanop.css
Owen Leonard [Wed, 12 Dec 2012 20:47:55 +0000 (15:47 -0500)]
Bug 9278 - Remove unused OPAC CSS file sanop.css

This patch removes an unused CSS file, sanop.css, included in both OPAC
themes even though it is referenced by neither.

To test, apply the patch and listen for the unhappy protestations of
libraries whose OPACs now look different. If there are none, the
patch works.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
According to Paul's answer (on the mailing list), I sign off this
patch.

Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Seems to work as advertised
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9112 : update of Italian SQL files
Zeno Tajoli [Tue, 20 Nov 2012 13:56:11 +0000 (14:56 +0100)]
Bug 9112 : update of Italian SQL files

This patch is only for Italian SQL setup, it updates files auth_val.sql
and userpermissions.sql. For circulation permissions and REPORT_GROUP
example.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9105: Second housekeeping followup
Marcel de Rooy [Thu, 22 Nov 2012 08:32:42 +0000 (09:32 +0100)]
Bug 9105: Second housekeeping followup

Removing some unused variables.
Restoring timeout parameter that was only used in cataloging.
Restoring copyrightdate and editionstatement in row data for template.
Small adjustment at the end of the while loop with template vars.

Discovered while doing so, that the paging feature needs some further corrections; will propose a patch under a separate report.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9105: Housekeeping followup
Marcel de Rooy [Wed, 21 Nov 2012 13:50:10 +0000 (14:50 +0100)]
Bug 9105: Housekeeping followup

Remove some debug warnings, fix indentation

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9105: Move Z3950 search code to Breeding module
Marcel de Rooy [Mon, 19 Nov 2012 12:53:49 +0000 (13:53 +0100)]
Bug 9105: Move Z3950 search code to Breeding module

As a first step in realizing the goals of report 6536 (Z3950 Search improvements), this patch moves identical code in acquisition and cataloging to module level.
A followup deals with formatting.
Note that this patch should not change any behavior.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I did not find any regression

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9140: Followup removes the useless variable $message
Jonathan Druart [Tue, 4 Dec 2012 15:56:54 +0000 (16:56 +0100)]
Bug 9140: Followup removes the useless variable $message

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9140 - Untranslatable strings in item circulation history
Owen Leonard [Mon, 26 Nov 2012 14:24:28 +0000 (09:24 -0500)]
Bug 9140 - Untranslatable strings in item circulation history

This patch removes the text of a message from the script
to the template. The lastmove sub now returns either the date
or 0, and the template displays the "no transfers" message
if the date doesn't exist.

To test, view the circulation history for items which
do and do not have a transfer history. A date should be displayed
for items which have a transfer history. A messages should
be displayed for those which do not.

This patch also adds a <span> around the text "Never" which
was not getting picked up by the translation script. To test
this change, run "perl translate update <lang>" from misc/translator,
then check if the string shows up in the po file. (Thanks kf!)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_9136' into 3.12-master
Jared Camins-Esakov [Sat, 22 Dec 2012 20:54:10 +0000 (15:54 -0500)]
Merge branch 'bug_9136' into 3.12-master

11 years agoMerge branch 'bug_9151' into 3.12-master
Jared Camins-Esakov [Sat, 22 Dec 2012 20:53:56 +0000 (15:53 -0500)]
Merge branch 'bug_9151' into 3.12-master

11 years agoBug 9151 follow-up: correct name in sysprefs.sql
Jared Camins-Esakov [Sat, 22 Dec 2012 20:52:58 +0000 (15:52 -0500)]
Bug 9151 follow-up: correct name in sysprefs.sql

Rather than creating the syspref RenewalSendNotice, sysprefs.sql
was creating the syspref RenewalSendNotices, which was incorrect.

11 years agoBug 9136: C4::Tags not Plack-compatible
Jared Camins-Esakov [Fri, 23 Nov 2012 19:14:16 +0000 (14:14 -0500)]
Bug 9136: C4::Tags not Plack-compatible

The three module-scoped variables $ext_dict, @fields, and $select_all
were preventing tagging code from working under Plack. I fixed this
by changing the latter two to compile-time constants, and declared the
first with "our $ext_dict;"

To test (under Plack):
1) Try to create a tag before the patch is applied. Note that you get a
   500 error in the AJAX request.
2) Apply patch.
3) Repeat step (1), noticing that this time the tag is created and there
   is no error.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9260: stop koha-run-backups complaining "missing ]"
MJ Ray [Tue, 11 Dec 2012 14:17:36 +0000 (14:17 +0000)]
Bug 9260: stop koha-run-backups complaining "missing ]"

Found because cron.daily/koha output contains the error "[: 97: missing ]"

To test:

  1. run koha-run-backups --days 2 --output /var/spool/koha
  2. should see no output

Sponsored-by: Library of the Józef Piłsudski Institute of America
Signed-off-by: Vitor FERNANDES <vfernandes@keep.pt>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I still get an error:
  ./koha-run-backups: 58: ./koha-run-backups: koha-list: not found
But this patch fixes the syntax error
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoAdd Nadia Nicolaides to history
Jared Camins-Esakov [Fri, 21 Dec 2012 12:44:09 +0000 (07:44 -0500)]
Add Nadia Nicolaides to history

Welcome, Nadia. You are the 197th person to commit a patch to Koha!

11 years agoFollow-up Bug 5634: Ordering branches should be case independent
Nadia Nicolaides [Wed, 19 Dec 2012 18:52:34 +0000 (15:52 -0300)]
Follow-up Bug 5634: Ordering branches should be case independent

This patch fix the order of branches in the log-in page,
on Branch.pm we added the variable branchcode to the
hash returned by GetBranchesLoop, and this function is used
on Auth.pm to get a list of branches ordered by branchname

To test
1) Use an installation with some branches
2) On login screen the branches are ordered by branchcode
3) apply the patch
4) On login screen the branches are now ordered by branchname

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch works as expected. Before applying the patch the branches
with lower case was at the end of the list. Now they are well ordered.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9151: Increment version number
Jared Camins-Esakov [Fri, 21 Dec 2012 12:41:27 +0000 (07:41 -0500)]
Bug 9151: Increment version number

Database update for bug 9151 has been given version 3.11.00.010

11 years agoBug 9151 follow-up: fr-FR translated to french
Paul Poulain [Thu, 20 Dec 2012 17:38:00 +0000 (18:38 +0100)]
Bug 9151 follow-up: fr-FR translated to french

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9151 - Renewal notice according to patron alert preferences - QA Followup - Fix...
Kyle M Hall [Fri, 7 Dec 2012 12:48:05 +0000 (07:48 -0500)]
Bug 9151 - Renewal notice according to patron alert preferences - QA Followup - Fix DB Revs & Grammar

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBUG 9151 - Renewal notice according to patron alert preferences (Patch 2)
Vitor FERNANDES [Tue, 27 Nov 2012 15:17:59 +0000 (15:17 +0000)]
BUG 9151 - Renewal notice according to patron alert preferences (Patch 2)

Added a system preferences (RenewalSendNotice - default no) to controll the renewal notice sending.
Added to installer languages the renewal notice template.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBUG 9151 - Renewal notice according to patron alert preferences
Vitor FERNANDES [Tue, 27 Nov 2012 12:42:18 +0000 (12:42 +0000)]
BUG 9151 - Renewal notice according to patron alert preferences

Modifications on AddRenewals and SendCirculationAlert in order to send a renewal notice to the patron according to the patron checkout alert preference.
Added a new notice template for renewals notices.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9235 - Hardcoded values in cronjobs/backup.sh
Tomas Cohen Arazi [Thu, 6 Dec 2012 19:53:17 +0000 (16:53 -0300)]
Bug 9235 - Hardcoded values in cronjobs/backup.sh

This patch makes the script read those parameters from the corresponding
$KOHA_CONF file.

Regards
To+

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8878 - a command to provide a shell with the koha environment
Robin Sheat [Fri, 5 Oct 2012 03:04:23 +0000 (16:04 +1300)]
Bug 8878 - a command to provide a shell with the koha environment

This command behaves something like su(1), but provides you with a shell
as the koha user, and with the environment pointing to the right places.

Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8795: Adding the login branch as default in orderreceive.tt
Christophe Croullebois [Thu, 20 Sep 2012 07:16:19 +0000 (09:16 +0200)]
Bug 8795: Adding the login branch as default in orderreceive.tt

The homebranch and holdingbranch ddl in item block are not default selected.
I just put the default choice as the login branch.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Before the patch, orderreceive.pl showed the branches alphabetically.
After the patch, it automatically selects the branch I'm logged in to.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9166: OPAC needs configuration file for datepicker
Owen Leonard [Thu, 29 Nov 2012 13:58:24 +0000 (08:58 -0500)]
Bug 9166: OPAC needs configuration file for datepicker

This patch adds a configuration include file for the datepicker.
This file makes redundant the datepicker initialization in
js/script.js, so that section is removed.

This change should enable two things: the CalendarFirstDayOfWeek
preference should now work in the OPAC, and the calendar should
now use the current selected language.

To test, try the calendar widget when placing a hold in the OPAC.
The CalendarFirstDayOfWeek preference should be respected for
Monday and Sunday. Switch languages. The calendar interface labels
should reflect the current chosen language.

Revision adds the configuration include to opac-user as well
(required by the suspend holds feature).

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
the datepicker plugin works for opac-reserve and opac-user

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoUpdate history with our newest committer
Jared Camins-Esakov [Wed, 19 Dec 2012 20:46:21 +0000 (15:46 -0500)]
Update history with our newest committer

Welcome, Vitor Fernandes!

11 years agoBug 9104: country in CSV in overdue_notices.pl
Fridolyn SOMERS [Mon, 3 Dec 2012 09:12:42 +0000 (10:12 +0100)]
Bug 9104: country in CSV in overdue_notices.pl

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Output of of the overdues script with -csv now contains country
from the first address in the patron account.

I checked output for 2 patrons, one with and one without country
in the patron's address.

All tests pass. Perlcritic fails before and after:
"require" statement with library name as string at line 29, column 12.
Use a bareword instead.  (Severity: 5)
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8125 Sip addess should include all address fields
Colin Campbell [Tue, 22 May 2012 10:11:33 +0000 (11:11 +0100)]
Bug 8125 Sip addess should include all address fields

Expansion of Liz Rea's original patch
Bug report specifically mentioned lack of the
Zip/Postal code but all used address fields should
be included. Moved the address
generation to its own sub.
Hopefully using an if else will read more clearly than
the original ternary operator proved to be

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9287 - socialnetworks is enabled by default
Mirko Tietgen [Fri, 14 Dec 2012 13:21:24 +0000 (14:21 +0100)]
Bug 9287 - socialnetworks is enabled by default

The socialnetworks feature is enabled by default after installing Koha. It shouldn't be.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9144 - bulkmarcimport.pl - Problem identifying errors
Vitor FERNANDES [Mon, 26 Nov 2012 11:23:15 +0000 (11:23 +0000)]
Bug 9144 - bulkmarcimport.pl - Problem identifying errors

Replace \r with \n for newline in output for bulkmarcimport.pl

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7674: Increment version number
Jared Camins-Esakov [Mon, 17 Dec 2012 14:42:56 +0000 (09:42 -0500)]
Bug 7674: Increment version number

Database update for bug 7674 has been given version 3.11.00.009

11 years agoBug 7674: Remove some debug code
Julian Maurice [Fri, 14 Dec 2012 08:58:02 +0000 (09:58 +0100)]
Bug 7674: Remove some debug code

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7674 - Followup - Add missing right-hand curly bracket
Kyle M Hall [Fri, 2 Nov 2012 12:11:00 +0000 (08:11 -0400)]
Bug 7674 - Followup - Add missing right-hand curly bracket

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and perlcritic pass.

Tests:

Database update
- OK, system preferences were added correctly
- Version number of updatedatabase was only XXX, changed to 3.11.00.XX

OPAC
1) Detail page
- OK, no visible change when OpacSeparateHoldings is turned off
- OK, switching OpacSeparateHoldingsBranch works correctly
- OK, shelf browser opens in correct tab
- OK, only one tab shows when logged out

INTRANET
2) Detail page
- OK, no visible change when SeparateHoldings is turned off
- Number of items is missing on top of the tabs

Notes:
- database update doesn't include bug number
- other holdings tab does show when there are 0 items at other branches,
  it could be hidden in those cases
- if there are over 50 items in the holdings or Other holdings tab, the
  warning and link 'This record has many physical items. Click here
  to view them all.' is only shown for the first tab.
- closing the shelf browser on the second tab goes back to first tab
- number ofitems is missing on top of the tabs
- there are lots of indentation changes in the second patch,
  this makes it very hard to see the changes, please provide separate
  patches in the future

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7674: Add 2 sysprefs to indicate the branch we want to separate on
Julian Maurice [Fri, 2 Nov 2012 10:03:20 +0000 (11:03 +0100)]
Bug 7674: Add 2 sysprefs to indicate the branch we want to separate on

The 2 sysprefs are SeparateHoldingsBranch and OpacSeparateHoldingsBranch
and permit to chose between home branch and holding branch.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7674: Open shelf browser in appropriate tab
Julian Maurice [Tue, 9 Oct 2012 15:01:58 +0000 (17:01 +0200)]
Bug 7674: Open shelf browser in appropriate tab

If you click on "Browse shelf" under "<mylibrary> holdings", shelf
browser should open under this tab.
If you click on "Browse shelf" under "other holdings" tab, it should
open under "other holdings" tab.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7674: Separate items in two tabs on biblio detail page (staff+opac)
Paul Poulain [Fri, 21 Sep 2012 08:36:56 +0000 (10:36 +0200)]
Bug 7674: Separate items in two tabs on biblio detail page (staff+opac)

Two tabs: "<branch> holdings" / "Other holdings"

"<branch> holdings" tab contains items whose homebranch is the current branch.
"Other holdings" tab contains all other items.

If current branch is not set (connected with mysql user or not logged in
(opac)), the display is unchanged (1 tab "Holdings")

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9052 - rewrite the YUI links to use the system library
Robin Sheat [Fri, 14 Dec 2012 02:45:40 +0000 (15:45 +1300)]
Bug 9052 - rewrite the YUI links to use the system library

This uses libjs-yui to provide the skin.css and reset-fonts-grids.css
files from YUI. It patches the CSS files to point to the right location
for the files.

To test:
* Build a package with this patch included
* Install it
* Look at the OPAC and note that things no longer look terrible, and
  that there are no 404's coming from bad CSS URLs.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
I created a package of 3.10+9052, installed and tested.
I confirm that the OPAC does not look broken anymore
and I could not find 404 errors with Firebug.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I also created a package of 3.10+9052 and removed libchi-* from the
debian/control file. The OPAC shows no problems using those packages,
layout, pictures and colors seem to all be in place.
Also the OPAC on master with patch applied still works as expected.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_9056' into 3.12-master
Jared Camins-Esakov [Fri, 14 Dec 2012 13:23:25 +0000 (08:23 -0500)]
Merge branch 'bug_9056' into 3.12-master

11 years agoBug 9056 follow-up: add missing \n to updatedatabase.pl
Jared Camins-Esakov [Fri, 14 Dec 2012 13:23:03 +0000 (08:23 -0500)]
Bug 9056 follow-up: add missing \n to updatedatabase.pl

11 years agoBug 7067: Increment version number
Jared Camins-Esakov [Fri, 14 Dec 2012 13:14:16 +0000 (08:14 -0500)]
Bug 7067: Increment version number

Database update for bug 7067 has been given version 3.11.00.008

11 years agoBug 7067 follow-up: fix updatedatabase.pl formatting
Jared Camins-Esakov [Fri, 14 Dec 2012 13:12:14 +0000 (08:12 -0500)]
Bug 7067 follow-up: fix updatedatabase.pl formatting

11 years agoBug 7067 - QA Followup - Fix error when confirming via email
Kyle M Hall [Fri, 14 Dec 2012 12:58:29 +0000 (07:58 -0500)]
Bug 7067 - QA Followup - Fix error when confirming via email

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7067 - Fix bad url in breadcrumbs
Kyle M Hall [Thu, 13 Dec 2012 18:13:21 +0000 (13:13 -0500)]
Bug 7067 - Fix bad url in breadcrumbs

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7067 - QA Followup - Fix failing tests
Kyle M Hall [Thu, 13 Dec 2012 18:10:52 +0000 (13:10 -0500)]
Bug 7067 - QA Followup - Fix failing tests

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7067 QA Followup - Add descriptions to tests
Kyle M Hall [Thu, 13 Dec 2012 17:28:02 +0000 (12:28 -0500)]
Bug 7067 QA Followup - Add descriptions to tests

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7067 QA Followup
Kyle M Hall [Mon, 10 Dec 2012 20:45:28 +0000 (15:45 -0500)]
Bug 7067 QA Followup

Adjusts calling conventions to use hashrefs and eliminate redundant
procedural/OO mixed code.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7067 Followup: FIX merge updatedatabase
Jonathan Druart [Thu, 29 Nov 2012 09:09:55 +0000 (10:09 +0100)]
Bug 7067 Followup: FIX merge updatedatabase

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7067: Followup FIX QA fails
Jonathan Druart [Thu, 25 Oct 2012 14:42:31 +0000 (16:42 +0200)]
Bug 7067: Followup FIX QA fails

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Fixed minor conflict in C4/Installer/PerlDependencies.pm
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7067 [Follow-up: templates] allow patron self registration via the opac
Owen Leonard [Fri, 14 Sep 2012 12:26:35 +0000 (08:26 -0400)]
Bug 7067 [Follow-up: templates] allow patron self registration via the opac

- Adding simple style to register link on home page
- Adding unique ids to new pages and to blocks containing
  registration links
- Adding better page titles and breadcrumb links to some pages
- Correcting bug which meant incorrect message showed on registration
  page when OPACPatronDetails preferences is turned off
- Passing patron details to opac-memberentry.tt so that patron's
  name can be displayed in breadcrumbs
- Improving display in staff client of patron record updates
  waiting to be approved.
- Adding a sort by name to output of pending patron record updates
- Adding updated JqueryUI library files to include expanded widget
  options.

The changes in this patch require the addition of the jQueryUI
Accordion widget. Other pending patches are seeking to add
enough of the other remaining missing widgets that it seems time
to go ahead and add the rest.

Future submissions which add usage of these widgets will have
to be careful to make changes to Koha's CSS where necessary.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 7067 - OPAC Borrower Self Registration
Kyle M Hall [Tue, 31 Jul 2012 14:07:04 +0000 (10:07 -0400)]
Bug 7067 - OPAC Borrower Self Registration

This development will add the ability for a new patron to register
himself or herself. The self-registration will attempt to match this
newly inputted data to any existing patrons and if any possible matches
are found, ask if the patron is sure he or she doesn't already have an
account at the library. A system preference may be set to prevent patron
self-registration if the system detects the possibility that the person
may already have an account.

Once the patron has registered, passing a captcha (or similar
bot-stopper), the patron will then be optionally verified a second time
via email. At this point, the patron will be able to print a temporary
library card (optional by system preference), and will be provided any
details necessary to access electronic resources (this body of text
would be a template in the slips and notices system). At the library's
choice, this new patron would either be set to a temporary patron status
(patron type set via system preference), or a fully-fledged patron
(allow patron type to be determined by age and/or other attributes).
Assuming the library uses temporary patron types for OPAC registrations,
this patron will next enter a queue and would need to physically enter
the library to verify himself and become a fully-fledged patron (most
likely by bringing in physical proof of address, etc.). The librarian
would look up the patron record and modify the patron type. If a
temporary patron has not been verified within a certain time frame
(defined by a system preference), the patron record will be deleted
from the system via a cron job.

For registered patrons, the system will allow each person to also
update his or her personal data via the OPAC. When a patron updates his
or her information, the changes will be entered into a queue to be
verified by a librarian (preventing a patron from inputting obviously
bogus data). The staff client home page will display the number of
patron records with changes awaiting approval. A librarian would then be
able to click through a list of modification requests, and approve or
deny each (with approval and denial alerts being sent to the patron via
the standard messaging system).

NEW SYSTEM PREFERENCES
* PatronSelfRegistration
* PatronSelfRegistrationDetectDuplicates
* PatronSelfRegistrationVerifyByEmail
* PatronSelfRegistrationPrintTemporaryCard
* PatronSelfRegistrationUseTemporaryStatus
* PatronSelfRegistrationExpireTemporaryAccountsDelay

NEW NOTICE
* Verify by email notice

NEW SLIP
* Temporary card slip

NEW CRON JOB
* delete_expired_opac_registrations.pl
  - Deletes patrons that have not been upgraded from the temporary
    status within the specified delay
* delete_unverified_opac_registrations.pl
  - Deletes the unverified patrons based on the length of time specified
    in the PatronSelfRegistrationExpireTemporaryAccountsDelay

The patron will register from self_registration.pl, linked off opac-main.pl if enabled. The registration page will be translatable to other languages in the same way that existing templates are.

Test Plan:
1) Enable PatronSelfRegistration
2) Set PatronSelfRegistrationExpireTemporaryAccountsDelay to a number
   of days
3) Create a self-registered borrower category
4) Set PatronSelfRegistrationUseTemporaryStatus
5) Set PatronSelfRegistrationVerifyByEmail to "Don't require"
6) Go to OPAC, log out if logged in.
7) You should see the "Register here" link below the login box
8) Attempt to register yourself
9) Verify you can log in with your temporary password.
10) Set PatronSelfRegistrationVerifyByEmail to "Require"
11) Attempt another self-registration
12) Check the messages table, you should see a new message with a
    verification link.
13) Copy and paste the link into a web browser to verify the registration
14) Log in with the given credentials to verify the account was created.

Test Plan - Part 2 - Borrower Modifications

1) Log in to OPAC, go to "my personal details" tab.
2) Make some modifications to your details.
3) Repeat steps 1 and 2 for two more borrowers.
4) Log in to Koha intranet with a user that can modify borrowers.
5) At the bottom of mainpage.pl, you should see:
  Patrons requesting modifications: 3
6) Click the link
7) Approve one change, deny a different one, and ignore the third, then
   submit.
8) Check the records, you should see the changes take affect on the
   approved one, and no changes to the other two. You should also see
   "Patrons requesting modifications: 1" at the bottom of mainpage.pl
   now.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Bug 7067 - OPAC Borrower Self Registration - Followup

* Rename PatronSelfRegistrationUseTemporaryStatus to PatronSelfRegistrationDefaultCategory
* Hide register link unless PatronSelfRegistrationDefaultCategory is set.
* Add invalid token page
* Add documentation and switches to cron scripts
* Add required fields check for editing exiting patrons
* Don't force require email address for existing patrons when
  PatronSelfRegistrationVerifyByEmail is enabled.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8033: Change javascipt behavior to degrade nicely
Jared Camins-Esakov [Thu, 13 Dec 2012 17:48:16 +0000 (12:48 -0500)]
Bug 8033: Change javascipt behavior to degrade nicely

Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8033 follow-up removing tabs in indentation
Paul Poulain [Wed, 12 Dec 2012 07:47:41 +0000 (08:47 +0100)]
Bug 8033 follow-up removing tabs in indentation

Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8033: This patch adds print slips to self checkout.
Elliott Davis [Thu, 5 Jul 2012 14:46:54 +0000 (09:46 -0500)]
Bug 8033: This patch adds print slips to self checkout.

To Test:

Sign in to self checkout.
Enter a barcode and click submit.
Click the finish button
You should be prompted with a message asking if you would like a receipt.
If you click OK you should be taken to the page with the receipt.
If you click Cancel you should not see the reciept and you should be logged out.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Added copyright to print slip for SCO

Modified POD and copyright.  Also perltidied

updated print slip option to show on the click of the finish button instead of the submit button

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8039 follow-up: replace tabs by 4 spaces (QA process)
Paul Poulain [Mon, 10 Dec 2012 20:21:03 +0000 (21:21 +0100)]
Bug 8039 follow-up: replace tabs by 4 spaces (QA process)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 8039: Try userid if cardnumber borrower search fails in SIP
Srdjan [Wed, 30 May 2012 01:38:35 +0000 (13:38 +1200)]
Bug 8039: Try userid if cardnumber borrower search fails in SIP

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 5709: Add the ability to translate HTML5 placeholder text in an input field
koha-preprod [Mon, 7 Feb 2011 20:59:18 +0000 (15:59 -0500)]
Bug 5709: Add the ability to translate HTML5 placeholder text in an input field

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9275 follow-up: Add Romina Racca to history
Jared Camins-Esakov [Wed, 12 Dec 2012 23:39:08 +0000 (18:39 -0500)]
Bug 9275 follow-up: Add Romina Racca to history

Welcome, Romina! You are the 195th committer to Koha.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9275 Missing '<' closing pharagraph tag
Romina Racca [Wed, 12 Dec 2012 16:16:16 +0000 (13:16 -0300)]
Bug 9275 Missing '<' closing pharagraph tag

On file koha-tmpl/intranet-tmpl/prog/en/modules/help/authorities/authorities.tt,
line 5,
there is a missing '<'. (...'New Authority' button.,/p>)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Small change, fixes obvious problem.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9246: Koha installer crash with mysql error
Marc Veron [Tue, 11 Dec 2012 09:43:18 +0000 (10:43 +0100)]
Bug 9246: Koha installer crash with mysql error

The Koha installer reports "Error 1166 at line 1871: Incorrect column
name 'closed'." Reason: line 1923 in kohastructure.sql had whitespace
between back tick on Column name "closed".

Patch removes white space on given line.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Elliott Davis <elliott@test.bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9101: Add REPORT_GROUP to sample data
Katrin Fischer [Sat, 17 Nov 2012 19:45:13 +0000 (20:45 +0100)]
Bug 9101: Add REPORT_GROUP to sample data

To test:
Option 1) Run the English and German web installer and check authorised values
have been added correctly.

Option 2) Run SQL code from auth_val.sql for German and English against your
database and check the authorised values have been added correctly.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9033: Wide character error in runreport.pl
Julian Maurice [Thu, 22 Nov 2012 16:19:41 +0000 (17:19 +0100)]
Bug 9033: Wide character error in runreport.pl

This patch fix a typo that prevented report to be run

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9033 - Wide character error in runreport.pl
Kyle M Hall [Thu, 8 Nov 2012 15:39:32 +0000 (10:39 -0500)]
Bug 9033 - Wide character error in runreport.pl

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9019: Return item fields in ILS-DI GetRecords
Julian Maurice [Wed, 7 Nov 2012 09:51:49 +0000 (10:51 +0100)]
Bug 9019: Return item fields in ILS-DI GetRecords

Signed-off-by: Srikanth Dhondi <srikanth@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
1) Activate ILS-DI in system preferencs
2) Access http://.../cgi-bin/koha/ilsdi.pl to see documentation
3) Try http://.../cgi-bin/koha/ilsdi.pl?service=GetRecords&id=12+14
   with various valid biblionumbers for your system
4) Verify 952 is included in the <marcxml> and all other data displays
   correctly

All tests pass.

http://bugs.koha-community.org/show_bug.cgi?id=9010
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9191 follow-up: remove example updatedatabase stanzas
Jared Camins-Esakov [Tue, 11 Dec 2012 13:29:11 +0000 (08:29 -0500)]
Bug 9191 follow-up: remove example updatedatabase stanzas

The patch for bug 9191 included example updatedatabase stanzas that
require removal before pushing. This patch also updates the
00-checkdatabase-version.t test so that it will not give
false-positives.

11 years agoBug 9191: updatedatabase.pl should only run updates up to the current version
Jared Camins-Esakov [Mon, 3 Dec 2012 21:28:51 +0000 (16:28 -0500)]
Bug 9191: updatedatabase.pl should only run updates up to the current version

Check whether a given update should be run when passed the proposed
version number. The update will always be run if the proposed version
is greater than the current database version and less than or equal to
the version returned by C4::Context->final_linear_version (initially set
to be equal to the version in kohaversion.pl). The update is also run if
the version contains XXX, though this behavior will be changed following
the adoption of non-linear updates as implemented in bug 7167.

To test:
1) Make sure that the first example database update added by this patch
   in installer/data/mysql/updatedatabase.pl has a version number one
   greater than the version of Koha you have installed.
2) Set the Version syspref back one version behind your current version.
3) Navigate to the main page of the staff client, and log in to the
   installer.
4) Confirm that the update page claims to have rerun the previous update
   and has displayed the log message:
   "Upgrade to 3.11.00.XXX done (Bug 9191: You should see this)"
   but not the log message:
   "Upgrade to [version number] done (Bug 9191: You shouldn't see this)"

Note: the sample database revisions will be removed by the RM before
this patch is pushed to master.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
works great

Signed-off-by: Elliott Davis <elliott@test.bywatersolutions.com>
Works as expected.  Test plan is great. Code looks to be adherent to standards.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9056: Increment version number
Jared Camins-Esakov [Tue, 11 Dec 2012 13:13:07 +0000 (08:13 -0500)]
Bug 9056: Increment version number

Database update for bug 9056 has been given version 3.11.00.007

11 years agoBug 9056 - Add more translations to table language_descriptions
Marc Veron [Sun, 11 Nov 2012 21:00:19 +0000 (22:00 +0100)]
Bug 9056 - Add more translations to table language_descriptions

In table language_descriptions a lot of translations are missing (with the exception of French)

Additions need to be added to subtag_registry.sql (for new installs) and to updatedatabase.pl (for upgrading).

This Bug could be used as 'omnibus' for follow ups for other languages.

This patch adds German (and some missing French) translations.

Tested updatedatabase.pl
Would appreciate if somebody could test subtag_registry.sql.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested both, the updatedatabase and the sql file. Works well.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9049: Don't use shadow with rebuild_zebra -r
Jared Camins-Esakov [Sat, 10 Nov 2012 12:51:22 +0000 (07:51 -0500)]
Bug 9049: Don't use shadow with rebuild_zebra -r

Due to a limitation of Zebra, the register must be cleared *before*
doing shadow indexing if you want to reset the indexes. In light of
that, it does not make sense to do shadow indexing at all when
rebuild_zebra.pl is run with the -r switch. This patch makes -r (reset)
imply -n (no shadow).

To test:
1) Run `rebuild_zebra.pl -b -r -v -v -v`
2) Note that the script never runs the merge phase

Without the patch I see log lines refering to the shadow cache (enabling shadow spec=/home/koha/koha-dev/var/lib/zebradb/biblios/shadow:20G)
With the patch I don't see anything in the logs about shadow.  I do however see lines about merging.  I think it could just be a misunderstanding of the logs

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_8519' into 3.12-master
Jared Camins-Esakov [Sat, 8 Dec 2012 14:45:44 +0000 (09:45 -0500)]
Merge branch 'bug_8519' into 3.12-master

11 years agoMerge branch 'bug_7919' into 3.12-master
Jared Camins-Esakov [Fri, 7 Dec 2012 23:30:36 +0000 (18:30 -0500)]
Merge branch 'bug_7919' into 3.12-master

11 years agoBug 7919: Fix unit test (Members_AttributeTypes.t)
Jonathan Druart [Thu, 6 Dec 2012 09:08:23 +0000 (10:08 +0100)]
Bug 7919: Fix unit test (Members_AttributeTypes.t)

- Reintroduce the class column in a select statement (was present before
  this development)
- FIX UT: If there are no arg passed in parameter, the routine calls
  C4::Context->userenv which call an execute statement. It consumes the
  mocked resultset

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Elliott Davis <elliott@test.bywatersolutions.com>
All tests successful.
Files=1, Tests=9,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.16 cusr  0.06 csys =  0.25 CPU)
Result: PASS