Galen Charlton [Mon, 11 May 2009 21:19:20 +0000 (16:19 -0500)]
fix references to $session in circ/circulation.pl
Now that sticky due date processing uses the session,
script will always need it.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Michael Hafen [Mon, 11 May 2009 20:52:35 +0000 (14:52 -0600)]
Make stickyduedate remember for session a little more permanent
Store the stickyduedate in the session. So "Remember for Session" means
for session rather than "while on this page".
Includes some updates since initial submission of patch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Mon, 11 May 2009 21:10:37 +0000 (16:10 -0500)]
fix to CanBookBeIssued()
Bail out if item does not exist - otherwise
subsequent checks can fail for lack of an
item branchcode.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Mon, 11 May 2009 19:26:23 +0000 (14:26 -0500)]
bug 988 followup - tweak wording
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Paul Poulain [Sat, 18 Apr 2009 20:51:41 +0000 (22:51 +0200)]
fix for #988
When a borrower can't issue any book (issuingrules=0), the message should be
"this user can't issue book" and not "too many books already issued"wrong message
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Mon, 11 May 2009 16:39:19 +0000 (11:39 -0500)]
tweak removal of whitespace from barcodes
Per suggestion from Joe Atzberger, match on \s
instead of [ \t] for stripping leading and
trailing whitespace from barcode lookups.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Mason James [Thu, 19 Mar 2009 22:52:26 +0000 (11:52 +1300)]
fix to remove leading/trailing whitespace from entered barcode.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Michael Hafen [Wed, 6 May 2009 22:15:08 +0000 (16:15 -0600)]
bugfix stickyduedate more sticky - couple more forms in circulation.tmpl
There are a couple more forms in circulation.tmpl that need the
stickyduedate and duedatespec hidden inputs. The 'Don't Check Out' form
of the needsconfirmation block, and the findborrower form.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Michael Hafen [Wed, 6 May 2009 22:34:47 +0000 (16:34 -0600)]
bugfix stickyduedate more sticky - also patron search in quick search block
Forgot about the patron search for check out form in the quick search
block
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Mon, 11 May 2009 14:51:46 +0000 (16:51 +0200)]
add windows quote to ignored chars
This patch add the CP1252 "quote" (’) in ignored chars in zebra configuration.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Mon, 11 May 2009 15:48:14 +0000 (10:48 -0500)]
change DOS newlines to Unix newlines in word-phrase-utf.chr
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Frédéric Demians [Thu, 30 Apr 2009 15:23:17 +0000 (17:23 +0200)]
Bugfix 3176 - Browser selected languages are not use by OPAC
This patch uses HTTP_ACCEPT_LANGUAGE web browser variable
to select OPAC available language.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Michael Hafen [Wed, 29 Apr 2009 22:02:11 +0000 (16:02 -0600)]
Tweak ceilingDueDate and CalcDateDue
This patch moves ceilingDueDate and ReturnBeforeExpiry checking into
CalcDateDue(), so the renewal due date is also calculated with those.
Also restores a check in CanBookBeIssued. If the due date isn't given
call CalcDateDue and make sure it's not in the past.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Thu, 7 May 2009 09:48:44 +0000 (11:48 +0200)]
(bug #3196) fix itemlost.pl
This patch fix 3 things:
* fix order by
* take care of item_level-itype
* use join in sql query
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Liz Rea [Fri, 1 May 2009 20:26:41 +0000 (15:26 -0500)]
Bug 1984 - added Javascript in the header to open, print, and close the slip window
This is for printing circulation slips.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Catalfo [Fri, 1 May 2009 23:34:43 +0000 (23:34 +0000)]
bug 1907 Partial fix: prevent bad records from truncating output.
This patch starts improving export.pl by adding warnings, skipping invalid records, and not trying to access fields which don't exist.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Fri, 8 May 2009 20:10:15 +0000 (15:10 -0500)]
bug 3212: MARC21 bib leader plugin sets Leader/09 to 'a'
Changed the plugin so that the form for editing the MARC21
leader now sets postion 9 (character coding) to 'a' (UCS/Unicode)
and no longer gives the cataloger the option to change it. Koha
uses UTF-8 exclusively for MARC records, and a number of bugs
can be triggered by storing MARC21 bib and authority record
whose Leader/09 is anything other than 'a'. Since internal
routines are increasingly ensuring that the MARC21 Leader/09 is
set to 'a', it doesn't make sense to give catalogers the idea
that it's possible (or a good idea) to set the Leader/09 to any
other value.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Fri, 8 May 2009 20:10:14 +0000 (15:10 -0500)]
bug 3211: fix XHTML validation errors in MAR21 bib leader plugin
Note that as a result of this patch, not only will the
page use valid XHTML, but the intranet stylesheets are
now used, IMO improving the display of the form.
This patch also fixes the descriptions of the Leader/09
and Leader/17.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Fri, 8 May 2009 20:10:13 +0000 (15:10 -0500)]
bug 3209: add 'p' (mixed materials) to MARC21 Leader/06 dropdown
Also made the following updates to the MARC21 leader plugin
[1] Changed description of Leader/08 to 'Type of control'
[2] Fixed typo in description value for 'z' in Leader/17
[3] Updated Leader/19, which is now 'Multipart resource record level'
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Mon, 11 May 2009 08:46:58 +0000 (10:46 +0200)]
(bug #3198) fix serial receive with autobarcode
this add an arg to GetMarcFromKohaField, else it will always return (0,0).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Sun, 10 May 2009 09:49:23 +0000 (21:49 +1200)]
Adding the irc meeting and maintenance tree to the history
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Frédéric Demians [Mon, 11 May 2009 11:41:49 +0000 (13:41 +0200)]
Bug 3213 - UNIMARC/MARC21 selection
Modify how XSLT stylesheet are choosen
depending on 'marcflavour' syspref.
DOCUMENTATION: XSLTResultsDisplay and XSLTDetailsDisplay
sysprefs aren't MARC21-only anymore.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Frédéric Demians [Mon, 11 May 2009 11:41:50 +0000 (13:41 +0200)]
Bug 3213 - Add UNIMARC XSLT stylesheet
With those stylesheets result and detail pages
render better UNIMARC biblio record than normal
views. But works still have to be done in order
to reach UNIMARC-ISBD compliant display.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Thu, 30 Apr 2009 16:36:19 +0000 (11:36 -0500)]
More fixes for Bug 2704, 440 Display Issues
Multiple series now display along with other detailed bibliographic information. Series title is displayed along with volume information. The template no longer displays information from biblioitems like volume and volumedesc in favor of information pulled directly from the MARC record.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Ryan Higgins [Thu, 7 May 2009 18:19:05 +0000 (11:19 -0700)]
bug 3195 : Item Transfers and Holds disrupted.
This follows revert of commit
257a439d (bug 3025).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Ryan Higgins [Thu, 7 May 2009 18:19:04 +0000 (11:19 -0700)]
Revert "(bug #3025) multiple check-in of a multiple times reserved item go wrong"
This reverts commit
257a439dafa33d0c642f1ec7badedb5414027e64.
This patch causes Bug 3195 .
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Wed, 6 May 2009 08:50:51 +0000 (10:50 +0200)]
(bug #3190) allow right truncation in lot of records
This patch just add an option to zebra-biblios.cfg that allow to make right truncate requests on a huge request.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Mon, 4 May 2009 15:16:45 +0000 (17:16 +0200)]
(bug #3174) show the member name in reports
this patch show the member firstname and surname instead of only the borrowernumber in the guided reports page
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Fri, 8 May 2009 13:44:03 +0000 (08:44 -0500)]
bug 2287: handle case where autoMemberNum is off
When importing a patron file where new records
do not have a card number *and* autoMemberNum is
off, make sure that bororwers.cardnumber is set to NULL
for those new patrons rather than '' - otherwise, only
one patron with an empty barcode can be created, as there is
a uniqueness constraint on borrowers.cardnumber
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
MJ Ray [Tue, 5 May 2009 15:52:47 +0000 (16:52 +0100)]
Allow autogenerated cardnumbers again to solve bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2287
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Mon, 4 May 2009 09:22:15 +0000 (11:22 +0200)]
(bug #3183) fix the SetMarcUnicodeFlag function
This patch fix the funciton SetMarcUnicodeFlag for UNIMARC support, now the function will fix the length of the field, and set encoding as "50 " instead of "5050".
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Frédéric Demians [Thu, 7 May 2009 17:28:33 +0000 (19:28 +0200)]
Optimize XSLT.pm
Avoid reading marc_tag_structure for each biblo record to
transform by XSLT. Not totaly useless on OPAC result page.
Should be done via application variables rather than
request variable, but this is another story.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Sat, 2 May 2009 18:35:14 +0000 (13:35 -0500)]
Add system preference search to administration home page (Bug 3181)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Frédéric Demians [Thu, 7 May 2009 16:57:26 +0000 (18:57 +0200)]
Bugfix 3199 - batchRebuildBiblioTables.pl failed due to missing argument [3.0.x]
Thanks G. Henry
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Fri, 1 May 2009 22:59:04 +0000 (17:59 -0500)]
fix all templates errors reported by xt/author/valid-templates.t
In process, removed four disused HTML templates and one
disused script, serials/receipt.pl.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Sun, 3 May 2009 05:02:22 +0000 (17:02 +1200)]
Bug 2944 fix courtesy of Amr Denni
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Colin Campbell [Thu, 7 May 2009 13:59:25 +0000 (14:59 +0100)]
(bug #3197) Subfield code box was not present on new subfield tab in Admin/Authority
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Sat, 2 May 2009 16:40:50 +0000 (11:40 -0500)]
Spelling correction
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Fri, 1 May 2009 23:50:16 +0000 (11:50 +1200)]
Adding David Birmingham and Collin Campbell as a developer
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Colin Campbell [Tue, 5 May 2009 09:36:41 +0000 (10:36 +0100)]
Moved some variable definitions out of conditionals
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Sun, 3 May 2009 04:23:14 +0000 (00:23 -0400)]
Bug 3081 - The category code in the patron personal details page in opac showed the category code and not the description. This patch makes the description appear instead. Looking at both opac-userupdate.pl and opac-userupdate.tmpl, the actual value of this text box is not retrieved for any purpose.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Wed, 6 May 2009 10:26:55 +0000 (12:26 +0200)]
(bug #3193) fix the comtd value in acqui-home.pl
this patch fix the value of the comtd value which is not the same as in bookfund.pl, clicking on the value from acqui-home.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Mon, 4 May 2009 20:16:01 +0000 (15:16 -0500)]
Remove duplicate assignments for $template->param(script_name)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Wed, 6 May 2009 19:41:51 +0000 (14:41 -0500)]
Bug 3157: IE compatibility for label display
Also fixed validation errors where label elements were "for" non-existant ids.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Mon, 9 Mar 2009 13:38:06 +0000 (08:38 -0500)]
Changes to tabindex values to improve keyboard access.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Tue, 23 Dec 2008 14:14:27 +0000 (15:14 +0100)]
(bug #2750) Cannot return to another branch if the independantbranch option is set as ON
The code was modified to change the holding branch ONLY if the return to the right branch is done. If you set IndependantBranch to on, you must return the document to the HomeBranch.
And verify the return is done before show the message that allow to transfert the document to another branch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Wed, 26 Nov 2008 20:46:07 +0000 (14:46 -0600)]
Cleaning up Self-Checkout interface, adding some basic formatting based on other standard styles.
Patch also removes a hard-coded English string from the script and some unused functions from sco.js.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Henri-Damien LAURENT [Wed, 6 May 2009 13:42:19 +0000 (15:42 +0200)]
UpdateDatabases for 3.0.2
updating elements in order to make 3.0.2 work
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Danny Bouman [Thu, 20 Nov 2008 14:35:26 +0000 (09:35 -0500)]
bug 2687 followup: Increase maxlength attribute to support 64 characters
Modified the borrower attribute and borrower password fields to support a maxlength of 64 characters.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Thu, 30 Apr 2009 15:04:38 +0000 (10:04 -0500)]
Bug 3177 - haspermission offers bogus option
$intflags was never used or returned if hashref instead of userid was passed.
Also cleaned up needless passing of $dbh.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Tue, 21 Apr 2009 19:12:55 +0000 (14:12 -0500)]
Adding link back to OPAC for emailed cart and lists.
Correction to previous patch: uses "online catalog" in place of "OPAC" following the example of other text on the page
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Sat, 18 Apr 2009 23:25:42 +0000 (18:25 -0500)]
bug 3141: use quoted printable encoding in cart/list emails
Ensure that emails sent from lists and the cart in the
OPAC have the correct quoted-printable encoding. Otherwise,
if there is an equals sign followed by one or two characters
that look like hexadecimal digits in body of the email, the
results can look mangled in some email clients.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Mon, 12 Jan 2009 22:16:47 +0000 (16:16 -0600)]
bug 2908 followup - use "list", not "shelf"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Sat, 18 Apr 2009 21:45:22 +0000 (16:45 -0500)]
Setting focus on form fields
This patch includes an addition to the OPAC's default js (identical to one in the staff client) which lets you add a "focus" class to an element on the page and have javascript move the focus to that element (input or link).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Tue, 14 Apr 2009 19:46:58 +0000 (14:46 -0500)]
Corrected: fix for Bug 3112, Emailed list contains too much whitespace
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Tue, 5 May 2009 09:52:36 +0000 (11:52 +0200)]
(bug #3187) authority search pagination doesn't work
this patch just set a marclist argument value on search authority, else the pagination won't work.
Nahuel ANGELINETTI [Wed, 25 Mar 2009 16:34:31 +0000 (17:34 +0100)]
(bug #3058) show items that are excluded of loan in search results
This patchs show all items that are available for reading to the library but excluded of loan.
And don't show them as same way as "damaged" or other "not for loan" status.
Nahuel ANGELINETTI [Wed, 25 Mar 2009 15:08:48 +0000 (16:08 +0100)]
(bug #3057) mandatory subfield edition
modify the "name" of mandatory input field.
Nahuel ANGELINETTI [Mon, 23 Mar 2009 16:14:30 +0000 (17:14 +0100)]
(bug #3053) extract ISBD view generator, and permit to display valuecode in ISBD view
this patch extract the generator of ISBD view in a C4 function, because it's used in intranet AND in OPAC but with 2 separate codes.
Now it's more reusable.
Nahuel ANGELINETTI [Mon, 23 Mar 2009 12:00:03 +0000 (13:00 +0100)]
(bug #3051) bad support of pagination in auth_finder
This patch change the page to use GET instead of post, and use independants "input"
names for searched values. Else the args are not passed to the next page due to
rewrite rules.
Nahuel ANGELINETTI [Tue, 10 Mar 2009 14:24:47 +0000 (15:24 +0100)]
(bug #3025) multiple check-in of a multiple times reserved item go wrong
This patch check that an item is not "Waiting" before do something in GetOtherReserves(because is the item is waiting, we don't need to do something).
Nahuel ANGELINETTI [Fri, 6 Mar 2009 11:24:29 +0000 (12:24 +0100)]
(bug #3011) csv export doesn't fill all the fields
This patch just fix the script which export to csv the overdue, and field the missing fields
Nahuel ANGELINETTI [Tue, 3 Feb 2009 08:45:48 +0000 (09:45 +0100)]
(bug #2939) delete a warning
just add a default value to $sep
Nahuel ANGELINETTI [Fri, 30 Jan 2009 16:17:12 +0000 (17:17 +0100)]
(bug #2938) add a serials subscriptions report
this patch add a report for serials.
It's have to limit branch/bookseller, and excluding expired serials.
It's possible to export in CSV format.
This patch will have another, to add this report in menus.
Nahuel ANGELINETTI [Mon, 12 Jan 2009 09:32:14 +0000 (10:32 +0100)]
(bug #2908) adding send shelf by e-mail feature
This patch add the form for sending shelf by e-mail, and add a button in shelves that allow the user to send a shelf.
It's an approximate copy of the send basket feature.
David Birmingham [Thu, 30 Apr 2009 16:54:48 +0000 (12:54 -0400)]
Bug fix to OPAC shelf browsing query statement
If the items.location field was NULL, then the current
SQL query would produce no results. I have turned this
into a conditional block that removes the location condition
in the query if the location is not specified.
In addition, there was a small change to opac-detail.tmpl
that changed Library to Shelves when the shelf browser was
open. This removes a potential redundant Library Library
display if Library is contained in the starting_homebranch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Fri, 1 May 2009 21:39:25 +0000 (09:39 +1200)]
Adding warnings, fixing a bug that meant the title of an item that had a fine was never printed
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Fri, 1 May 2009 01:54:31 +0000 (21:54 -0400)]
Bug #2974 Adding category code to BorrowerMandatoryField produced a "The following fields are mandatory: categorycode"
If you made a column that is implemented by a select box mandatory in
BorrowerMandatoryField, Members.js would throw an error on the first
element. The original intent of the function was probably to catch
the first option for a drop-down list such as "Salutation" where the
text is blank. Added code to check for an empty string in the first
element.
You can test this by making salutation (title) mandatory.
Also fixed some typos in some of the comments. Why? Because I'm a Librarian.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Thu, 30 Apr 2009 09:36:52 +0000 (11:36 +0200)]
(bug #3174) fill borrower number, and show author and creation date in saved reports
This patch add 2 columns in "Use Saved" page whith creation date, and the creator id.
It fix the creation of a report, to save the borrowernumber in reports table(to show it after).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Wed, 29 Apr 2009 21:51:11 +0000 (16:51 -0500)]
new author test for syntax errors in HTML templates
Added a new author test to look for syntax errors
in the HTML templates. Run by doing
prove xt/author/valid-templates.t
from the root of a Koha source tree.
This test will help catch the following errors:
* unbalanced TMPL_IF, TMPL_UNLESS, and TMPL_LOOP contructs, e.g.,
cases where a TMPL_IF is not closed by a /TMPL_IF.
* references to nonexistant include files
* syntax errors within a HTML::Template::Pro tag
This test currently ignores errors related to TMPL_IF EXPR, which
is currently deprecated for use in Koha -- this may be made
stricter in the future.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Fri, 1 May 2009 21:17:26 +0000 (16:17 -0500)]
fix XHTML validation error introduced in previous patch
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Jane Wagner [Wed, 29 Apr 2009 18:14:56 +0000 (14:14 -0400)]
Enhancements/fixes for OPAC advanced search screen
Fixed opac-search.pl for correct test of expanded options and
to pass variable for MARC21 to advanced search screen.
Added Publication Date Range search to advanced search screen
Removed obsolete item type code section from advanced search screen
(wasn't displaying anyway because expanded options wasn't working,
superceded by site-specific item type searches).
Changed wording on Additional Content Types pulldown to make clear
it's limited to Books/Printed Materials -- this is basing off the
008 positions 24-27, but the options (and those positions) are only
valid for Book material types. Other material types have different
008 settings in those positions.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Thu, 30 Apr 2009 17:15:12 +0000 (12:15 -0500)]
Remove unused $toggle code
Some trivial other cleanups also.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Thu, 30 Apr 2009 21:41:08 +0000 (09:41 +1200)]
Adding the creation of sql library on the wiki
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Colin Campbell [Fri, 1 May 2009 08:32:27 +0000 (09:32 +0100)]
Correct comparison which was using an octal number
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Thu, 30 Apr 2009 03:33:13 +0000 (15:33 +1200)]
Adding Liz Rea to the history.txt
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Thu, 30 Apr 2009 18:06:24 +0000 (13:06 -0500)]
fix to C4::Koha::_isbn_cleanup
Both valid ISBN-10s and -13s can use 'X' as a checkdigit
value.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
root [Thu, 30 Apr 2009 16:42:23 +0000 (11:42 -0500)]
Verbiage clarification in intranet advsearch.tmpl
Changed verbiage from Limit type to: match any of the following to Limit to any of the following:
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Liz Rea [Thu, 30 Apr 2009 16:30:26 +0000 (11:30 -0500)]
Libraryspeak extinction in OPAC: Verbiage Change opac-advsearch.tmpl
Changed verbiage from Limit type to: match any of the following to Limit to any of the following:
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Wed, 29 Apr 2009 21:52:13 +0000 (09:52 +1200)]
Whoops I typo'd Garry's name - fixed
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
root [Wed, 29 Apr 2009 18:14:45 +0000 (13:14 -0500)]
Usability change: widened the search type dropdown from 9em to 10em so that it doesn't look cramped.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Wed, 29 Apr 2009 20:24:19 +0000 (08:24 +1200)]
Updating history docs for new developer
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Liz Rea [Wed, 29 Apr 2009 16:22:53 +0000 (11:22 -0500)]
Usability change: Added example of 5.00 to fines/manual credit and fines/manual invoice to remind folks that they do not have to add the dollar sign (or other international money symbol) before the amount.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Michael Hafen [Tue, 28 Apr 2009 20:16:31 +0000 (14:16 -0600)]
OPAC Advanced Search - have user's branch selected by default
If SearchMyLibraryFirst is on, and the user is logged in, then have
their branch selected in the Location And Availability drop-down.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Michael Hafen [Tue, 28 Apr 2009 20:24:17 +0000 (14:24 -0600)]
Checkout page - Check Out's table sortable on barcode
Add the barcode column of the Check Out's table to the tablesorter
setup.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Wed, 29 Apr 2009 02:55:21 +0000 (22:55 -0400)]
minPasswordLength not returning user back to systempreferences.pl?tab=Patrons. Incorrect reference MinPasswordLength fixed. Could not find bug report.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Tue, 28 Apr 2009 17:08:31 +0000 (12:08 -0500)]
Bug 3126: remove comma for IE7
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Tue, 28 Apr 2009 23:32:27 +0000 (11:32 +1200)]
Bug 2505 adding warnings to opac-authorities-home and fixing warnings generated
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Jane Wagner [Tue, 28 Apr 2009 12:01:25 +0000 (08:01 -0400)]
Bugs 2822, 2551, 3163 fixes to XSLT
Resent with additional comments.
Bug 2822 -- for leader6 types of i (nonmusical) or j (musical), the hitlist
uses an icon and label of Sound while the record display page uses
Music. Modified record display to use Sound.
Bug 2551 -- for leader7 type of i says it's type Serial which is incorrect.
The bug report suggested Integrating Resource" but the latest install's
hitlist page uses Continuing Resource. Changed the record display page
to also use Continuing Resource.
Bug 3163 -- if you have a 110 or 710 with a subfield a and a subfield b,
there's no space between them (on either hitlist or record display).
The two headings run together in the display. Modified the utils file
to force a space.
The XSLT files referenced two icons which did not exist (globe.png and
drive_remote.png. Replaced those with icons from the same subject area
(world.png and drive_web.png). Also, corrected spelling of icon name
from pencile.png to pencil.png.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Tue, 28 Apr 2009 13:58:05 +0000 (08:58 -0500)]
fix DOS newlines in MARC21slimUtils.xsl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Tue, 23 Dec 2008 14:14:27 +0000 (15:14 +0100)]
(bug #2750) Cannot return to another branch if the independantbranch option is set as ON
The code was modified to change the holding branch ONLY if the return to the right branch is done. If you set IndependantBranch to on, you must return the document to the HomeBranch.
And verify the return is done before show the message that allow to transfert the document to another branch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Mon, 27 Apr 2009 15:13:08 +0000 (17:13 +0200)]
(bug #2961) change the workflow of the new issue
This patch change the operations, it add a new expected if no one expected exists, else it create new excepted, and set the others as "late"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Mon, 27 Apr 2009 15:31:03 +0000 (10:31 -0500)]
bug 2915 followup - small efficiency improvement
Following up on a suggestion by Joe Atzberger, save
a database query by not counting the subscriptions
to delete; instead, simply fetch a list of them.
No user-visible change.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Thu, 23 Oct 2008 20:56:22 +0000 (15:56 -0500)]
Followup (1 of 2) to: Correct iso639_2_code for Spanish is "spa" not "rus".
updatedatabase change deferred for now.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Mon, 13 Oct 2008 16:46:14 +0000 (11:46 -0500)]
Correct iso639_2_code for Spanish is "spa" not "rus".
The result of this apparent copy/paste error is that adv. search
limits by Language=Spanish would return results for Russian!
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Fri, 24 Apr 2009 22:31:53 +0000 (17:31 -0500)]
Bug 3114 - IE7 spacing needs width: 100% to avoid line collapse.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Sun, 26 Apr 2009 16:45:24 +0000 (11:45 -0500)]
bug 3161: don't display blank language chooser
If more than one translation is installed but only one is active, a blank div
is displayed at the bottom of all pages in the intranet (and in the OPAC if the
opacchangelanguages system preference is ON), taking a bit of vertical real
estate needlessly.
Changed so that <div> for the language chooser is output
only if there is more than one enabled language.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Mon, 27 Apr 2009 00:17:21 +0000 (12:17 +1200)]
Whoops missed Brendan's commit, fixed the history now
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Sun, 26 Apr 2009 15:23:55 +0000 (10:23 -0500)]
bug 2505: fix more warnings in opac-search.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Sat, 25 Apr 2009 04:49:48 +0000 (16:49 +1200)]
Bug 2505 Adding use warnings, and fixing the warnings generated
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>